Skip to content

ci: extend Windows credential host job timeout for cold cache saves - #1662

Merged
skevetter merged 1 commit into
mainfrom
fix/flake-credential-service-hang
Oct 23, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/flake-credential-service-hang

Conversation

@skevetter

@skevetter skevetter commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Raise GitHub Credential Host Tests job timeout-minutes to 30 on windows-latest (15 elsewhere).

Why

Run 39825063512, job 119986146484 was "cancelled" but no test hung. Every test step passed; the last finished at 17:53:37. The job then sat in the actions/setup-go post step. That step saves the cache with tar | zstd, after a cold run (Cache is not found: ~5 min compiling with -race, ~4.5 min downloading modules). The 15-minute job limit hit at 17:57:52, mid-save. Attempt 2 passed. provider-update-windows already carries a 30-minute limit for the same reason.

The macOS cancellation (run 39673119924, job 119476027572) is unrelated: the check-run annotation says "The job was not acquired by Runner of type hosted even after multiple attempts" (macOS arm64 capacity). No step ran, so no code change applies.

Validation

  • Local macOS: go test -race -count=1 on the three credential host selections in the workflow (pkg/ghcredentials, pkg/tunnel, pkg/credentials): all pass.
  • actionlint: no new findings; the one reported error (background key, line 576) is pre-existing.
  • Windows result needs CI; the cold-cache path is not reproducible locally.

CodeRabbit

Pending.

Summary by CodeRabbit

  • Chores
    • Adjusted the time limit for automated checks on Windows. Other runners retain their existing time limit. This change affects the project’s validation process and does not alter user-facing functionality.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 11d9fe9
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ada87c4ec9d3715110c3a32

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: af553fce-62b7-4988-bece-65a99d5821dd
📥 Commits

Reviewing files that changed from the base of the PR and between 1d61e36 and 11d9fe9.

📒 Files selected for processing: 1
  • .github/workflows/pr-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The github-credential-host-tests workflow job now uses a 30-minute timeout on windows-latest and a 15-minute timeout on other runners. A comment notes cold Windows compilation and module-download timing.

Changes: CI timeout

Layer / File(s) Summary
Set runner-specific timeout
.github/workflows/pr-ci.yml
The job uses a 30-minute timeout on windows-latest and a 15-minute timeout on other runners. A comment describes cold Windows compilation and module-download timing.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: atty303

Merge Risk: ⚪ Minimal · up to 11d9f

The runner-specific timeout change is appropriately scoped and ready to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change, cause, and validation clearly, but it does not follow the repository template. It omits the required change type, AI assistance details, issue reference, checklist… Reformat the description using the repository template. Mark the change as CI / build / tooling, provide an issue reference or state none, complete the AI assistance section and checklist, and document that no integration test is needed bec…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the CI job and the Windows timeout increase for cold-cache saves.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the change, cause, and validation clearly, but it does not follow the repository template. It omits the required change type, AI assistance details, issue reference, checklist, and explicit testing section.

Resolution

Reformat the description using the repository template. Mark the change as CI / build / tooling, provide an issue reference or state none, complete the AI assistance section and checklist, and document that no integration test is needed because this is a CI-only change. Keep the existing incident details and validation results under What and why and Testing.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 11d9fe9
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ada87c4f6cb1e9ce9498305

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Raises the Windows limit for GitHub Credential Host Tests from 15 to 30 minutes.

  • Windows credential host tests get a 30-minute job limit.

Reviews (1) · Last reviewed commit: "ci: extend Windows credential host job t..." · Reviewed by Greptile

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 39 minutes.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@skevetter
skevetter merged commit b084916 into main Oct 23, 2026
115 checks passed
@skevetter
skevetter deleted the fix/flake-credential-service-hang branch October 23, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant