You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: extend Windows credential host job timeout for cold cache saves - #1662
Raise GitHub Credential Host Tests job timeout-minutes to 30 on windows-latest (15 elsewhere).
Why
Run 39825063512, job 119986146484 was "cancelled" but no test hung. Every test step passed; the last finished at 17:53:37. The job then sat in the actions/setup-go post step. That step saves the cache with tar | zstd, after a cold run (Cache is not found: ~5 min compiling with -race, ~4.5 min downloading modules). The 15-minute job limit hit at 17:57:52, mid-save. Attempt 2 passed. provider-update-windows already carries a 30-minute limit for the same reason.
The macOS cancellation (run 39673119924, job 119476027572) is unrelated: the check-run annotation says "The job was not acquired by Runner of type hosted even after multiple attempts" (macOS arm64 capacity). No step ran, so no code change applies.
Validation
Local macOS: go test -race -count=1 on the three credential host selections in the workflow (pkg/ghcredentials, pkg/tunnel, pkg/credentials): all pass.
actionlint: no new findings; the one reported error (background key, line 576) is pre-existing.
Windows result needs CI; the cold-cache path is not reproducible locally.
CodeRabbit
Pending.
Summary by CodeRabbit
Chores
Adjusted the time limit for automated checks on Windows. Other runners retain their existing time limit. This change affects the project’s validation process and does not alter user-facing functionality.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: af553fce-62b7-4988-bece-65a99d5821dd
📥 Commits
Reviewing files that changed from the base of the PR and between 1d61e36 and 11d9fe9.
📒 Files selected for processing: 1
.github/workflows/pr-ci.yml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The github-credential-host-tests workflow job now uses a 30-minute timeout on windows-latest and a 15-minute timeout on other runners. A comment notes cold Windows compilation and module-download timing.
Changes: CI timeout
Layer / File(s)
Summary
Set runner-specific timeout .github/workflows/pr-ci.yml
The job uses a 30-minute timeout on windows-latest and a 15-minute timeout on other runners. A comment describes cold Windows compilation and module-download timing.
The runner-specific timeout change is appropriately scoped and ready to merge.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description explains the change, cause, and validation clearly, but it does not follow the repository template. It omits the required change type, AI assistance details, issue reference, checklist…
Reformat the description using the repository template. Mark the change as CI / build / tooling, provide an issue reference or state none, complete the AI assistance section and checklist, and document that no integration test is needed bec…
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly identifies the CI job and the Windows timeout increase for cold-cache saves.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Description check
Explanation
The description explains the change, cause, and validation clearly, but it does not follow the repository template. It omits the required change type, AI assistance details, issue reference, checklist, and explicit testing section.
Resolution
Reformat the description using the repository template. Mark the change as CI / build / tooling, provide an issue reference or state none, complete the AI assistance section and checklist, and document that no integration test is needed because this is a CI-only change. Keep the existing incident details and validation results under What and why and Testing.
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 39 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise
GitHub Credential Host Testsjobtimeout-minutesto 30 onwindows-latest(15 elsewhere).Why
Run 39825063512, job 119986146484 was "cancelled" but no test hung. Every test step passed; the last finished at 17:53:37. The job then sat in the
actions/setup-gopost step. That step saves the cache withtar | zstd, after a cold run (Cache is not found: ~5 min compiling with-race, ~4.5 min downloading modules). The 15-minute job limit hit at 17:57:52, mid-save. Attempt 2 passed.provider-update-windowsalready carries a 30-minute limit for the same reason.The macOS cancellation (run 39673119924, job 119476027572) is unrelated: the check-run annotation says "The job was not acquired by Runner of type hosted even after multiple attempts" (macOS arm64 capacity). No step ran, so no code change applies.
Validation
go test -race -count=1on the three credential host selections in the workflow (pkg/ghcredentials,pkg/tunnel,pkg/credentials): all pass.actionlint: no new findings; the one reported error (backgroundkey, line 576) is pre-existing.CodeRabbit
Pending.
Summary by CodeRabbit