Skip to content

ci: bound WSL2 setup with timeout and one retry - #1661

Merged
skevetter merged 1 commit into
mainfrom
fix/flake-wsl-buildkit-setup-hang
Oct 22, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/flake-wsl-buildkit-setup-hang

Conversation

@skevetter

@skevetter skevetter commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bound the setup WSL2 Ubuntu step in pr-ci.yml with timeout-minutes: 5 and retry it once. A second failure now fails in about 10 minutes at that step instead of the job being cancelled at its timeout.

Why

On main run 39684787193 the docker-buildkit-windows job (Windows WSL SSH build) stalled in setup WSL2 Ubuntu from 23:03 until the job was cancelled at 23:32. That step had no timeout, unlike the later provision, run and teardown steps. A healthy run finishes setup in about 40s (attempt 2 of the same run: 37s), and the rerun passed, so the hang is transient. Job logs for the cancelled attempt have expired, so the exact blocking call inside Vampire/setup-wsl is not confirmed.

Validation

  • actionlint .github/workflows/pr-ci.yml: only a pre-existing background key error on line 574, which this change does not touch.
  • CI on this PR, including the Windows WSL job.

CodeRabbit

Review requested; findings will be addressed before merge.

Summary by CodeRabbit

  • Chores
    • Updated the integration-test environment setup to allow up to five minutes per attempt and continue if the initial setup fails. When WSL setup is enabled, a second attempt runs if the first does not succeed.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 1a04d76
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ada87af137a124e6a8dfba9

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 1a04d76
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ada87af015b5c9ee80d23a7

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e813e6f0-3ff5-4d48-8328-bbe83cba4cbc
📥 Commits

Reviewing files that changed from the base of the PR and between 1d61e36 and 1a04d76.

📒 Files selected for processing: 1
  • .github/workflows/pr-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The integration-tests workflow adds a five-minute timeout to the initial WSL2 Ubuntu setup and adds a second attempt when setup is enabled and the initial attempt does not succeed.

Changes: WSL2 setup

Layer / File(s) Summary
Setup timeout and conditional retry
.github/workflows/pr-ci.yml
The initial WSL2 setup continues after failure and has a five-minute timeout. A second attempt runs when WSL setup is enabled and the initial attempt did not succeed; the retry also has a five-minute timeout.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: atty303

Merge Risk: ⚪ Minimal · up to 1a04d

The workflow bounds WSL setup and retries failures without an established merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change, motivation, observed failure, and validation. However, it does not follow the repository template and omits the Type of change, AI assistance, Testing, Checklist, … Update the description to include the required template sections. Mark the change as CI / build / tooling, complete the AI assistance and checklist items, document testing and manual verification, state whether an issue is fixed or referenc…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main CI change: adding a timeout and one retry to WSL2 setup.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the change, motivation, observed failure, and validation. However, it does not follow the repository template and omits the Type of change, AI assistance, Testing, Checklist, and Notes for reviewers sections.

Resolution

Update the description to include the required template sections. Mark the change as CI / build / tooling, complete the AI assistance and checklist items, document testing and manual verification, state whether an issue is fixed or referenced, and identify why no integration test is needed because this is a CI-only change.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 111bf64 into main Oct 22, 2026
114 checks passed
@skevetter
skevetter deleted the fix/flake-wsl-buildkit-setup-hang branch October 22, 2026 23:26
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Adds a five-minute limit to each WSL setup attempt and retries once after an unsuccessful first attempt.

  • WSL setup gets a five-minute limit and one retry.

Reviews (1) · Last reviewed commit: "ci: bound WSL2 setup with timeout and on..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant