Skip to content

refactor(e2e): table-drive configapply environment specs - #1657

Merged
skevetter merged 1 commit into
mainfrom
refactor/e2e-configapply-env-table
Oct 22, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/e2e-configapply-env-table

Conversation

@skevetter

@skevetter skevetter commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace the standalone containerEnv and remoteEnv lifecycle specs with one DescribeTable in e2e/tests/configapply/configapply.go.
  • Keep both spec names, values, marker paths, setup/cleanup order, timeout, and assertions.

Why

The two environment specs repeat the same container, temp directory, apply command, cleanup, and assertion setup. A table shares that path while retaining both cases and their existing names. This is a focused test-only cleanup in a file clear of recent and open PR overlap.

Validation

  • mise run cli:format passed.
  • mise run cli:lint:ci passed.
  • go vet ./e2e/... passed.
  • go test ./e2e/framework/... passed.
  • go tool ginkgo --dry-run --label-filter=config-apply ./e2e passed; 9 specs selected and both environment spec names present.
  • mise run cli:test:e2e:suite config-apply passed; 9 specs.
  • CI passed on head 7caefd0899f0ea7c16bb1be7642775dee17e18c8: Test config-apply on ubuntu-latest, the full 92-job integration matrix, and CI Success.

CodeRabbit CLI

Completed on the current head; 0 findings.

Auto-merge

Eligible: yes. Test-only e2e change, one file, 0 non-test changed lines (69 raw changed lines in specs).

Next

None.

Summary by CodeRabbit

  • Tests
    • Expanded configuration end-to-end coverage to verify that containerEnv and remoteEnv values are available during the post-create lifecycle hook.

@skevetter skevetter added the e2e-refactor e2e refactor label Oct 22, 2026
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 7caefd0
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ada5b759f7b716971101d57

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 76d12a3e-c99a-4dcf-bc28-eb82e5be705c
📥 Commits

Reviewing files that changed from the base of the PR and between ed43aa2 and 7caefd0.

📒 Files selected for processing: 1
  • e2e/tests/configapply/configapply.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The config-apply end-to-end tests now use one table-driven test to check values from containerEnv and remoteEnv. Each case writes the configured value to a marker file from postCreateCommand and checks the marker.

Changes: Config-apply environment tests

Layer / File(s) Summary
Environment variable marker checks
e2e/tests/configapply/configapply.go
A table-driven test checks containerEnv and remoteEnv values through marker files. Both cases use the shared lifecycle-hook timeout.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 7caef

Both environment checks remain intact, and no issue requiring a fix before merge was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the main change: replacing repeated config-apply environment specs with a table-driven test.
Description check Passed The description clearly explains what changed, why it changed, and how it was validated. It reports relevant formatting, lint, vet, unit, dry-run, e2e, and CI results. It does not use the repository t…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains what changed, why it changed, and how it was validated. It reports relevant formatting, lint, vet, unit, dry-run, e2e, and CI results. It does not use the repository template headings and omits explicit issue, change-type, AI-assistance, and checklist entries, but the core information is complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 7caefd0
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ada5b75767987191f93075b

@skevetter
skevetter marked this pull request as ready for review October 22, 2026 20:01

Copy link
Copy Markdown
Contributor Author

@greptileai review

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Replaces the two environment specs with one DescribeTable.

  • The container and remote environment checks now share one test path.

Reviews (1) · Last reviewed commit: "refactor(e2e): table-drive configapply e..." · Reviewed by Greptile

@skevetter
skevetter merged commit e34db14 into main Oct 22, 2026
115 checks passed
@skevetter
skevetter deleted the refactor/e2e-configapply-env-table branch October 22, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant