Skip to content

refactor(config): rename DEVSY_PRO_RUNNER to DEVSY_PLATFORM_RUNNER with fallback - #1649

Merged
skevetter merged 1 commit into
mainfrom
refactor/rename-platform-runner-env
Oct 22, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/rename-platform-runner-env

Conversation

@skevetter

@skevetter skevetter commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename runner env var DEVSY_PRO_RUNNER to DEVSY_PLATFORM_RUNNER (config.EnvPlatformRunner).
  • Keep DEVSY_PRO_RUNNER honoured via config.EnvPlatformRunnerLegacy, so existing runner pods keep working.
  • Comment-only "pro" to "platform" renames in six files.

Why

Platform rename (Loft/Pro to Platform). Runner pods set the old name; the new name must be honoured without breaking them.

Tier

T2 (behaviour change with fallback; small blast radius, pkg/config and pkg/telemetry call sites only).

Validation

  • mkdir -p dist && go build ./...
  • GOOS=windows go vet ./pkg/config/... ./pkg/telemetry/...
  • go test ./pkg/config/... ./pkg/telemetry/... (includes new table-driven TestIsPlatformRunner, 8 cases)
  • mise run cli:format
  • mise run cli:lint:ci (exit 0)
  • Re-ran go build ./... and go test after rebasing onto origin/main.

Precedence: non-empty DEVSY_PLATFORM_RUNNER wins (including false); empty or unset falls back to DEVSY_PRO_RUNNER.

CodeRabbit CLI

coderabbit review --agent --committed on the committed range: completed, 0 findings, 8 files reviewed (after one free-quota rate-limit wait).

Auto-merge

Eligible: yes. Non-test changed lines: 32 across 7 files (test file platform_test.go excluded, 42 lines).

Remaining

Pro PCRE \bpro\b|Pro(?=[A-Z0-9_]|\b)|(^|[^A-Za-z])pro(?=[A-Z])|DEVSY_PRO(_|$) on touched source paths: 10 before, 4 after. The remaining hits are intentional: provider id pro, the pro cobra alias, and the legacy env name fallback.

Summary by CodeRabbit

  • New Features
    • Platform runner detection now recognizes the DEVSY_PLATFORM_RUNNER environment variable and continues to support DEVSY_PRO_RUNNER for compatibility. When both are set, the platform variable takes precedence.

@skevetter skevetter added the rename Loft/Pro rename label Oct 22, 2026
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 2618d3f
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad9b5f4fcbe4deea2903894

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 709036bd-68e7-4866-8108-c36c5ac10db4
📥 Commits

Reviewing files that changed from the base of the PR and between a9edbc3 and 2618d3f.

📒 Files selected for processing: 8
  • cmd/pro/flags/flags.go
  • cmd/pro/workspace/import.go
  • pkg/config/env.go
  • pkg/config/platform.go
  • pkg/config/platform_test.go
  • pkg/flags/names/names.go
  • pkg/ide/opener/browser_tunnel.go
  • pkg/telemetry/collect.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The configuration now recognizes DEVSY_PLATFORM_RUNNER and falls back to DEVSY_PRO_RUNNER when the new variable is empty. Telemetry uses this compatibility check. Related comments now use platform terminology.

Changes: Platform runner naming and compatibility

Layer / File(s) Summary
Runner variable and compatibility check
pkg/config/env.go, pkg/config/platform.go, pkg/config/platform_test.go
The configuration defines DEVSY_PLATFORM_RUNNER and retains DEVSY_PRO_RUNNER as a legacy variable. IsPlatformRunner() checks the new variable first and uses the legacy variable when the new one is empty. Tests cover both variables, precedence, and fallback behavior.
Telemetry and platform terminology
pkg/telemetry/collect.go, cmd/pro/flags/flags.go, cmd/pro/workspace/import.go, pkg/flags/names/names.go, pkg/ide/opener/browser_tunnel.go
BootstrapCLI and RecordCLI use IsPlatformRunner(). Comments in these files now describe platform commands, providers, and mode.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

  • devsy-org/devsy#1551: The issue identifies the runner variable rename and legacy fallback as remaining work. This change implements both.
Merge Risk: ⚪ Minimal · up to 2618d

The runner rename retains the legacy fallback, with no identified issue requiring correction before merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: renaming DEVSY_PRO_RUNNER to DEVSY_PLATFORM_RUNNER while retaining fallback support. It is concise and specific.
Description check Passed The description explains the change, rationale, behavior precedence, validation commands, and remaining intentional legacy references. It does not follow the repository template headings and omits the…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, rationale, behavior precedence, validation commands, and remaining intentional legacy references. It does not follow the repository template headings and omits the required AI assistance disclosure, checklist confirmations, issue reference, and explicit integration-test rationale, but it provides sufficient implementation and testing context.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 2618d3f
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad9b5f47e70b06ed97fed04

@skevetter
skevetter marked this pull request as ready for review October 22, 2026 09:10
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit 372d182 into main Oct 22, 2026
204 of 207 checks passed
@skevetter
skevetter deleted the refactor/rename-platform-runner-env branch October 22, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant