You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(config): rename DEVSY_PRO_RUNNER to DEVSY_PLATFORM_RUNNER with fallback - #1649
Pro PCRE \bpro\b|Pro(?=[A-Z0-9_]|\b)|(^|[^A-Za-z])pro(?=[A-Z])|DEVSY_PRO(_|$) on touched source paths: 10 before, 4 after. The remaining hits are intentional: provider id pro, the pro cobra alias, and the legacy env name fallback.
Summary by CodeRabbit
New Features
Platform runner detection now recognizes the DEVSY_PLATFORM_RUNNER environment variable and continues to support DEVSY_PRO_RUNNER for compatibility. When both are set, the platform variable takes precedence.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 709036bd-68e7-4866-8108-c36c5ac10db4
📥 Commits
Reviewing files that changed from the base of the PR and between a9edbc3 and 2618d3f.
📒 Files selected for processing: 8
cmd/pro/flags/flags.go
cmd/pro/workspace/import.go
pkg/config/env.go
pkg/config/platform.go
pkg/config/platform_test.go
pkg/flags/names/names.go
pkg/ide/opener/browser_tunnel.go
pkg/telemetry/collect.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The configuration now recognizes DEVSY_PLATFORM_RUNNER and falls back to DEVSY_PRO_RUNNER when the new variable is empty. Telemetry uses this compatibility check. Related comments now use platform terminology.
Changes: Platform runner naming and compatibility
Layer / File(s)
Summary
Runner variable and compatibility check pkg/config/env.go, pkg/config/platform.go, pkg/config/platform_test.go
The configuration defines DEVSY_PLATFORM_RUNNER and retains DEVSY_PRO_RUNNER as a legacy variable. IsPlatformRunner() checks the new variable first and uses the legacy variable when the new one is empty. Tests cover both variables, precedence, and fallback behavior.
Telemetry and platform terminology pkg/telemetry/collect.go, cmd/pro/flags/flags.go, cmd/pro/workspace/import.go, pkg/flags/names/names.go, pkg/ide/opener/browser_tunnel.go
BootstrapCLI and RecordCLI use IsPlatformRunner(). Comments in these files now describe platform commands, providers, and mode.
devsy-org/devsy#1551: The issue identifies the runner variable rename and legacy fallback as remaining work. This change implements both.
Merge Risk:⚪ Minimal · up to 2618d
The runner rename retains the legacy fallback, with no identified issue requiring correction before merge.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 8 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly identifies the main change: renaming DEVSY_PRO_RUNNER to DEVSY_PLATFORM_RUNNER while retaining fallback support. It is concise and specific.
Description check
The description explains the change, rationale, behavior precedence, validation commands, and remaining intentional legacy references. It does not follow the repository template headings and omits the…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the change, rationale, behavior precedence, validation commands, and remaining intentional legacy references. It does not follow the repository template headings and omits the required AI assistance disclosure, checklist confirmations, issue reference, and explicit integration-test rationale, but it provides sufficient implementation and testing context.
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEVSY_PRO_RUNNERtoDEVSY_PLATFORM_RUNNER(config.EnvPlatformRunner).DEVSY_PRO_RUNNERhonoured viaconfig.EnvPlatformRunnerLegacy, so existing runner pods keep working.Why
Platform rename (Loft/Pro to Platform). Runner pods set the old name; the new name must be honoured without breaking them.
Tier
T2 (behaviour change with fallback; small blast radius,
pkg/configandpkg/telemetrycall sites only).Validation
mkdir -p dist && go build ./...GOOS=windows go vet ./pkg/config/... ./pkg/telemetry/...go test ./pkg/config/... ./pkg/telemetry/...(includes new table-drivenTestIsPlatformRunner, 8 cases)mise run cli:formatmise run cli:lint:ci(exit 0)go build ./...andgo testafter rebasing onto origin/main.Precedence: non-empty
DEVSY_PLATFORM_RUNNERwins (includingfalse); empty or unset falls back toDEVSY_PRO_RUNNER.CodeRabbit CLI
coderabbit review --agent --committedon the committed range: completed, 0 findings, 8 files reviewed (after one free-quota rate-limit wait).Auto-merge
Eligible: yes. Non-test changed lines: 32 across 7 files (test file
platform_test.goexcluded, 42 lines).Remaining
Pro PCRE
\bpro\b|Pro(?=[A-Z0-9_]|\b)|(^|[^A-Za-z])pro(?=[A-Z])|DEVSY_PRO(_|$)on touched source paths: 10 before, 4 after. The remaining hits are intentional: provider idpro, theprocobra alias, and the legacy env name fallback.Summary by CodeRabbit
DEVSY_PLATFORM_RUNNERenvironment variable and continues to supportDEVSY_PRO_RUNNERfor compatibility. When both are set, the platform variable takes precedence.