You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(ci): move Windows kind setup into devsy-ci-podman - #1597
Moves the Windows setup kind bash step in .github/workflows/pr-ci.yml into a Go subcommand, devsy-ci-podman install-kind (hack/podman_ci/kind.go). The workflow step is now a pwsh call with the same kind URL, SHA256, node image, and env (KIND_EXPERIMENTAL_PROVIDER=podman, DOCKER_HOST).
Why
Keeps YAML thin and moves logic under offline unit tests: download, SHA256 verification, GITHUB_PATH append, cluster name generation, and kind create cluster.
Behaviour changes:
Checksum is verified on cache hits too. Previously a corrupted cached kind.exe was used unchecked.
Cluster name is 32 lowercase hex chars from crypto/rand (same format as the old Python uuid4 hex).
Checksum helper generalised to verifyChecksum(artifact, ...). The MSI error text is unchanged.
The cache step's unused id is removed.
Validation
go test ./hack/podman_ci/... (darwin host): ok
GOOS=windows go vet ./hack/podman_ci/...: ok
GOOS=darwin go vet ./hack/podman_ci/...: ok
mise run cli:format: no changes
mise run cli:lint:ci: 0 issues
actionlint on pr-ci.yml: reports unexpected key "background" at line 957. The same error occurs on origin/main; this change does not touch it.
Not run: install-kind on a real Windows runner. The Windows CI jobs exercise it.
CodeRabbit CLI
coderabbit review --agent --committed failed with a recoverable WebSocket connection error before any review was produced. No findings.
Auto-merge
Not eligible: changes CI workflow and is an unattended draft.
Non-test changed lines: 153 (126 added, 27 deleted), under the 300 limit.
Jobs exercising the change: Windows pr-ci matrix jobs with install-kind: true.
Next
Check the Windows matrix jobs run install-kind successfully, then move out of draft for human review.
Summary by CodeRabbit
Chores
Updated Windows CI to handle Kubernetes test-cluster setup through the shared setup process, while retaining checksum verification and the configured container provider and image.
Tests
Added coverage for binary installation, checksum validation, cluster creation, and error handling.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a1ee73d9-5194-43e6-ac0a-b15ee89dd2d8
📥 Commits
Reviewing files that changed from the base of the PR and between 70f2d93 and 73872da.
📒 Files selected for processing: 5
.github/workflows/pr-ci.yml
hack/podman_ci/install.go
hack/podman_ci/kind.go
hack/podman_ci/kind_test.go
hack/podman_ci/setup.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
The Podman CI tool adds an install-kind command that downloads and verifies kind when needed, updates GITHUB_PATH, and creates a cluster. The Windows CI workflow now uses this command for kind setup.
Changes: Windows kind setup
Layer / File(s)
Summary
Add the install-kind command hack/podman_ci/kind.go, hack/podman_ci/setup.go, hack/podman_ci/install.go, hack/podman_ci/kind_test.go
The new command accepts kind and cluster settings, verifies the binary, updates GITHUB_PATH, generates a cluster name, and creates a cluster. The checksum helper now accepts an artifact name. Tests cover installation, checksum validation, cluster creation, and process errors.
Use the command in Windows CI .github/workflows/pr-ci.yml
The Windows workflow invokes install-kind with the pinned kind URL, checksum, cache path, and node image. It retains the Podman provider and Docker pipe environment.
sequenceDiagram
participant GitHubActions
participant devsy-ci-podman
participant kind.exe
GitHubActions->>devsy-ci-podman: Run install-kind with kind and image settings
devsy-ci-podman->>devsy-ci-podman: Download if missing, verify checksum, append kind directory to GITHUB_PATH
devsy-ci-podman->>devsy-ci-podman: Generate cluster name
devsy-ci-podman->>kind.exe: Run create cluster with name and image
kind.exe-->>devsy-ci-podman: Return process result
devsy-ci-podman-->>GitHubActions: Return command result
Loading
Merge Risk:⚪ Minimal · up to 73872
This moves Windows kind setup into a tested helper command. No concrete merge-blocking issue was found. The Windows CI matrix jobs will confirm the behavior on a real runner.
Security architecture risk:⚪ Minimal · up to 73872
The refactor preserves the existing download and image pins, Podman connection, and execution authority. It improves integrity checking by verifying cached binaries before use. No material security risk introduced or worsened by this change was identified.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The demonstrated execution scope remains the Windows CI runner and the Podman engine reached through the existing named pipe. The new command inherits the caller's authority; the inspected change does not establish a new service, tenant boundary, credential grant, or production deployment path.
Trust Boundaries and Controls
observed — Downloaded and cached executable bytes must match the workflow-supplied digest before PATH publication or cluster execution. A mismatching artifact therefore cannot reach the execution sink through the normal flow. The process launches the verified pathname directly instead of resolving kind through PATH.
Resilience and Maintainability Implications
inferred — Artifact verification is not atomic with execution: downloads write directly to the destination, and another writer could change the pathname after verification. The base shell flow likewise downloaded, checked, and executed a mutable path. No new concurrent execution contract or attacker authority was established, so this is not retained as a PR-introduced concern.
Pre-merge checks: 3 · 2
Failed checks: 2 warnings
Check name
Status
Explanation
Resolution
Description check
The description explains the change, motivation, behavior changes, and validation results. However, it does not follow the required template and omits or leaves incomplete the issue reference, change-…
Update the description to use the repository template. Add a completed What and why section with an issue reference or "none"; select the applicable Type of change entries; complete the AI assistance section and attestations; select the app…
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 4 files. (1 skipped: 1…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title is concise, uses Conventional Commits format, and accurately describes the main change: moving Windows kind setup into devsy-ci-podman.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the change, motivation, behavior changes, and validation results. However, it does not follow the required template and omits or leaves incomplete the issue reference, change-type selection, AI assistance disclosure, checklist confirmations, and explicit testing selections.
Resolution
Update the description to use the repository template. Add a completed What and why section with an issue reference or "none"; select the applicable Type of change entries; complete the AI assistance section and attestations; select the applicable Testing entries and document the integration-test rationale; complete the Checklist; and retain the manual validation results and reviewer notes as applicable.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 zizmor (1.30.1)
.github/workflows/pr-ci.yml
INFO zizmor: 🌈 zizmor v1.30.1
WARN audit:audit{input=Workflow(file://.github/workflows/pr-ci.yml)}: zizmor::audit::unsound_ternary: couldn't parse expression: matrix.provider-mode || ''parity''
fatal: no audit was performed
'template-injection' audit failed on file://.github/workflows/pr-ci.yml
Caused by:
0: error in 'template-injection' audit
1: failed to locate subfeature 'Subfeature { after: 143, fragment: Regex(Regex("matrix\.provider\-mode\s+\|\|\s+'parity'")) }' in feature ''"${RUNNER_TEMP}/devsy-ci-microsandbox" run --label "${{ matrix.label }}" --expected-count "${{ matrix.expected-spec-count }}" --provider-mode "${{ matrix.provider-mode || ''parity'' }}"''
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Windows
setup kindbash step in.github/workflows/pr-ci.ymlinto a Go subcommand,devsy-ci-podman install-kind(hack/podman_ci/kind.go). The workflow step is now a pwsh call with the same kind URL, SHA256, node image, and env (KIND_EXPERIMENTAL_PROVIDER=podman,DOCKER_HOST).Why
Keeps YAML thin and moves logic under offline unit tests: download, SHA256 verification, GITHUB_PATH append, cluster name generation, and
kind create cluster.Behaviour changes:
kind.exewas used unchecked.verifyChecksum(artifact, ...). The MSI error text is unchanged.idis removed.Validation
go test ./hack/podman_ci/...(darwin host): okGOOS=windows go vet ./hack/podman_ci/...: okGOOS=darwin go vet ./hack/podman_ci/...: okmise run cli:format: no changesmise run cli:lint:ci: 0 issuespr-ci.yml: reportsunexpected key "background"at line 957. The same error occurs on origin/main; this change does not touch it.install-kindon a real Windows runner. The Windows CI jobs exercise it.CodeRabbit CLI
coderabbit review --agent --committedfailed with a recoverable WebSocket connection error before any review was produced. No findings.Auto-merge
Not eligible: changes CI workflow and is an unattended draft.
Non-test changed lines: 153 (126 added, 27 deleted), under the 300 limit.
Jobs exercising the change: Windows
pr-cimatrix jobs withinstall-kind: true.Next
Check the Windows matrix jobs run
install-kindsuccessfully, then move out of draft for human review.Summary by CodeRabbit