You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add expectSingleAppContainer in helper.go and use it at nine call sites in config.go that repeated the same findComposeContainer + HaveLen(1) block for the app service.
Turn the root folder, sub-folder and overrides It blocks into one DescribeTable with SpecTimeout on each entry.
Why
The same container lookup and assertion was copy-pasted across the up-docker-compose specs. One helper keeps the assertion messages in one place.
Validation
mise run cli:format, mise run cli:lint:ci: 0 issues
go vet ./e2e/...: clean
go test ./e2e/framework/...: pass
go tool ginkgo --dry-run --label-filter=up-docker-compose .: 56 of 503 selected, same set as before except the three testdata specs now sit under "starts workspace from testdata"
mise run cli:test:e2e:suite up-docker-compose: 49 passed, 7 failed
Same focused run on origin/main and on this branch: identical 2 passed / 5 failed. Failing on both: root folder, sub-folder, overrides, user lookup with no remoteUser, multistage build (local Docker/macOS environment)
CodeRabbit CLI
coderabbit review --agent --committed failed twice with "WebSocket closed" before producing a review.
Auto-merge
Eligible by size: yes. Non-test changed lines: 142 (44 added, 98 removed), 2 files. Not merged.
Next
Run the up-docker-compose e2e rows in CI. Those are the CI jobs that exercise these specs.
Summary by CodeRabbit
Tests
Automated checks for Docker Compose workspace startup now cover root-folder, subfolder, and override configurations with consistent setup and mount verification.
Related scenarios now consistently verify that exactly one app container is present and report container lookup failures. These updates make the automated checks more uniform across the tested workspace configurations.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: d3180bad-a054-4c43-bea8-51448f950b81
📥 Commits
Reviewing files that changed from the base of the PR and between 91c3655 and a982b63.
📒 Files selected for processing: 2
e2e/tests/up-docker-compose/config.go
e2e/tests/up-docker-compose/helper.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The Docker Compose E2E tests now share an app-container lookup and assertion helper. Three workspace-start tests are consolidated into a table-driven test.
Changes: Docker Compose E2E Tests
Layer / File(s)
Summary
Shared app-container lookup and assertion e2e/tests/up-docker-compose/helper.go, e2e/tests/up-docker-compose/config.go
A helper locates app container IDs, fails on lookup errors, asserts exactly one container, and returns the IDs. Eight tests use it.
Workspace-start test cases e2e/tests/up-docker-compose/config.go
The root-folder, sub-folder, and overrides cases use one table-driven test. Each case retains workspace setup, mount verification, and the long timeout.
The change reorganizes Compose E2E tests without an established behavior regression. The reported local failures also occurred on the baseline; focused CI confirmation remains ordinary validation, not an identified merge blocker.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main refactor: deduplicating Compose container lookups in end-to-end tests.
Description check
The description explains what changed, why it changed, and how it was validated. It also reports the focused test failures and their comparison with origin/main. It does not use the template headings …
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains what changed, why it changed, and how it was validated. It also reports the focused test failures and their comparison with origin/main. It does not use the template headings or include the type-of-change and AI-assistance checklist details, but the core information is complete.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectSingleAppContainerinhelper.goand use it at nine call sites inconfig.gothat repeated the samefindComposeContainer+HaveLen(1)block for theappservice.Itblocks into oneDescribeTablewithSpecTimeouton each entry.Why
The same container lookup and assertion was copy-pasted across the up-docker-compose specs. One helper keeps the assertion messages in one place.
Validation
mise run cli:format,mise run cli:lint:ci: 0 issuesgo vet ./e2e/...: cleango test ./e2e/framework/...: passgo tool ginkgo --dry-run --label-filter=up-docker-compose .: 56 of 503 selected, same set as before except the three testdata specs now sit under "starts workspace from testdata"mise run cli:test:e2e:suite up-docker-compose: 49 passed, 7 failedCodeRabbit CLI
coderabbit review --agent --committedfailed twice with "WebSocket closed" before producing a review.Auto-merge
Eligible by size: yes. Non-test changed lines: 142 (44 added, 98 removed), 2 files. Not merged.
Next
Run the up-docker-compose e2e rows in CI. Those are the CI jobs that exercise these specs.
Summary by CodeRabbit