You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add framework.CopyTestdataNoChdir(testdataPath string) string. It copies via CopyToTempDirWithoutChdir, asserts no error, and registers an os.RemoveAll cleanup. It does not chdir.
Replace the identical copy/error/RemoveAll block at 21 call sites: extends (11) and configread (10).
Why
Removes 21 duplicated blocks. Spec count and names are unchanged (503 in the ./e2e suite).
Not migrated: tunnel (2), logs (1), machineprovider (3). They use ginkgo.DeferCleanup(framework.CleanupTempDir, ...), which chdirs to initialDir before removal. That cleanup differs, so these callers stay unchanged.
Validation
gofmt -l e2e/ clean. go build ./e2e/... and go vet ./e2e/... pass. go test ./e2e/framework/... passes.
golangci-lint run ./e2e/...: 54 issues, the same count as origin/main. None are new.
Ginkgo dry-run: 503 specs before and after, names identical.
Local run, --label-filter "extends || config-read" with dev build: 32/32 passed.
CodeRabbit CLI
Failed twice with Connection failed: WebSocket closed (recoverable). No findings were returned.
Auto-merge
Eligible: yes, pending CI. Changed files: 3.
Non-test changed lines: 10 source (helper) + 124 spec lines. Spec lines are half-weighted (about 62), so the weighted total is about 72.
CI jobs expected to exercise the changed paths: extends and config-read. Tunnel, logs, and machineprovider callers are untouched.
Next
Review CI results. No merge performed.
Summary by CodeRabbit
Tests
Updated end-to-end tests for configuration reading and inheritance scenarios. Fixture setup is now handled consistently across these cases, while existing commands, assertions, error expectations, and environment-variable scenarios remain unchanged. OCI-based tests are unaffected, and this update does not change application behavior.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: c5a515fa-dc51-4237-8b8d-a83d8f9bcb4e
📥 Commits
Reviewing files that changed from the base of the PR and between 2b30bfa and c7855d3.
📒 Files selected for processing: 3
e2e/framework/workspace.go
e2e/tests/configread/configread.go
e2e/tests/extends/extends.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
A shared helper now copies test fixtures to temporary directories without changing the working directory and registers cleanup. Config-read and extends E2E tests use the helper instead of repeating fixture-copy error handling and cleanup.
Adds CopyTestdataNoChdir to copy test data without changing directories, report copy errors, register temporary-directory cleanup, and return the path.
E2E test fixture setup e2e/tests/configread/configread.go, e2e/tests/extends/extends.go
Uses the shared helper in config-read and extends tests. Existing assertions and error expectations remain; environment-variable setup and cleanup in the extends tests remain.
The fixture setup is centralized without a concrete regression identified in the supplied review context. The change is mergeable subject to normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description explains the change, rationale, affected call sites, validation results, and known limitations. It does not follow the required template because it omits the Type of change, AI assista…
Update the description to include the required template sections. Mark Refactor (no behavior change), document AI tool usage or select no AI tools, complete the required acknowledgment checkboxes, identify the applicable testing option, and…
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary refactor: adding the CopyTestdataNoChdir helper.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the change, rationale, affected call sites, validation results, and known limitations. It does not follow the required template because it omits the Type of change, AI assistance, Checklist, and Notes for reviewers sections, and it does not state an issue reference such as "Fixes none" or "Refs none".
Resolution
Update the description to include the required template sections. Mark Refactor (no behavior change), document AI tool usage or select no AI tools, complete the required acknowledgment checkboxes, identify the applicable testing option, and complete the Checklist. State "Fixes none" or provide the relevant issue reference.
Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
framework.CopyTestdataNoChdir(testdataPath string) string. It copies viaCopyToTempDirWithoutChdir, asserts no error, and registers anos.RemoveAllcleanup. It does not chdir.Why
./e2esuite).ginkgo.DeferCleanup(framework.CleanupTempDir, ...), which chdirs toinitialDirbefore removal. That cleanup differs, so these callers stay unchanged.Validation
gofmt -l e2e/clean.go build ./e2e/...andgo vet ./e2e/...pass.go test ./e2e/framework/...passes.golangci-lint run ./e2e/...: 54 issues, the same count as origin/main. None are new.--label-filter "extends || config-read"with dev build: 32/32 passed.CodeRabbit CLI
Connection failed: WebSocket closed(recoverable). No findings were returned.Auto-merge
Next
Summary by CodeRabbit