Skip to content

test(platform): cover parameter value validation and deep lookup - #1572

Merged
skevetter merged 1 commit into
mainfrom
test/maintenance-coverage-20261019
Oct 19, 2026
Merged

skevetter merged 1 commit into
mainfrom
test/maintenance-coverage-20261019

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Adds pkg/platform/parameters/parameters_test.go (new file only, 296 lines) covering:

  • VerifyValue type dispatch and unknown-type rejection
  • String, boolean, and number verification: defaults, required, validation/invalidation regexes, options allowlist, numeric min/max boundaries
  • GetDeepValue path lookup: nested maps, slice indexes, out-of-range/negative/non-numeric indexes, scalar and unsupported roots

Why

pkg/platform/parameters had no tests. It holds the validation and precedence logic for app parameters, which is consumer-visible through error messages and defaults.

Validation

  • go test -race -count=3 ./pkg/platform/parameters/: ok
  • go test -count=1 ./pkg/platform/parameters/: ok
  • golangci-lint fmt ./pkg/platform/parameters/... then golangci-lint run ./pkg/platform/parameters/...: 0 issues
  • Break-it check: changed checkNumberBounds min comparison from < to <=. Red on TestVerifyNumberValue/minimum_boundary_is_accepted. Reverted; green again. Product code unchanged in this PR.

CodeRabbit CLI

coderabbit review --agent --committed --base-commit <merge-base>: completed, 0 findings, 1 file reviewed.

Auto-merge

Eligible: test-only, one new file, 296 added lines, zero non-test lines changed.

@skevetter skevetter added the test-coverage Unit test coverage (maintenance bot) label Oct 19, 2026
@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 042a0c3
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad59014f3e16fc4877c6c5e

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 042a0c3
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad59014aa8ae0f618e5581c

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 964c7aeb-522a-4031-8938-c2b88f79b167
📥 Commits

Reviewing files that changed from the base of the PR and between 1f47cd1 and 042a0c3.

📒 Files selected for processing: 1
  • pkg/platform/parameters/parameters_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter force-pushed the test/maintenance-coverage-20261019 branch from a68a662 to 042a0c3 Compare October 19, 2026 03:35
@skevetter
skevetter marked this pull request as ready for review October 19, 2026 04:12
@mergify

mergify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 2b30bfa into main Oct 19, 2026
111 checks passed
@skevetter
skevetter deleted the test/maintenance-coverage-20261019 branch October 19, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/l test-coverage Unit test coverage (maintenance bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant