Repository navigation
test(platform): cover parameter value validation and deep lookup - #1572
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skevetter
force-pushed
the
test/maintenance-coverage-20261019
branch
from
October 19, 2026 03:35
a68a662 to
042a0c3
Compare
skevetter
marked this pull request as ready for review
October 19, 2026 04:12
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pkg/platform/parameters/parameters_test.go(new file only, 296 lines) covering:VerifyValuetype dispatch and unknown-type rejectionGetDeepValuepath lookup: nested maps, slice indexes, out-of-range/negative/non-numeric indexes, scalar and unsupported rootsWhy
pkg/platform/parametershad no tests. It holds the validation and precedence logic for app parameters, which is consumer-visible through error messages and defaults.Validation
go test -race -count=3 ./pkg/platform/parameters/: okgo test -count=1 ./pkg/platform/parameters/: okgolangci-lint fmt ./pkg/platform/parameters/...thengolangci-lint run ./pkg/platform/parameters/...: 0 issuescheckNumberBoundsmin comparison from<to<=. Red onTestVerifyNumberValue/minimum_boundary_is_accepted. Reverted; green again. Product code unchanged in this PR.CodeRabbit CLI
coderabbit review --agent --committed --base-commit <merge-base>: completed, 0 findings, 1 file reviewed.Auto-merge
Eligible: test-only, one new file, 296 added lines, zero non-test lines changed.