Skip to content

refactor(platform): rename pro to platform in workspace instance types - #1571

Merged
skevetter merged 1 commit into
mainfrom
refactor/rename-pro-to-platform-workspace-instance
Oct 19, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/rename-pro-to-platform-workspace-instance

Conversation

@skevetter

@skevetter skevetter commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename ProWorkspaceInstance / ProWorkspaceInstanceStatus to WorkspaceInstance / WorkspaceInstanceStatus in pkg/daemon/platform and cmd/pro/provider/watch.
  • Rename unexported methods buildProInstance / importedProInstance to buildInstance / importedInstance (same package scope, found via the same grep).
  • Rename locals proInstance to instance, or platformInstance in Add where the parameter instance would be shadowed.
  • Token-only: JSON tags, serialized fields, and string values unchanged.

Why

Platform is the new product name; the Pro type and method names are leftover internal identifiers. Target names were free in both packages (git grep -nw), and none of the renamed types is referenced outside these two packages.

Tier

T1: internal identifiers, all callers in this repo.

Validation

  • go build ./...
  • go vet ./pkg/daemon/... ./cmd/pro/...
  • GOOS=windows go vet ./pkg/daemon/... ./cmd/pro/...
  • mkdir -p dist && mise run cli:format
  • mise run cli:lint:ci (0 issues)
  • go test ./pkg/daemon/... ./cmd/pro/... (pass)
  • Pro token count on pkg/daemon + cmd/pro/provider/watch: 44 -> 6.

CodeRabbit CLI

Failed: Rate limit exceeded (free OSS review quota, reset in about 19 minutes). Not retried. The GitHub CodeRabbit review still gates.

Auto-merge

Eligible: yes. Non-test changed lines: 80 (40 added, 40 removed) across 3 files.

Remaining

Pro token hits left in these paths (6):

  • workspace.Pro field, 2 uses in cmd/pro/provider/watch/workspaces.go (external API field, T3).
  • cmd/pro/flags and cmd/pro/... import paths (cmd/pro dir move, not in slice).
  • Devsy Pro Provider watch commands in cmd/pro/provider/watch/watch.go (outside the listed files).
  • devsy pro daemon start CLI string in pkg/daemon/platform/error.go (T2, kept).

Summary by CodeRabbit

  • Refactor
    • Workspace monitoring now uses consistent workspace instance terminology across status reporting and local server updates. Existing workspace construction, imported-workspace resolution, and throttling behavior remain unchanged.
    • No changes to end-user workspace behavior are included in this update.

@skevetter skevetter added the rename Loft/Pro rename label Oct 19, 2026
@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit be8a431
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad58650cd60c4cf2a224383

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6c8a4761-110b-457a-9920-c0da8329427c
📥 Commits

Reviewing files that changed from the base of the PR and between d8056af and be8a431.

📒 Files selected for processing: 3
  • cmd/pro/provider/watch/workspaces.go
  • pkg/daemon/platform/local_server.go
  • pkg/daemon/platform/workspace_watcher.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The provider watch and daemon watcher replace the ProWorkspaceInstance types with WorkspaceInstance types. Related stores, conversions, callbacks, throttling, JSON output, and latency-ping signatures use the renamed types.

Changes: Workspace instance type rename

Layer / File(s) Summary
Provider watch types and conversions
cmd/pro/provider/watch/workspaces.go
The provider watch store, list results, conversion helpers, imported-workspace handling, and JSON printer now use WorkspaceInstance and WorkspaceInstanceStatus.
Daemon watcher types and callbacks
pkg/daemon/platform/workspace_watcher.go, pkg/daemon/platform/local_server.go
The daemon watcher’s store, list and conversion methods, change callback, latency-ping flow, and throttling callback now use WorkspaceInstance types. Throttling behavior is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: fabiankramm

Merge Risk: ⚪ Minimal · up to be8a4

The watcher type rename preserves the summarized data and behavior, and no supported repository caller depends on the removed names. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description explains the refactor, rationale, scope, remaining references, and validation results. However, it does not follow the repository template and omits the required Type of change, AI ass… Update the description to use the required template. Mark the refactor type, disclose AI assistance and required acknowledgments, document testing and manual verification, and complete the checklist. State the issue reference as none or p…
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main refactor: renaming Pro workspace instance types to platform workspace instance types.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the refactor, rationale, scope, remaining references, and validation results. However, it does not follow the repository template and omits the required Type of change, AI assistance, Testing, and Checklist sections, including the required test and checklist confirmations.

Resolution

Update the description to use the required template. Mark the refactor type, disclose AI assistance and required acknowledgments, document testing and manual verification, and complete the checklist. State the issue reference as none or provide Fixes #N/Refs #N. Keep the existing rationale and validation details.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit be8a431
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad586507c0359b55add6e95

@skevetter
skevetter marked this pull request as ready for review October 19, 2026 05:42
@mergify

mergify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 30ba4a9 into main Oct 19, 2026
199 of 201 checks passed
@skevetter
skevetter deleted the refactor/rename-pro-to-platform-workspace-instance branch October 19, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant