You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(platform): rename pro to platform in workspace instance types - #1571
Rename ProWorkspaceInstance / ProWorkspaceInstanceStatus to WorkspaceInstance / WorkspaceInstanceStatus in pkg/daemon/platform and cmd/pro/provider/watch.
Rename unexported methods buildProInstance / importedProInstance to buildInstance / importedInstance (same package scope, found via the same grep).
Rename locals proInstance to instance, or platformInstance in Add where the parameter instance would be shadowed.
Token-only: JSON tags, serialized fields, and string values unchanged.
Why
Platform is the new product name; the Pro type and method names are leftover internal identifiers. Target names were free in both packages (git grep -nw), and none of the renamed types is referenced outside these two packages.
Tier
T1: internal identifiers, all callers in this repo.
Validation
go build ./...
go vet ./pkg/daemon/... ./cmd/pro/...
GOOS=windows go vet ./pkg/daemon/... ./cmd/pro/...
mkdir -p dist && mise run cli:format
mise run cli:lint:ci (0 issues)
go test ./pkg/daemon/... ./cmd/pro/... (pass)
Pro token count on pkg/daemon + cmd/pro/provider/watch: 44 -> 6.
CodeRabbit CLI
Failed: Rate limit exceeded (free OSS review quota, reset in about 19 minutes). Not retried. The GitHub CodeRabbit review still gates.
workspace.Pro field, 2 uses in cmd/pro/provider/watch/workspaces.go (external API field, T3).
cmd/pro/flags and cmd/pro/... import paths (cmd/pro dir move, not in slice).
Devsy Pro Provider watch commands in cmd/pro/provider/watch/watch.go (outside the listed files).
devsy pro daemon start CLI string in pkg/daemon/platform/error.go (T2, kept).
Summary by CodeRabbit
Refactor
Workspace monitoring now uses consistent workspace instance terminology across status reporting and local server updates. Existing workspace construction, imported-workspace resolution, and throttling behavior remain unchanged.
No changes to end-user workspace behavior are included in this update.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 6c8a4761-110b-457a-9920-c0da8329427c
📥 Commits
Reviewing files that changed from the base of the PR and between d8056af and be8a431.
📒 Files selected for processing: 3
cmd/pro/provider/watch/workspaces.go
pkg/daemon/platform/local_server.go
pkg/daemon/platform/workspace_watcher.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The provider watch and daemon watcher replace the ProWorkspaceInstance types with WorkspaceInstance types. Related stores, conversions, callbacks, throttling, JSON output, and latency-ping signatures use the renamed types.
Changes: Workspace instance type rename
Layer / File(s)
Summary
Provider watch types and conversions cmd/pro/provider/watch/workspaces.go
The provider watch store, list results, conversion helpers, imported-workspace handling, and JSON printer now use WorkspaceInstance and WorkspaceInstanceStatus.
Daemon watcher types and callbacks pkg/daemon/platform/workspace_watcher.go, pkg/daemon/platform/local_server.go
The daemon watcher’s store, list and conversion methods, change callback, latency-ping flow, and throttling callback now use WorkspaceInstance types. Throttling behavior is unchanged.
The watcher type rename preserves the summarized data and behavior, and no supported repository caller depends on the removed names. No actionable merge-blocking risk remains.
Pre-merge checks: 3 · 2
Failed checks: 2 warnings
Check name
Status
Explanation
Resolution
Description check
The description explains the refactor, rationale, scope, remaining references, and validation results. However, it does not follow the repository template and omits the required Type of change, AI ass…
Update the description to use the required template. Mark the refactor type, disclose AI assistance and required acknowledgments, document testing and manual verification, and complete the checklist. State the issue reference as none or p…
Docstring Coverage
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main refactor: renaming Pro workspace instance types to platform workspace instance types.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the refactor, rationale, scope, remaining references, and validation results. However, it does not follow the repository template and omits the required Type of change, AI assistance, Testing, and Checklist sections, including the required test and checklist confirmations.
Resolution
Update the description to use the required template. Mark the refactor type, disclose AI assistance and required acknowledgments, document testing and manual verification, and complete the checklist. State the issue reference as none or provide Fixes #N/Refs #N. Keep the existing rationale and validation details.
Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProWorkspaceInstance/ProWorkspaceInstanceStatustoWorkspaceInstance/WorkspaceInstanceStatusinpkg/daemon/platformandcmd/pro/provider/watch.buildProInstance/importedProInstancetobuildInstance/importedInstance(same package scope, found via the same grep).proInstancetoinstance, orplatformInstanceinAddwhere the parameterinstancewould be shadowed.Why
Platform is the new product name; the Pro type and method names are leftover internal identifiers. Target names were free in both packages (
git grep -nw), and none of the renamed types is referenced outside these two packages.Tier
T1: internal identifiers, all callers in this repo.
Validation
go build ./...go vet ./pkg/daemon/... ./cmd/pro/...GOOS=windows go vet ./pkg/daemon/... ./cmd/pro/...mkdir -p dist && mise run cli:formatmise run cli:lint:ci(0 issues)go test ./pkg/daemon/... ./cmd/pro/...(pass)pkg/daemon+cmd/pro/provider/watch: 44 -> 6.CodeRabbit CLI
Failed:
Rate limit exceeded(free OSS review quota, reset in about 19 minutes). Not retried. The GitHub CodeRabbit review still gates.Auto-merge
Eligible: yes. Non-test changed lines: 80 (40 added, 40 removed) across 3 files.
Remaining
Pro token hits left in these paths (6):
workspace.Profield, 2 uses incmd/pro/provider/watch/workspaces.go(external API field, T3).cmd/pro/flagsandcmd/pro/...import paths (cmd/prodir move, not in slice).Devsy Pro Provider watch commandsincmd/pro/provider/watch/watch.go(outside the listed files).devsy pro daemon startCLI string inpkg/daemon/platform/error.go(T2, kept).Summary by CodeRabbit