Repository navigation
refactor(feature): share feature discovery - #1570
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@coderabbitai review |
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
@coderabbitai review |
|
|
Auto-merge paused: all CI checks are green and the local CodeRabbit CLI found 0 issues, but the required GitHub CodeRabbit review is terminally rate limited rather than |
|
Tip For best results, initiate chat on the files or code changes. @skevetter Understood. The clean local CLI review does not satisfy the required GitHub CodeRabbit review. That review remains incomplete, and the PR remains unmerged pending human review. You are interacting with an AI system. |
Summary
Share the feature-discovery loop across
cmd/featuregenerate-docs, package, and test. NewdiscoverLocalFeaturesincmd/feature/discover.goreplacesscanFeatures,PackageCmd.discoverFeatures, andTestCmd.discoverFeatures. OnelocalFeaturetype replacesfeatureDoc,featureSource, andfeatureEntry.Why
Three copies of the same ReadDir, parse, skip, and empty-check loop. Behaviour is unchanged:
read src/ directory(docs, test) andread target directory(package).packagestill warns on skipped features.docsandteststill skip silently.Validation
mise run cli:format: no changes.mise run cli:lint:ci: 0 issues (run before the rebase).golangci-lint run --new-from-rev=origin/main ./cmd/...: 0 issues.go test ./cmd/feature/...: ok (after the rebase).go build ./...: ok (after the rebase).origin/mainbuild, on a fixture with one valid and one broken feature:feature docs(success and missing dir),feature package(skip warning, success, missing dir). Exit codes, stdout, and stderr match, apart from the timestamp and output path. Generated docs and the.tgzentries match.writeDocs) is not exercised by the smoke run. It is covered by the existinggeneratedocs_test.go.CodeRabbit CLI
Completed: 0 findings, 6 files reviewed, against merge-base
7d34768dd.Auto-merge
//nolint, no lint disabled, no tests removed or weakened.Next
Output-mode emit helper and
parseFeatureRefduplication incmd/feature/info*.go. Excluded from this PR.