Skip to content

refactor(cli): rename loft to devsy in pro commands and env vars - #1568

Merged
skevetter merged 1 commit into
mainfrom
refactor/rename-loft-to-devsy-cmd-pro
Oct 19, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/rename-loft-to-devsy-cmd-pro

Conversation

@skevetter

@skevetter skevetter commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Renames loft to devsy in cmd/pro, pkg/config, pkg/provider, and pkg/workspace:

  • Go identifiers, aliases, and comments
  • User-facing log and error text
  • Env var constants: EnvLoftProject → EnvProject (DEVSY_PROJECT), EnvLoftFilterByOwner → EnvFilterByOwner (DEVSY_FILTER_BY_OWNER)
  • cmd/pro/workspace/watch.go: literal "true" replaced with config.BoolTrue (same value; fixes goconst)

10 files, 71 insertions, 71 deletions.

Contract strings kept (not renamed)

These are cluster resource names, on-disk paths, or default values that existing installs depend on:

  • loft-router-domain (value of DevsyRouterDomainSecret)
  • loft-ingress, loft-user-secret-admin, loft-agent, loft-agent-controller, loft-applied-defaults
  • loft-data:/var/lib/loft, /var/lib/loft/loft-domain.txt
  • default namespace loft, default deployment name loft
  • loft.my-domain.tld example hostname, loft.host flag help text
  • product: "loft" in start_test.go

Left alone (ambiguous, reviewer decision)

  • cmd/pro/start.go:1359 comment "delete the loft namespace" (refers to the literal default namespace)
  • cmd/pro/start.go:1407 error "couldn't find any host in loft ingress" (names the loft-ingress resource)
  • cmd/pro/start_docker.go:298 comment "mount the loft lib" (the mount is /var/lib/loft)
  • cmd/pro/start_flags.go:128 help text "create a loft.host tunnel" (hostname form)

Validation

  • go build ./...: pass
  • GOOS=windows go vet on changed packages: pass
  • go vet on changed packages: pass
  • mise run cli:format: no changes
  • mise run cli:lint:ci: 0 issues (after goconst fix)
  • go test ./cmd/pro/... ./pkg/config/... ./pkg/provider/... ./pkg/workspace/...: pass
  • Grep for old identifiers (EnvLoft, loftClient, LoftRouter, findLoft, waitForLoft, addLoftProvider, pingLoft, etc.): no matches

CodeRabbit

Not run. The CLI failed twice with Connection failed: WebSocket closed (committed review, --base origin/main, both plain and --agent).

Contract-string diff is limited to the constant name for DevsyRouterDomainSecret; its value is unchanged.

Summary by CodeRabbit

  • Updates
    • Remote Devsy Pro versions below 0.7.0 now install the Devsy proxy provider, except development versions.
    • Startup, login, Docker, and workspace messages and settings now use Devsy terminology.
    • Workspace project and owner-filter settings continue to use the existing environment variable values.

Rename Go identifiers, comments, and user-facing log/error text in
cmd/pro, pkg/config, pkg/provider, and pkg/workspace from loft to devsy.

Env var constants change to DEVSY_PROJECT and DEVSY_FILTER_BY_OWNER.
Cluster resource names, on-disk paths, and default namespace are kept
unchanged.
@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit d2dea78
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad56ef536bce579f3803f25

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 31978183-6599-444d-bcc4-06b568e099e7
📥 Commits

Reviewing files that changed from the base of the PR and between 0dadc01 and d2dea78.

📒 Files selected for processing: 10
  • cmd/pro/login.go
  • cmd/pro/provider/list/workspaces.go
  • cmd/pro/provider/watch/workspaces.go
  • cmd/pro/start.go
  • cmd/pro/start_docker.go
  • cmd/pro/start_uninstall.go
  • cmd/pro/workspace/watch.go
  • pkg/config/env.go
  • pkg/provider/env.go
  • pkg/workspace/list.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The changes rename Loft-branded Pro login and startup identifiers, messages, and client usage to Devsy; update workspace project and owner-filter option constants while retaining their environment variable values; and select the Devsy proxy provider for applicable older remote versions.

Changes: Devsy Pro updates

Layer / File(s) Summary
Workspace project and owner-filter options
pkg/config/env.go, pkg/provider/env.go, pkg/workspace/list.go, cmd/pro/provider/.../workspaces.go, cmd/pro/workspace/watch.go
Workspace project and owner-filter options use EnvProject and EnvFilterByOwner. Their environment variable values remain unchanged.
Devsy proxy provider login
cmd/pro/login.go
Applicable older remote versions now use addDevsyProvider. The skipped-browser-login failure message identifies Devsy.
Kubernetes startup and router readiness
cmd/pro/start.go
The router secret constant, startup and router helpers, client references, and related messages use Devsy naming. Readiness and password flows remain otherwise unchanged.
Docker startup and discovery
cmd/pro/start_docker.go
Docker startup, readiness, router, and container-discovery helpers and related messages use Devsy naming. The router lookup still reads /var/lib/loft/loft-domain.txt.
Uninstall resource cleanup
cmd/pro/start_uninstall.go
Uninstall deletes DevsyRouterDomainSecret and uses the Devsy client to fetch, clear finalizers from, and delete the user.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to d2dea

The workspace option behavior and legacy provider installation contract are preserved. No concrete merge-blocking regression remains in the reviewed changes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 10 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: renaming Loft references to Devsy in Pro commands and environment variables.
Description check Passed The description clearly explains the scope, preserved contract strings, ambiguous references, validation results, and review status. It does not follow every template heading, but it provides the requ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the scope, preserved contract strings, ambiguous references, validation results, and review status. It does not follow every template heading, but it provides the required change rationale and testing information in equivalent sections.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit d2dea78
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad56ef50c3aeb7228ff264b

@skevetter skevetter added the rename Loft/Pro rename label Oct 19, 2026
@skevetter
skevetter marked this pull request as ready for review October 19, 2026 02:23
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@mergify

mergify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit d8056af into main Oct 19, 2026
111 checks passed
@skevetter
skevetter deleted the refactor/rename-loft-to-devsy-cmd-pro branch October 19, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant