Repository navigation
refactor(cli): rename loft to devsy in pro commands and env vars - #1568
Conversation
Rename Go identifiers, comments, and user-facing log/error text in cmd/pro, pkg/config, pkg/provider, and pkg/workspace from loft to devsy. Env var constants change to DEVSY_PROJECT and DEVSY_FILTER_BY_OWNER. Cluster resource names, on-disk paths, and default namespace are kept unchanged.
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@coderabbitai review |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Renames
lofttodevsyincmd/pro,pkg/config,pkg/provider, andpkg/workspace:EnvLoftProject→EnvProject(DEVSY_PROJECT),EnvLoftFilterByOwner→EnvFilterByOwner(DEVSY_FILTER_BY_OWNER)cmd/pro/workspace/watch.go: literal"true"replaced withconfig.BoolTrue(same value; fixes goconst)10 files, 71 insertions, 71 deletions.
Contract strings kept (not renamed)
These are cluster resource names, on-disk paths, or default values that existing installs depend on:
loft-router-domain(value ofDevsyRouterDomainSecret)loft-ingress,loft-user-secret-admin,loft-agent,loft-agent-controller,loft-applied-defaultsloft-data:/var/lib/loft,/var/lib/loft/loft-domain.txtloft, default deployment nameloftloft.my-domain.tldexample hostname,loft.hostflag help textproduct: "loft"instart_test.goLeft alone (ambiguous, reviewer decision)
cmd/pro/start.go:1359comment "delete the loft namespace" (refers to the literal default namespace)cmd/pro/start.go:1407error "couldn't find any host in loft ingress" (names theloft-ingressresource)cmd/pro/start_docker.go:298comment "mount the loft lib" (the mount is/var/lib/loft)cmd/pro/start_flags.go:128help text "create a loft.host tunnel" (hostname form)Validation
go build ./...: passGOOS=windows go veton changed packages: passgo veton changed packages: passmise run cli:format: no changesmise run cli:lint:ci: 0 issues (after goconst fix)go test ./cmd/pro/... ./pkg/config/... ./pkg/provider/... ./pkg/workspace/...: passEnvLoft,loftClient,LoftRouter,findLoft,waitForLoft,addLoftProvider,pingLoft, etc.): no matchesCodeRabbit
Not run. The CLI failed twice with
Connection failed: WebSocket closed(committed review,--base origin/main, both plain and--agent).Contract-string diff is limited to the constant name for
DevsyRouterDomainSecret; its value is unchanged.Summary by CodeRabbit