Skip to content

ci(desktop): do not cancel main runs - #1549

Merged
skevetter merged 1 commit into
mainfrom
ci/desktop-ci-main-no-cancel
Oct 18, 2026
Merged

skevetter merged 1 commit into
mainfrom
ci/desktop-ci-main-no-cancel

Conversation

@skevetter

@skevetter skevetter commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • desktop-ci.yml concurrency: pull_request runs keep a per-PR group and cancel superseded runs; push and workflow_dispatch runs use a run-id group and never cancel.
  • Two lines changed in .github/workflows/desktop-ci.yml; nothing else.

Why

A later push to main (or electron-ui) cancels the earlier Desktop CI run for main, because the group was desktop-ci-${{ github.ref }} with cancel-in-progress: true. pr-ci.yml already avoids this with the same pattern.

Validation

  • actionlint .github/workflows/desktop-ci.yml (Homebrew actionlint 1.7.12): clean.
  • No Go or desktop changes, so no Go or desktop tests were run.

CodeRabbit CLI

coderabbit review --agent --committed --base-commit 5f2e1e2a43c8a8a4397538de3c75c03a3c7b963a: completed, 0 findings, reviewed .github/workflows/desktop-ci.yml.

Auto-merge

  • Eligible: yes. 2 changed non-test lines, 1 file.
  • Concurrency before: group desktop-ci-${{ github.ref }}, cancel-in-progress: true.
  • Concurrency after: group desktop-ci-<github.ref for pull_request, github.run_id otherwise>, cancel-in-progress only on pull_request.
  • Jobs exercised: Desktop CI jobs run on this PR because .github/workflows/desktop-ci.yml is in the desktop paths filter.

Next

  • Backlog item 2: fold docker-buildkit-windows.yml into pr-ci.yml.

Summary by CodeRabbit

  • Chores
    • Automated checks now cancel older runs only for pull requests. Runs triggered by other events continue independently, even when a newer run starts. This is an internal workflow change and does not alter any user-facing features or behavior.

@skevetter skevetter added the ci-refactor CI/e2e refactor label Oct 18, 2026
@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 8bbc3d7
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad4f46e5e40321a4ea56626

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f6d9e26-c76d-42d2-b288-fe20495d57da
📥 Commits

Reviewing files that changed from the base of the PR and between 5f2e1e2 and 8bbc3d7.

📒 Files selected for processing: 1
  • .github/workflows/desktop-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The desktop CI workflow now keys pull-request concurrency groups by ref and other event groups by run ID. It cancels runs only for pull requests.

Changes: Desktop CI concurrency

Layer / File(s) Summary
Configure event-specific concurrency
.github/workflows/desktop-ci.yml
Pull-request runs use the ref-based concurrency group and can be canceled. Other event runs use a run-ID-based group and are not canceled when a newer run starts.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 8bbc3

Desktop CI now preserves separate push and manual runs while canceling superseded pull-request runs. No actionable merge-blocking risk was identified; the change is ready for normal checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 8bbc3

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/desktop-ci.yml: The concurrency group now keys non-PR events by run ID while retaining the ref-based group for pull requests. Cancellation changed from always enabled to enabled only for pull requests.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preventing cancellation of Desktop CI runs for main-branch events.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 8bbc3d7
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad4f46e919e57eb421c38a1

@skevetter
skevetter marked this pull request as ready for review October 18, 2026 17:01
@mergify

mergify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 7b0054f into main Oct 18, 2026
38 checks passed
@skevetter
skevetter deleted the ci/desktop-ci-main-no-cancel branch October 18, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-refactor CI/e2e refactor size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant