You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
desktop-ci.yml concurrency: pull_request runs keep a per-PR group and cancel superseded runs; push and workflow_dispatch runs use a run-id group and never cancel.
Two lines changed in .github/workflows/desktop-ci.yml; nothing else.
Why
A later push to main (or electron-ui) cancels the earlier Desktop CI run for main, because the group was desktop-ci-${{ github.ref }} with cancel-in-progress: true. pr-ci.yml already avoids this with the same pattern.
Concurrency before: group desktop-ci-${{ github.ref }}, cancel-in-progress: true.
Concurrency after: group desktop-ci-<github.ref for pull_request, github.run_id otherwise>, cancel-in-progress only on pull_request.
Jobs exercised: Desktop CI jobs run on this PR because .github/workflows/desktop-ci.yml is in the desktop paths filter.
Next
Backlog item 2: fold docker-buildkit-windows.yml into pr-ci.yml.
Summary by CodeRabbit
Chores
Automated checks now cancel older runs only for pull requests. Runs triggered by other events continue independently, even when a newer run starts. This is an internal workflow change and does not alter any user-facing features or behavior.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 8f6d9e26-c76d-42d2-b288-fe20495d57da
📥 Commits
Reviewing files that changed from the base of the PR and between 5f2e1e2 and 8bbc3d7.
📒 Files selected for processing: 1
.github/workflows/desktop-ci.yml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The desktop CI workflow now keys pull-request concurrency groups by ref and other event groups by run ID. It cancels runs only for pull requests.
Pull-request runs use the ref-based concurrency group and can be canceled. Other event runs use a run-ID-based group and are not canceled when a newer run starts.
Desktop CI now preserves separate push and manual runs while canceling superseded pull-request runs. No actionable merge-blocking risk was identified; the change is ready for normal checks.
### Architecture Summary
Architecture risk:🔵 Low · up to 8bbc3
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
observed — Modified behavior in .github/workflows/desktop-ci.yml: The concurrency group now keys non-PR events by run ID while retaining the ref-based group for pull requests. Cancellation changed from always enabled to enabled only for pull requests.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: preventing cancellation of Desktop CI runs for main-branch events.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop-ci.ymlconcurrency:pull_requestruns keep a per-PR group and cancel superseded runs;pushandworkflow_dispatchruns use a run-id group and never cancel..github/workflows/desktop-ci.yml; nothing else.Why
A later push to
main(orelectron-ui) cancels the earlier Desktop CI run formain, because the group wasdesktop-ci-${{ github.ref }}withcancel-in-progress: true.pr-ci.ymlalready avoids this with the same pattern.Validation
actionlint .github/workflows/desktop-ci.yml(Homebrew actionlint 1.7.12): clean.CodeRabbit CLI
coderabbit review --agent --committed --base-commit 5f2e1e2a43c8a8a4397538de3c75c03a3c7b963a: completed, 0 findings, reviewed.github/workflows/desktop-ci.yml.Auto-merge
desktop-ci-${{ github.ref }},cancel-in-progress: true.desktop-ci-<github.ref for pull_request, github.run_id otherwise>,cancel-in-progressonly onpull_request..github/workflows/desktop-ci.ymlis in thedesktoppaths filter.Next
docker-buildkit-windows.ymlintopr-ci.yml.Summary by CodeRabbit