Repository navigation
fix(workspace): preserve detached launch results - #1513
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@greptileai review |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPreserves the saved workspace folder in detached launch success responses.
Reviews (1) · Last reviewed commit: "fix(workspace): retain detached result w..." · Reviewed by Greptile |
|
@coderabbitai full review Please complete a fresh full review while this PR remains draft at exact head 1eed3dd, covering all three changed files: cmd/workspace/task.go, cmd/workspace/task_test.go, and pkg/agent/delivery/kubernetes.go. All applicable current implementation/external checks passed, including all 90 Pull Request jobs; Greptile completed at 5/5 with no actionable findings. Please include current architecture/security and merge-risk assessment of the detached result-envelope mapping, nil compatibility and logging wording, and inspect the complete diff and tests. Use only the included review allowance; do not enable paid usage, modify code or change settings. |
|
@coderabbitai Please report the status of the existing manual full-review request #1513 (comment) for exact head 1eed3dd. It was posted at 00:47 UTC and has no acknowledgment or completed review visible at 01:28 UTC. Is it accepted, queued, running, rate-limited, or not received? This is a status clarification only: do not start or duplicate a review while one is pending, and do not enable paid usage or change settings. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -uo pipefail
repo="devsy-org/devsy"
sha="1eed3dd5bdf130d1ffa179ab544f63a2b5dff97e"
echo "=== Request comment ==="
gh api "repos/$repo/issues/comments/6227547452" --jq '{id,created_at,updated_at,user:.user.login,body,html_url,reactions}'
echo "=== Current PR head ==="
gh api "repos/$repo/pulls/1513" --jq '{head:.head.sha,draft,state,updated_at}'
echo "=== CodeRabbit issue comments ==="
gh api --paginate "repos/$repo/issues/1513/comments?per_page=100" --jq '.[] | select(.user.login | test("coderabbit";"i")) | {id,created_at,updated_at,body,html_url}'
echo "=== CodeRabbit reviews ==="
gh api --paginate "repos/$repo/pulls/1513/reviews?per_page=100" --jq '.[] | select(.user.login | test("coderabbit";"i")) | {id,submitted_at,state,commit_id,body,html_url}'
echo "=== Check runs for requested head ==="
gh api --paginate "repos/$repo/commits/$sha/check-runs?per_page=100" --jq '.check_runs[] | {name,app:.app.slug,status,conclusion,started_at,completed_at,details_url,output:{title:.output.title,summary:.output.summary}}'
echo "=== Commit statuses for requested head ==="
gh api "repos/$repo/commits/$sha/status" --jq '{state,statuses:[.statuses[] | {context,state,description,created_at,updated_at,target_url}]}'Length of output: 44657
I checked the request, CodeRabbit comments and reviews, and checks for exact head
I cannot access internal dispatch or queue records through the available tools. Therefore, I cannot distinguish accepted, queued, running, rate-limited, or not received by the review service. The lack of an acknowledgment does not prove any one of those states. CodeRabbit support would need to inspect the original comment ID I did not start or duplicate a review, enable paid usage, or change settings. You are interacting with an AI system. |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Desktop follows a detached launch task, whose success response reconstructed the container and user but dropped the resolved workspace folder. Preserve the saved substitution-context folder in that response, with existing nil-result compatibility and warnings/recovery metadata intact. The new JSON response regression fails against the old mapper and passes with the fix.
Also use generic container/exec-stream wording in the shared agent-delivery success messages, which are used by external runtimes as well as Kubernetes.
Validation: affected workspace/up package race tests and vet, Windows workspace test compilation, required Linux CLI lint and scoped pre-commit checks. Current-head CI and remote reviews remain required. Local CodeRabbit service-start gating is temporarily waived by the user while unavailable; no local CodeRabbit coverage is claimed.
Closes #1514.
Summary by CodeRabbit