Repository navigation
refactor(hack): port agent-skill validator to Go - #1509
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
…agent-skill-go # Conflicts: # hack/ci/agent-skill-evaluation.md
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Summary
hack/ci/validate-agent-skill.shwith the Go commandhack/validate_agent_skill.SKILL.mdmust be a non-empty regular file.agent-skilljob inpr-ci.yml(addssetup-go) and theagent-skill:validateTaskfile task to the Go command. Update the doc paragraph that named the script.Why
The bash script is Linux and macOS only, and it cannot be unit tested. The Go port runs on all platforms and has table-driven tests for each step, including failure at each step, the installed-tree comparison, and the venv layout per GOOS.
Behaviour changes: none on success. Two deliberate deltas: the installed
SKILL.mdcheck is stricter (non-empty regular file, not justtest -f), and thenpx --jsonoutput is discarded (the old script wrote it to a deleted temp file).Known gap: the tree comparison covers regular files only. Empty directories are not compared (
diff -rdid).Validation
gofmt -l hack/validate_agent_skill: cleango vet ./hack/validate_agent_skill/...: cleango test -count=1 ./hack/validate_agent_skill/...: passGOOS=linux|windows|darwin golangci-lint run ./hack/validate_agent_skill/...: 0 issuesgo run ./hack/validate_agent_skill: passed end to end (pip install, skills-ref validate, Codex and Claude Code installs)PYTHON=/nonexistent go run ./hack/validate_agent_skill: exits 1 with the Python 3.11+ messagego run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/pr-ci.yml: no findings in theagent-skilljob. One pre-existing finding onorigin/mainat thefree-disk-spacestep (background:key), not touched here.CI jobs exercised
agent-skill(changed; runs the new command)CodeRabbit CLI
coderabbit review --agent --committedagainstorigin/main: completed, 0 findings, 6 files reviewed.Auto-merge
No. Changes
.github/workflows/pr-ci.yml; needs human review.Summary by CodeRabbit