Repository navigation
refactor(e2e): call framework.SetupDockerProvider directly - #1481
Conversation
The per-package setupDockerProvider wrappers in e2e/tests/up, up-features and up-docker-compose only forwarded to framework.SetupDockerProvider. Remove them and call the framework function at each site. up-docker-compose passes "docker" explicitly where the wrapper implied it. Behaviour is unchanged.
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
What changed
setupDockerProvider:e2e/tests/up/helper.go(binDir, dockerPath)e2e/tests/up-features/helper.go(binDir, dockerPath, with its//nolint:unparamcomment)e2e/tests/up-docker-compose/helper.go(binDir, always passed"docker")framework.SetupDockerProviderdirectly with the same arguments.up-docker-composenow passes"docker"explicitly where the wrapper implied it.e2e/frameworkimport frome2e/tests/up-features/helper.go.Why
The three wrappers only forwarded to
framework.SetupDockerProvider(e2e/framework/command.go). Removing them leaves one implementation and one call path.CodeRabbit findings
coderabbit review --agent --committed --base-commit 2f3756f1failed with "Failed to start review. Please try again." No findings were produced, so none are fixed or skipped.Verification
grep -rn setupDockerProvider e2ereturns nothing.task cli:formatclean (no changes beyond the 24 edited files).task cli:lint:ci: 0 issues. The first run hit "parallel golangci-lint is running" (a lock from another process) and was rerun clean.go vet ./e2e/...exit 0.go test -count=1 -run xxx ./e2e/...exit 0 (e2e packages compile).Summary by CodeRabbit