Skip to content

Mirror Docker images to GHCR (#1449) - #1478

Merged
skevetter merged 5 commits into
mainfrom
chore/ghcr-mirror-postgres-nginx
Oct 14, 2026
Merged

skevetter merged 5 commits into
mainfrom
chore/ghcr-mirror-postgres-nginx

Conversation

@skevetter

@skevetter skevetter commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Phase C of #1449: point e2e docker-compose fixtures at GHCR mirrors instead of Docker Hub.

Changes

  • docker-compose-multiple-services/docker-compose.yaml: postgres:latest -> ghcr.io/devsy-org/test-images/postgres:latest
  • docker-compose-run-services/docker-compose.yaml: postgres:latest -> ghcr.io/devsy-org/test-images/postgres:latest
  • docker-compose-forward-ports/docker-compose.yaml: nginxinc/nginx-unprivileged:latest -> ghcr.io/devsy-org/test-images/nginx-unprivileged:latest

Mirrors were created with docker buildx imagetools so index digests match upstream (postgres sha256:74935e72..., nginx-unprivileged sha256:1d26a516...).

Verification

  • docker compose config --images resolves all three files to the GHCR refs (local parse only).
  • CI e2e runners are the image-pull verification; see status checks.

Summary by CodeRabbit

  • Chores
    • Updated the Nginx and PostgreSQL container images used in Docker Compose test scenarios. The scenarios continue to cover port forwarding, multiple services, and service startup with the revised images. These changes affect the test environments; no user-facing application behavior is noted.

Point compose test fixtures at ghcr.io/devsy-org/test-images/postgres:latest
and ghcr.io/devsy-org/test-images/nginx-unprivileged:latest instead of
Docker Hub. Mirrors were created with buildx imagetools so the index digests
match the upstream sources (postgres sha256:74935e72..., nginx-unprivileged
sha256:1d26a516...).
@netlify

netlify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 47f414c
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6aced07de2b67ef6a39e73cd

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 21f29706-bbe6-49bd-9a37-fbad07a7134b
📥 Commits

Reviewing files that changed from the base of the PR and between 229b844 and 47f414c.

📒 Files selected for processing: 3
  • e2e/tests/up-docker-compose/testdata/docker-compose-forward-ports/docker-compose.yaml
  • e2e/tests/up-docker-compose/testdata/docker-compose-multiple-services/docker-compose.yaml
  • e2e/tests/up-docker-compose/testdata/docker-compose-run-services/docker-compose.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Three Docker Compose test fixtures now reference nginx and PostgreSQL images from ghcr.io/devsy-org/test-images.

Changes: Docker Compose test fixtures

Layer / File(s) Summary
Update fixture image references
e2e/tests/up-docker-compose/testdata/docker-compose-forward-ports/docker-compose.yaml, e2e/tests/up-docker-compose/testdata/docker-compose-multiple-services/docker-compose.yaml, e2e/tests/up-docker-compose/testdata/docker-compose-run-services/docker-compose.yaml
The forward-ports fixture now uses ghcr.io/devsy-org/test-images/nginx-unprivileged:latest. The multiple-services and run-services fixtures now use ghcr.io/devsy-org/test-images/postgres:latest.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 47f41

The PostgreSQL image is anonymously accessible, so the fixture change is mergeable after normal checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 47f41

The change affects 1 system.

Changed systems: e2e

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — e2e (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in e2e/tests/up-docker-compose/testdata/docker-compose-forward-ports/docker-compose.yaml: The nginx service image changes from nginxinc/nginx-unprivileged:latest to ghcr.io/devsy-org/test-images/nginx-unprivileged:latest.
  • observed — Modified behavior in e2e/tests/up-docker-compose/testdata/docker-compose-multiple-services/docker-compose.yaml: The db service image changed from postgres:latest to ghcr.io/devsy-org/test-images/postgres:latest.
  • observed — Modified behavior in e2e/tests/up-docker-compose/testdata/docker-compose-run-services/docker-compose.yaml: The db service now uses ghcr.io/devsy-org/test-images/postgres:latest instead of postgres:latest.
Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: replacing Docker Hub image references with GHCR mirrors in the end-to-end Docker Compose fixtures.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 47f414c
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6aced07d10efdbc18a3f5470

The test-images/postgres and nginx-unprivileged GHCR packages are private,
so anonymous runner pulls fail with unauthorized. Grant the integration
job packages:read and log in with GITHUB_TOKEN before compose tests.
@github-actions github-actions Bot added size/s and removed size/xs labels Oct 13, 2026
The e2e binary runs under sudo, which reads root's docker config, not the
runner user's. Log in as both so test-images pulls authenticate.
The up-docker-compose-only login did not unblock the multiple-services
spec: test-images/postgres is still private, and the authenticated pull
returned 'denied' (run 38474399648). Public packages pull anonymously
(nginx-unprivileged verified 200 without auth), so the login is unneeded
for them. Revert to main until postgres visibility is fixed.
Previous commit pulled unrelated main changes into pr-ci.yml. Restore the
PR base version so the only change to this file is the removal of the
login step, which is verified to be unnecessary (see prior commit).
@github-actions github-actions Bot added size/xs and removed size/s labels Oct 14, 2026
@skevetter
skevetter marked this pull request as ready for review October 14, 2026 03:24
@mergify

mergify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit e44b1f4 into main Oct 14, 2026
187 of 189 checks passed
@skevetter
skevetter deleted the chore/ghcr-mirror-postgres-nginx branch October 14, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant