Skip to content

fix(desktop): simplify settings updates UI - #1381

Merged
skevetter merged 1 commit into
mainfrom
codex/settings-ux-refresh
Oct 6, 2026
Merged

skevetter merged 1 commit into
mainfrom
codex/settings-ux-refresh

Conversation

@skevetter

@skevetter skevetter commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Settings previously repeated release-channel information and exposed three Advanced preferences that had no runtime consumers. This change makes Updates more compact and removes the inactive Advanced section while retaining its saved values and schema.

  • Show concise Stable/Preview choices, an accessible automatic-download switch, and a semantic Current version row with an Unavailable fallback.
  • Remove repeated channel metadata from ordinary status states while retaining it for missing-channel releases.
  • Preserve backend channel identifiers, updater actions, downgrade confirmation, auto-download persistence and rollback, and legacy settings storage.

Validation:

  • Desktop unit tests: 78 files, 857 tests passed.
  • task desktop:check: Svelte check (zero errors/warnings) and Biome passed.
  • npm --prefix desktop run format:check, changed-file pre-commit hooks, and git diff --check passed.
  • Electron build passed.
  • task cli:lint:ci: zero issues.
  • Electron UI checks with mocked update statuses passed in light/dark themes at 420, 760, and 1200 pixels; channel switching, automatic download, and Preview-to-Stable confirmation checked.
  • Independent implementation review found no correctness defects. Local CodeRabbit review remains blocked by its free OSS review quota; this draft is not claimed ready for merge.

Summary by CodeRabbit

  • Updates
    • Update status details no longer repeat the release channel, and channel options no longer display cadence text.
    • Update preferences now clarify automatic downloads and restart guidance, with a clearly identified toggle.
    • The current version appears in its own row, including when version information is unavailable.
  • Settings
    • The Advanced section has been removed, including controls for experimental multi-devcontainer support, additional CLI flags, and environment variables.

@netlify

netlify Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit f02fd26
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ac435433a08ae00085102a7

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e9ed63c7-640c-4746-a4dc-e01550083572
📥 Commits

Reviewing files that changed from the base of the PR and between d69177c and f02fd26.

📒 Files selected for processing (6)
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
  • desktop/src/renderer/src/lib/components/update/channel.test.ts
  • desktop/src/renderer/src/lib/components/update/channel.ts
  • desktop/src/renderer/src/pages/SettingsPage.svelte
  • desktop/src/renderer/src/pages/SettingsPage.test.ts
💤 Files with no reviewable changes (2)
  • desktop/src/renderer/src/lib/components/update/channel.ts
  • desktop/src/renderer/src/pages/SettingsPage.svelte

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The update panel changes its release-channel details, automatic-download controls, and current-version display. The Settings page removes the Advanced section and its experimental controls.

Changes

Update panel presentation

Layer / File(s) Summary
Channel metadata and status presentation
desktop/src/renderer/src/lib/components/update/channel.ts, desktop/src/renderer/src/lib/components/update/channel.test.ts, desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte, desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
Channel metadata now contains only values and labels. Update-status details omit release-channel labels. Tests check channel labels, status details, and the current version in status states.
Update preferences and current version
desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte, desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
The panel revises the automatic-download label and switch description, removes cadence text, and displays the current version or “Unavailable.” Tests check channel selection, preference persistence and rollback, and current-version display.

Settings page

Layer / File(s) Summary
Remove Advanced settings
desktop/src/renderer/src/pages/SettingsPage.svelte, desktop/src/renderer/src/pages/SettingsPage.test.ts
The page removes the Advanced section and its experimental controls. Tests check that the section and related controls are absent.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f02fd

The settings changes appear mergeable after normal checks; no concrete issue requiring a fix was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the settings UI simplification, including the update preferences changes and removal of the Advanced section.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f02fd26
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ac4354342936a000818f6ed

@skevetter
skevetter force-pushed the codex/settings-ux-refresh branch from 32d9d39 to f02fd26 Compare October 5, 2026 23:39
@github-actions github-actions Bot added the size/l label Oct 5, 2026
@skevetter
skevetter marked this pull request as ready for review October 6, 2026 00:51
@mergify

mergify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 67e989b into main Oct 6, 2026
33 checks passed
@skevetter
skevetter deleted the codex/settings-ux-refresh branch October 6, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant