Repository navigation
fix(ci): recover partial Windows Podman initialization - #1374
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Windows Podman setup script now reserves bootstrap time for diagnostics and recovery, allows longer machine initialization, and handles an exact VM-absent result during cleanup. Tests cover timeout and recovery scenarios. The CI path filter now includes matching Windows setup scripts. ChangesWindows Podman Bootstrap
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This change extends the Windows Podman initialization window and makes recovery tolerate an already-absent machine. No concrete merge-blocking defect was found. The remaining step is the Windows integration runs the author already plans. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
b8c6a2a to
21ec180
Compare
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Cold Windows WSL initialization can exceed the old 90-second cap and leave a distribution before Podman commits machine metadata. Recovery then aborted on expected
VM does not existresponses, even after WSL cleanup.Allow initialization up to 150 seconds within the unchanged 270-second bootstrap budget, reserving diagnostics and first-attempt recovery time. Accept only the exact missing-default-machine response during Podman stop/remove, clean up only
podman-machine-default, and retry a fresh initialization after successful cleanup. Unexpected errors still fail recovery. Synchronize the descendant-process test before termination, and include helper changes in the existing integration CI path filter. Job timeouts are unchanged.Validation:
task cli:lint:ci: passed, 0 issues.git diff --check: passed.21ec18039ae2d2b63944d77f97279781c551248f: signature verified locally and by GitHub (verified=true,reason=valid).The optional image-cache optimization is deferred.
Summary by CodeRabbit
Bug Fixes
Chores