Repository navigation
fix: own persistent SSH transport lifecycle - #1177
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesThe change adds persistent transport lifecycle management with close classification, cancellation, first-close-wins metadata, and close logging. Tunnel callers now pass metadata. SSH keepalive rejection handling and direct-tcpip channel tests were added. The CI workflow upgrades Podman to v5.8.4. Tunnel transport lifecycle
Podman integration test runtime
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The PR updates persistent SSH transport lifecycle handling without any identified concrete product or runtime risk; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant WorkspaceSSH
participant Tunnel
participant PersistentTransport
participant PipeBridge
participant Provider
participant SSHHandler
WorkspaceSSH->>Tunnel: provide provider, mode, and workspace metadata
Tunnel->>PersistentTransport: start persistent provider and SSH pair
PersistentTransport->>PipeBridge: run paired transports
Provider-->>PersistentTransport: complete or return provider error
SSHHandler-->>PersistentTransport: complete or return SSH error
PersistentTransport->>PersistentTransport: classify and record first close
PersistentTransport-->>Tunnel: return close info and error
Tunnel->>Tunnel: log transport close
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 19.35% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 31 functions across 7 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f221cfc to
21c6d16
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Summary by CodeRabbit
Bug Fixes
Improvements