Skip to content

test(e2e): add debug flag to up stream - #1102

Merged
skevetter merged 1 commit into
mainfrom
test/add-debug-flag-to-streams
Aug 18, 2026
Merged

skevetter merged 1 commit into
mainfrom
test/add-debug-flag-to-streams

Conversation

@skevetter

@skevetter skevetter commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Signed-off-by: Samuel K skevetter@pm.me

Summary by CodeRabbit

  • Bug Fixes
    • Workspace startup commands now correctly preserve the debug setting while retaining the selected IDE and additional options.

Signed-off-by: Samuel K <skevetter@pm.me>
@netlify

netlify Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f4b9013
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a83ad9103771d0008eb6962

@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2730449f-cb12-4ca9-a285-2ade3b278ced

📥 Commits

Reviewing files that changed from the base of the PR and between bfc05ae and f4b9013.

📒 Files selected for processing (1)
  • e2e/framework/command.go

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

DevsyUpStreams now includes flagDebug when it constructs the devsy workspace up command. The existing IDE selection and additional workspace arguments remain unchanged.

Changes

Workspace up command

Layer / File(s) Summary
Debug flag wiring
e2e/framework/command.go
DevsyUpStreams passes flagDebug before the IDE and workspace arguments.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f4b90

This is a small, localized end-to-end test change that adds a debug flag to stream execution; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of the debug flag to the E2E up stream command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch test/add-debug-flag-to-streams

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit f4b9013
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a83ad91a1617e0008b330e0

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 18, 2026 01:00
@skevetter
skevetter enabled auto-merge (squash) August 18, 2026 01:00
@skevetter
skevetter disabled auto-merge August 18, 2026 01:23
@skevetter
skevetter merged commit 078bff4 into main Aug 18, 2026
73 of 78 checks passed
@skevetter
skevetter deleted the test/add-debug-flag-to-streams branch August 18, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant