Repository navigation
ci: do not install python tools for test #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4a02282
ci: do not install python tools for test
skevetter 3e33886
Merge branch 'main' into ci/update-python-feature
skevetter 01d41cf
fix: use correct version for comparison
skevetter 97ecfe6
ci: retry flaky provider/tunnel e2e jobs on cold image pulls
skevetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: devsy-org/devsy
Length of output: 11816
🌐 Web query:
devcontainers features python feature version 3.13 version resolution latest patch install.sh💡 Result:
In the Dev Containers Python feature, the version resolution for the
pythonfeature is managed by theinstall.shscript [1][2]. When theversionoption is set tolatest(which is a common default behavior for such scripts when no specific version is provided) [3][2], the script fetches available versions of Python and resolveslatestto the most recent stable release available at the time of execution [2]. Regarding your specific query points: 1. Version Resolution: Theinstall.shscript dynamically determines the version [2]. It typically performs a lookup (e.g., querying remote tags or release information) to identify the latest version when "latest" is specified [2]. 2. Patch Versions: You can pin to a specific patch version by providing the full version string (e.g., "3.13.1") in theversionoption of yourdevcontainer.jsonfile [4]. If you only specify the major.minor version (e.g., "3.13"), the behavior depends on the implementation details of the feature's tag lookup, but pinning to the full version is the recommended practice for deterministic builds [4]. 3.install.shMechanism: The script handles the installation by either usingos-providedpackages (if specified) or by downloading and building the requested Python version from source [5][6][2]. It includes logic to handle path setup, symlinks (e.g., pointingpythonandpython3to the installed version), and, in some cases, specific vulnerability patching (e.g., removing vulnerablesetuptoolsversions bundled with older Python releases) [1][6][2]. To ensure a specific version like 3.13 is installed, you should explicitly set the version in yourdevcontainer.jsonconfiguration [4]: { "features": { "ghcr.io/devcontainers/features/python:1": { "version": "3.13" } } } If you require a specific patch version, you should use the full version number (e.g., "3.13.0") to avoid ambiguity during the build process [4].Citations:
🌐 Web query:
github devcontainers features python src python version 3.13.15💡 Result:
The Dev Container Python feature (ghcr.io/devcontainers/features/python) allows you to install Python, but it does not support pinning to a specific micro version like 3.13.15 [1][2]. The feature's 'version' option is designed to accept major/minor versions (e.g., '3.13', '3.12') to install the latest available patch version of that series [1][2]. Specifically, the official devcontainers/features repository defines the version option to select a Python version, but it is not intended to resolve specific micro/patch versions [1][2]. If you require a specific micro version of Python such as 3.13.15: 1. Pre-built Images: You can use the official devcontainer images (e.g., mcr.microsoft.com/devcontainers/python), which provide pre-installed Python versions [3][4]. However, these images are also updated to include the latest available patch versions (e.g., 3.13.x) and do not typically allow pinning to a specific micro version via a simple configuration [3][4]. 2. Custom Dockerfile: For precise version control (such as 3.13.15), the recommended approach is to use a custom Dockerfile within your.devcontainer folder [3][4]. You can use a base image or compile your required Python version from source using a standard
DockerfileRUN command [3]. In summary, the Dev Container Python feature is not the appropriate tool for pinning to a specific micro version like 3.13.15; a custom Dockerfile approach is required for that level of specificity [3][2].Citations:
🏁 Script executed:
Repository: devsy-org/devsy
Length of output: 35665
🏁 Script executed:
Repository: devsy-org/devsy
Length of output: 3410
Pin the Python patch version in the fixture.
ghcr.io/devcontainers/features/python:1resolves"3.13"to the latest3.13.x. Set the fixture version to"3.13.15"or assert thePython 3.13.prefix if only the minor version matters.🤖 Prompt for AI Agents