Repository navigation
fix(ui): add dark-mode variants to ssh keys icons - #1065
Merged
Merged
Conversation
## Problem On `desktop/src/renderer/src/pages/SshKeysPage.svelte`, three status-icon color classes lacked dark-mode variants, so the passphrase/no-passphrase `ShieldCheck`/`ShieldAlert` icons render with low contrast in dark mode. This was also internally inconsistent: the same file already used `text-green-600 dark:text-green-400` for the `ShieldCheck` icon in the key list (line 178), but the legend below used bare `text-green-600`, and both `ShieldAlert` icons used bare `text-amber-500` with no dark variant — while the rest of the app uses `text-amber-600 dark:text-amber-400` for amber status icons (e.g. `WorkspaceDetailPage.svelte`). ## Change Added the `dark:` variant to the three affected icon classes on `SshKeysPage.svelte` to match the established pattern: - Line 180: `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400` - Line 207: legend `ShieldCheck` `text-green-600` → `text-green-600 dark:text-green-400` (matches line 178 in the same file) - Line 208: legend `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400` Pure CSS class additions; no behavioral, structural, or logic change. ## Why it's safe / reviewable in <15 min Touches a single file, three class strings. No routing, store, IPC, or data-flow changes. No new dependencies. A reviewer can verify the diff by eye and confirm the classes match the existing green/amber dark-mode pattern already used elsewhere in the file and app. ## Verification - `cd desktop && npm run check` (svelte-check): 0 errors, 0 warnings - `cd desktop && npx vitest run`: 48 tests passed (6 files). (32 unrelated jsdom/undici environment errors are pre-existing on `main` — a `webidl.util.markAsUncloneable is not a function` Node 20 vs undici incompatibility, not caused by this CSS change.) - `task cli:format`: clean - `task cli:lint:ci`: 0 issues - `task cli:test`: only the known pre-existing `pkg/git` `TestRepoClone*` failures (stale assertion on `origin/main`, unrelated to this change); all other packages pass This PR was created by an AI agent as part of an automated daily UI polish job.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
desktop/src/renderer/src/pages/SshKeysPage.svelte, three status-icon color classes lacked dark-mode variants, so the passphrase/no-passphraseShieldCheck/ShieldAlerticons render with low contrast in dark mode. This was also internally inconsistent: the same file already usedtext-green-600 dark:text-green-400for theShieldCheckicon in the key list (line 178), but the legend below used baretext-green-600, and bothShieldAlerticons used baretext-amber-500with no dark variant — while the rest of the app usestext-amber-600 dark:text-amber-400for amber status icons (e.g.WorkspaceDetailPage.svelte).Change
Added the
dark:variant to the three affected icon classes onSshKeysPage.svelteto match the established pattern:ShieldAlerttext-amber-500→text-amber-600 dark:text-amber-400ShieldChecktext-green-600→text-green-600 dark:text-green-400(matches line 178 in the same file)ShieldAlerttext-amber-500→text-amber-600 dark:text-amber-400Pure CSS class additions; no behavioral, structural, or logic change.
Why it's safe / reviewable in <15 min
Touches a single file, three class strings. No routing, store, IPC, or data-flow changes. No new dependencies. A reviewer can verify the diff by eye and confirm the classes match the existing green/amber dark-mode pattern already used elsewhere in the file and app.
Verification
cd desktop && npm run check(svelte-check): 0 errors, 0 warningscd desktop && npx vitest run: 48 tests passed (6 files). (32 unrelated jsdom/undici environment errors are pre-existing onmain— awebidl.util.markAsUncloneable is not a functionNode 20 vs undici incompatibility, not caused by this CSS change.)task cli:format: cleantask cli:lint:ci: 0 issuestask cli:test: only the known pre-existingpkg/gitTestRepoClone*failures (stale assertion onorigin/main, unrelated to this change); all other packages passThis PR was created by an AI agent as part of an automated daily UI polish job.