Skip to content

fix(ui): add dark-mode variants to ssh keys icons - #1065

Merged
skevetter merged 1 commit into
mainfrom
ui-polish/sshkeys-dark-mode-contrast
Aug 15, 2026
Merged

skevetter merged 1 commit into
mainfrom
ui-polish/sshkeys-dark-mode-contrast

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Problem

On desktop/src/renderer/src/pages/SshKeysPage.svelte, three status-icon color classes lacked dark-mode variants, so the passphrase/no-passphrase ShieldCheck/ShieldAlert icons render with low contrast in dark mode. This was also internally inconsistent: the same file already used text-green-600 dark:text-green-400 for the ShieldCheck icon in the key list (line 178), but the legend below used bare text-green-600, and both ShieldAlert icons used bare text-amber-500 with no dark variant — while the rest of the app uses text-amber-600 dark:text-amber-400 for amber status icons (e.g. WorkspaceDetailPage.svelte).

Change

Added the dark: variant to the three affected icon classes on SshKeysPage.svelte to match the established pattern:

  • Line 180: ShieldAlert text-amber-500 → text-amber-600 dark:text-amber-400
  • Line 207: legend ShieldCheck text-green-600 → text-green-600 dark:text-green-400 (matches line 178 in the same file)
  • Line 208: legend ShieldAlert text-amber-500 → text-amber-600 dark:text-amber-400

Pure CSS class additions; no behavioral, structural, or logic change.

Why it's safe / reviewable in <15 min

Touches a single file, three class strings. No routing, store, IPC, or data-flow changes. No new dependencies. A reviewer can verify the diff by eye and confirm the classes match the existing green/amber dark-mode pattern already used elsewhere in the file and app.

Verification

  • cd desktop && npm run check (svelte-check): 0 errors, 0 warnings
  • cd desktop && npx vitest run: 48 tests passed (6 files). (32 unrelated jsdom/undici environment errors are pre-existing on main — a webidl.util.markAsUncloneable is not a function Node 20 vs undici incompatibility, not caused by this CSS change.)
  • task cli:format: clean
  • task cli:lint:ci: 0 issues
  • task cli:test: only the known pre-existing pkg/git TestRepoClone* failures (stale assertion on origin/main, unrelated to this change); all other packages pass

This PR was created by an AI agent as part of an automated daily UI polish job.

## Problem

On `desktop/src/renderer/src/pages/SshKeysPage.svelte`, three status-icon color classes lacked dark-mode variants, so the passphrase/no-passphrase `ShieldCheck`/`ShieldAlert` icons render with low contrast in dark mode. This was also internally inconsistent: the same file already used `text-green-600 dark:text-green-400` for the `ShieldCheck` icon in the key list (line 178), but the legend below used bare `text-green-600`, and both `ShieldAlert` icons used bare `text-amber-500` with no dark variant — while the rest of the app uses `text-amber-600 dark:text-amber-400` for amber status icons (e.g. `WorkspaceDetailPage.svelte`).

## Change

Added the `dark:` variant to the three affected icon classes on `SshKeysPage.svelte` to match the established pattern:

- Line 180: `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400`
- Line 207: legend `ShieldCheck` `text-green-600` → `text-green-600 dark:text-green-400` (matches line 178 in the same file)
- Line 208: legend `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400`

Pure CSS class additions; no behavioral, structural, or logic change.

## Why it's safe / reviewable in <15 min

Touches a single file, three class strings. No routing, store, IPC, or data-flow changes. No new dependencies. A reviewer can verify the diff by eye and confirm the classes match the existing green/amber dark-mode pattern already used elsewhere in the file and app.

## Verification

- `cd desktop && npm run check` (svelte-check): 0 errors, 0 warnings
- `cd desktop && npx vitest run`: 48 tests passed (6 files). (32 unrelated jsdom/undici environment errors are pre-existing on `main` — a `webidl.util.markAsUncloneable is not a function` Node 20 vs undici incompatibility, not caused by this CSS change.)
- `task cli:format`: clean
- `task cli:lint:ci`: 0 issues
- `task cli:test`: only the known pre-existing `pkg/git` `TestRepoClone*` failures (stale assertion on `origin/main`, unrelated to this change); all other packages pass

This PR was created by an AI agent as part of an automated daily UI polish job.
@netlify

netlify Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit a9b5b5d
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a806896cf1f6c0008b8522d

@netlify

netlify Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit a9b5b5d
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a8068968efc490008ecc712

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 15, 2026 17:40
@skevetter
skevetter merged commit 953e7e8 into main Aug 15, 2026
29 checks passed
@skevetter
skevetter deleted the ui-polish/sshkeys-dark-mode-contrast branch August 15, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant