Repository navigation
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Before submitting
- I have searched existing issues to confirm this is not a duplicate
- I am running the latest version of Devsy
What happened?
I'm trying to run devsy via ssh provider on one of my servers whose user has default shell zsh
Running into:
ERROR main:7: command not found: sh -cOnce I have chsh -s /bin/bash on the remote server, it works again.
What did you expect to happen instead?
Launch my editor upon successful copy
Steps to reproduce
- setup remote server with zsh as default shell:
chsh -s /bin/zsh - Add ssh provider:
devsy provider add ssh --name server -o HOST=user@server - Try to launch a workspace:
devsy workspace --provider server .
devcontainer.json
Error output / logs
2026-10-20T16:18:03.693+0200 DEBUG adding SSH keys to agent
2026-10-20T16:18:03.694+0200 DEBUG running ssh-add: privateKeyPath=/home/sourya/.ssh/id_ed25519
2026-10-20T16:18:03.695+0200 DEBUG injecting and running SSH server command: "'/tmp/sourya/devsy/agent' internal ssh-server --stdio --debug"
2026-10-20T16:18:03.695+0200 DEBUG starting agent injection
2026-10-20T16:18:03.695+0200 DEBUG start inject
2026-10-20T16:18:03.695+0200 DEBUG prefer downloading agent from URL: url=https://github.com/devsy-org/devsy/releases/download/v1.24.0
2026-10-20T16:18:03.695+0200 DEBUG execute inject script
2026-10-20T16:18:03.707+0200 DEBUG tunnel: setup start
2026-10-20T16:18:03.707+0200 DEBUG creating SSH client
2026-10-20T16:18:03.956+0200 DEBUG handshake complete elapsed=260.454959ms
2026-10-20T16:18:03.971+0200 DEBUG done exec
2026-10-20T16:18:03.971+0200 DEBUG done inject
2026-10-20T16:18:03.972+0200 DEBUG payload delivered elapsed=276.364386ms
2026-10-20T16:18:03.972+0200 DEBUG done injecting
2026-10-20T16:18:03.972+0200 DEBUG complete elapsed=276.640138ms
2026-10-20T16:18:03.972+0200 DEBUG retrying injection: [inject] 2026-10-20T16:18:03.965+0200 ERROR main:7: command not found: sh -c
read inject signal: EOF
2026-10-20T16:18:14.663+0200 DEBUG start inject
2026-10-20T16:18:14.663+0200 DEBUG prefer downloading agent from URL: url=https://github.com/devsy-org/devsy/releases/download/v1.24.0
2026-10-20T16:18:14.663+0200 DEBUG execute inject script
2026-10-20T16:18:14.952+0200 DEBUG handshake complete elapsed=288.553288ms
2026-10-20T16:18:14.966+0200 DEBUG done exec
2026-10-20T16:18:14.966+0200 DEBUG done inject
2026-10-20T16:18:14.967+0200 DEBUG payload delivered elapsed=303.859002ms
2026-10-20T16:18:14.967+0200 DEBUG done injecting
2026-10-20T16:18:14.967+0200 DEBUG complete elapsed=304.105295ms
2026-10-20T16:18:14.967+0200 DEBUG retrying injection: [inject] 2026-10-20T16:18:14.961+0200 ERROR main:7: command not found: sh -cHow often does this happen?
Every time
Operating system
Linux
Linux distribution (if applicable)
No response
Architecture
AMD64
Desktop app or CLI?
Both
Devsy version
v1.24.0
Devsy provider
SSH
Provider version
v1.1.44
Screenshots
No response
Anything else?
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Activity
skevetter commentedon Oct 31, 2026
Cleanup audit: source fix delivered to prereleases; finish the existing shell qualification
Status: the original default-Zsh bootstrap defect has been fixed. Core and provider changes are merged and available in release artifacts. The outstanding work is qualification of the corrected pair through existing provider PR #164, plus the stable/customer upgrade checks.
Reviewed 30 October 2026. Core source baseline:
9bc12ee041ca854c6f81de95fd8c6e49d7cc028c. SSH-provider release source:c53ba2742db162f587aa57fbc87572d19ec11cd7, v1.1.47. This audit read source, release ancestry and workflow records; it did not execute a customer host or change a login shell.1. Verified implementation and release state
e22be00149ace87d512de0ec953541e3f7642c69d31fed1b2695861b76e922c530ad8a2436f5acb9/bin/shbefore the remote login shell interprets the POSIX bootstrap. Applies to built-in and external SSH transports.9c80b29c7672f4cc3bc54553f57c9a915cad7d197f5f401e874e7b835119548ab1f21ec3e5c4dfd9The current provider launcher encodes the script as one
/bin/sh -cargument, including Fish-specific handling of literal backslashes. It preserves protocol stdin/stdout separately from diagnostics. CoreGenerateScriptandQuotePOSIXLiteralpreserve literal installer inputs. Current workspace startup and host tunnel quote the agent path with the shared shell-escaping convention.This addresses the bootstrap interpreter boundary. It preserves the user's chosen interactive shell. Changing
chsh, replacingSHELL, editing shell startup files, or wrapping every subsequent interactive command in Bash is not part of the fix.2. What remains, and why the old hold is stale
Provider #164's last coordination comment waits for a corrected published core candidate after #1725. That candidate now exists: beta.5 and later, including beta.8. The old beta.2 failure and the earlier passing plain-path matrix remain historical evidence. Neither proves the current literal-path/real-sudo gate.
Use the existing PR and this issue. Do not open a second bootstrap implementation or copy the same test suite into core.
3. Exact engineering tasks
T1. Complete the candidate gate in provider #164
Files on the existing PR:
.github/workflows/tests.yamlande2e/README.md.CORE_FIX_SHA=e22be00149ace87d512de0ec953541e3f7642c69andPROVIDER_FIX_SHA=d31fed1b2695861b76e922c530ad8a2436f5acb9ancestry checks.9c80b29c7672f4cc3bc54553f57c9a915cad7d19, the merged host-path correction. Use the same compare-result allowlist,aheadoridentical, and fail before fixture provisioning for any other result. Include both core fix identities inpair-verification.txt. This prevents an artifact containing only fix(inject): quote bootstrap inputs and preserve installed agents #1627 from being selected for the broader literal-path acceptance.v1.25.0-beta.8atf4d6039acf68bffcba9d1f9ce927cce144b7dc66, providerv1.1.47atc53ba2742db162f587aa57fbc87572d19ec11cd7. Resolve and record the live tag identities again when dispatching; never silently substitute a different candidate.clianddesktopartifact rows. Beta.8 publishes bothdevsy-linux-amd64andDevsy_linux_amd64.deb, matching this workflow's selectors. Keep verification of published asset digest, printed version and the actual extractedopt/Devsy/resources/bin/devsy.DEVSY_AGENT_URL,DEVSY_AGENT_BINARYandDEVSY_AGENT_PREFER_DOWNLOADunset for qualification. A development agent override can bypass the delivery behavior under test.T2. Run the existing corrected native qualification
Owned implementation files:
e2e/tests/integration/login_shells.gologin_shells_workspace.gologin_shells_sudo.goqualification.goDispatch the existing
Testsworkflow at the reviewed PR head with explicitcore_tag=v1.25.0-beta.8andprovider_tag=v1.1.47. Run in the existing disposable GitHub Actions environment.Require all six shell/transport cells: Bash, Zsh and Fish, each over external and built-in SSH.
In every cell retain the five implemented scenarios: cold remote-download install, current-agent reuse, stale replacement, cold stdin-transfer install/reopen, and live workspace SSH/reopen behavior. Require unchanged login-shell identity and owned cleanup.
Keep agent paths containing space, apostrophe, backslash, dollar sign and Unicode. Keep exact delivered-binary hashes and the staged atomic stale-fixture replacement. Do not remove the troublesome characters or truncate a running executable.
Keep the six command-boundary stream/exit-status cases and the actual non-root sudo scenario. The latter must prove denied ordinary writes to the root-owned directory, successful authorized install, expected root ownership/version/hash, a live workspace command, and cleanup of the temporary policy.
Require all 37 selected cases per artifact source and the complete report predicate. Zero failures with skipped required cases is not a pass. Record the harness commit separately from core and provider artifact commits.
Link both uploaded reports, their exact workflow run and any failure disposition here and on docs: add CLAUDE.md repo skill for engineering agents #164. If a runtime defect is exposed, attach the failing cell and first failing boundary before proposing another source change.
T3. Confirm supported client and Desktop behavior
The Linux qualification harness tests the Desktop-bundled CLI, not the Electron UI.
4. Scope and closure
No further production bootstrap rewrite is justified by the current evidence. Remaining source work is the qualification gate/docs adjustment above, unless the corrected release matrix finds a concrete defect. Preserve the fixed POSIX launcher, argument quoting, byte-stream ownership, cancellation, atomic replacement and normal interactive-shell behavior.
The original failure can be called fixed in source and available in prereleases. Keep the issue open for the existing release qualification until the corrected pair passes and the supported stable delivery is recorded. Then close with the exact core/provider versions and evidence. Provider #164 should continue through its normal Draft PR review and checks; this audit does not mark it ready or merge it.
skevetter commentedon Oct 31, 2026
Completed