Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Integration tests were organised by history, not responsibility. Report types, shell matrices and fixture setup lived in four large files. CI logic sat in workflow shell blocks and a jq expression.
Fix
Split the Ginkgo suites by responsibility and derive every matrix from one
Transportslist. Add a puree2e/qualificationpackage for the versioned report schema and validation. Replace the remaining workflow shell withhack/cicommands behind one registry. Add least privilege permissions, concurrency and timeouts to the check workflows.Test evidence
Commit:
7ef802647a9f7806ea68470a036535bdc7cab88e, signature verified.go vet ./...: clean.go test ./hack/... ./e2e/qualification/... ./pkg/... ./cmd/...: 5 packages passed.golangci-lint run ./...: 0 issues.actionlinton the 4 changed workflows: 0 errors.prek run --all-files: 9 hooks passed, 2 skipped.v1.25.0-beta.8and providerv1.1.47: CLI and Desktop bundled CLI each passed 37 of 37 selected specs.Not verified
Native Desktop UI, customer-host behaviour and stable core release delivery.