Skip to content

refactor(ssh): restructure integration tests and CI commands - #167

Merged
skevetter merged 1 commit into
issue/1621-release-qualificationfrom
refactor/integration-test-architecture
Nov 1, 2026
Merged

skevetter merged 1 commit into
issue/1621-release-qualificationfrom
refactor/integration-test-architecture

Conversation

@skevetter

@skevetter skevetter commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Cause

Integration tests were organised by history, not responsibility. Report types, shell matrices and fixture setup lived in four large files. CI logic sat in workflow shell blocks and a jq expression.

Fix

Split the Ginkgo suites by responsibility and derive every matrix from one Transports list. Add a pure e2e/qualification package for the versioned report schema and validation. Replace the remaining workflow shell with hack/ci commands behind one registry. Add least privilege permissions, concurrency and timeouts to the check workflows.

Test evidence

Commit: 7ef802647a9f7806ea68470a036535bdc7cab88e, signature verified.

  • go vet ./...: clean.
  • go test ./hack/... ./e2e/qualification/... ./pkg/... ./cmd/...: 5 packages passed.
  • golangci-lint run ./...: 0 issues.
  • actionlint on the 4 changed workflows: 0 errors.
  • prek run --all-files: 9 hooks passed, 2 skipped.
  • Ginkgo dry run: 49 specs, with names, hierarchy and labels identical to the base branch.
  • PR checks: 7 passed, 2 skipped by design.
  • Dispatch run with core v1.25.0-beta.8 and provider v1.1.47: CLI and Desktop bundled CLI each passed 37 of 37 selected specs.

Not verified

Native Desktop UI, customer-host behaviour and stable core release delivery.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bd02f4d-118e-40d5-a9d8-f5aab2bf65ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@skevetter
skevetter marked this pull request as ready for review November 1, 2026 19:02
@skevetter
skevetter merged commit ca5f8ab into issue/1621-release-qualification Nov 1, 2026
13 checks passed
@skevetter
skevetter deleted the refactor/integration-test-architecture branch November 1, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant