Skip to content

fix(provider): correct ssh provider icon URL - #12

Merged
skevetter merged 2 commits into
mainfrom
fix/provider-icon-urls
Nov 14, 2026
Merged

skevetter merged 2 commits into
mainfrom
fix/provider-icon-urls

Conversation

@skevetter

@skevetter skevetter commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The SSH provider icon URL now points to the renderer’s provider icons directory. buildProvider uses that URL for both Icon and IconDark.

Changes: SSH provider icon

Layer / File(s) Summary
Update SSH provider icon URL
hack/provider/main.go
The iconURL constant points to the renderer’s provider icons directory. buildProvider uses it for both Icon and IconDark.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to 4c4c4

This updates the SSH provider icon URL so that the generated manifest points to a working icon. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the fix and the component (ssh provider icon URL). The raw summary says the iconURL constant now points to the SSH provider icon under the renderer public icons path, replacing the old…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the fix and the component (ssh provider icon URL). The raw summary says the iconURL constant now points to the SSH provider icon under the renderer public icons path, replacing the old desktop/src/images/ssh.svg URLs in buildProvider. The objectives describe a broader fix that covers several provider icon URLs, so the title covers one real part of the change but not all of it. It is partially related, which passes under the criteria. The title is short, uses a conventional prefix, and is specific enough that a teammate scanning history understands the main change.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 610c55e7-637a-4f1e-8bed-6b6e54fa4f31
Commits

Reviewing files that changed from the base of the PR and between 4882a89 and 4c4c4ea.

Files selected for processing: 1

  • hack/provider/main.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Signed-off-by: Samuel K <skevetter@pm.me>
@skevetter skevetter changed the title fix: correct broken provider icon URLs fix(provider): correct ssh provider icon URL Nov 14, 2026
@skevetter
skevetter merged commit 539c9c7 into main Nov 14, 2026
9 checks passed
@skevetter
skevetter deleted the fix/provider-icon-urls branch November 14, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant