fix: verify webhooks after Vercel JSON parsing - #701
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Vercel's plain Node
/apihelper may supply an already-parsed JSON body even withbodyParser:false. Re-serialize that object before Standard Webhooks verification.This stays fail-closed: only an exact byte match to Polar's signed compact JSON is accepted. Arrays and oversized bodies remain rejected.
Production evidence
A signed-shape smoke request reached
/api/polar-webhookbut returned 400 before signature/config evaluation, identifying the parsed-body adapter gap.Verification