Refactor/better error handling#27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error surfacing: non-throwing parser + unified diagnostics
Reworks how the plugin reports authoring errors, on two fronts: stop using exceptions for expected parse failures, and surface every problem consistently in one place.
Parser: exceptions to results
TokenizerandParserno longer throw. They report failures through aCondition.TryParse(expression, out node, out error)facade instead.ConditionExceptionis deleted, along with its four catch sites.:ifused to throw and catch an exception ~60 times a second. That cost is now gone.Structured diagnostics
Diagnosticrecord (message, optional line number, severity) plus aSeverityenum (Error, Warning).IEnumerable<Diagnostic>instead of a singlestring?, so they report every problem rather than just the first.AliasValidator.Validateaggregator runs all validators and folds cycle detection into the same list.One consistent surface
Warningtheme color (auto-picks up a settings swatch via the existing reflection). Today the only warning is a:until -unsafeused while unsafe waits are disabled.Tests
ConditionEvaluatorTests: malformed expressions now assert afalseresult instead of a thrown exception.AliasValidatorTests: updated to the new return type, plus coverage for per-line reporting and multiple diagnostics from one alias.