Skip to content

Fix Unix target-time Update wiping Pack on license files (NU5030) - #30

Merged
kzu merged 1 commit into
mainfrom
dev/packfix
Aug 19, 2026
Merged

Fix Unix target-time Update wiping Pack on license files (NU5030)#30
kzu merged 1 commit into
mainfrom
dev/packfix

Conversation

@kzu

@kzu kzu commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

Target-time Update="path" in ProcessPackageReadme / ClearPackageReadmeWhenPackReadmeFalse matches every None/Content item on Unix, so retargeting the processed readme also set Pack=false on PackageLicenseFile and other packed items (NU5030).

  • Match items with Update="%(Identity)" + Condition (or Remove of a filtered list)
  • Normalize _ReadmeSourceFile so FullPath compares work on Unix
  • Add SDK pack regressions: license + notice stay packed; PackReadme=false still packs the EULA

Test plan

  • dotnet test src/Tests/Tests.csproj -c Release
  • CI green on PR

MSBuild target-time Update="path" matches every None/Content item on Unix,
which cleared Pack on license files and triggered NU5030. Match by
%(Identity) + Condition (or Remove of a filtered item list) instead,
and add SDK pack scenarios that keep license/notice files packed.
@kzu kzu added the bug Something isn't working label Aug 19, 2026
@kzu
kzu enabled auto-merge (rebase) August 19, 2026 04:59
@kzu

kzu commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

90 passed 90 passed

🧪 Details on Ubuntu 24.04.4 LTS

from retest v1.1.0 on .NET 10.0.11 with 💜 by @devlooped

@kzu
kzu merged commit 56c6217 into main Aug 19, 2026
4 checks passed
@kzu
kzu deleted the dev/packfix branch August 19, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant