GX2, GX2R: add aggregate headers#449
Open
dkosmari wants to merge 2 commits into
Open
Conversation
dkosmari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GX2 is split up into multiple headers with no clear separation of usage (as opposed to coreinit, for example.) In most cases you need multiple headers to accomplish anything, and it's cumbersome to figure out which header is providing the functions and structs you need.
This creates an aggregate header
<gx2.h>that just includes all of GX2.The same was done for GX2R headers, in
<gx2r.h>.This is a common pattern in libraries, to have both:
<foo.h>: includes all offoo.<foo/bar.h>: includes only thebarmodule offoo.