arch: make deviceid moe felxible with cuda/rocm env vars#2906
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 248 248
Lines 51625 51633 +8
Branches 4454 4457 +3
=======================================
+ Hits 43056 43064 +8
+ Misses 7815 7814 -1
- Partials 754 755 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
891ccb4 to
5a91eec
Compare
5a91eec to
bfeebc4
Compare
EdCaunt
approved these changes
Apr 29, 2026
Contributor
EdCaunt
left a comment
There was a problem hiding this comment.
Seems reasonable - I would also update the FAQ to document this behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.