chore(deps): bump eclipse-temurin from 21-jre-alpine to 25-jre-alpine#13
Open
dependabot[bot] wants to merge 31 commits into
Open
chore(deps): bump eclipse-temurin from 21-jre-alpine to 25-jre-alpine#13dependabot[bot] wants to merge 31 commits into
dependabot[bot] wants to merge 31 commits into
Conversation
## Overview Implements all Tier 1-6 items from the stability and user-friendliness hardening plan, transforming Nightshade into a production-ready release. ## Tier 1: Bug Fixes (Critical) - Fixed empty directory warning: '[WARN] No supported source files found' - Fixed invalid strategy warning showing all 8 strategies - Fixed single file output path handling - Fixed dry-run: 'DRY RUN — no files were written' - Added UTF-8 banner detection with ASCII fallback - Added entropy threshold validation (0.0-1.0) - Fixed verify on non-Java: SKIPPED message ## Tier 2: UX Improvements - Added --list-strategies flag - Added --quiet / -q mode for CI pipelines - Added explicit enable for disabled strategies ## Tier 3: Defensive Coding - DeadCodeInjector: Lexer-based brace counting - Serializer: No mutation of input SourceFile - StringEncoder: Skips dead code blocks - CommentPoisoner: Handles multi-line comments ## Tier 4: Test Coverage (81 tests) - 8 new test files with comprehensive coverage - JUnit Jupiter 5.10.2, Maven Surefire 3.5.0 ## Tier 5: Documentation - README: Fixed 'five' to 'eight' strategies - CONTRIBUTING: Fixed architecture tree - action.yml: Added entropy-threshold ## Tier 6: Polish - Added --report / -r flag (nightshade_report.md) - Added .editorconfig - Added Dockerfile HEALTHCHECK ## Verification - Build: SUCCESS - Tests: 81/81 passing - All CLI flags verified working Closes #42 #43 #44 #45 #46 #47 #48 #49
…y chain, and automation
Phase 4 — Bug Fixes (7 resolved):
- ControlFlowFlattener: move _ns_ret declaration into last switch case
- ControlFlowFlattener: rename _ns_state to stateVar
- SemanticInverter: replace Math.abs(hashCode()) with hashCode() & 0x7FFFFFFF
- DeadCodeInjector: add missing return; detection
- Parser: remove unconditional break from method-detection loop
- CommentPoisoner: fix indexOf("/*") with code-before/after comment preservation
- EntropyScrambler: document Bug 4.8 as known architectural limitation
Phase 5 — Code Quality (Checkstyle + PMD):
- Eliminate 328 Checkstyle violations across 18 source files
- Add checkstyle.xml with relaxed Google Java Style rules
- Add PMD 6.55.0 with bestpractices/errorprone/performance/design rulesets
- Configure compiler warnings with -Werror
- Add SpotBugs (skipped for Java 25, tracked for future enablement)
Phase 6 — Infrastructure Hardening:
- Centralize version in pom.xml (nightshade.version) with Maven-filtered version.properties
- Add volatile to enabled field in all 7 strategy classes for thread safety
- Wire Main.APP_VERSION into CLI, MainController, FileUtil, PoisonStrategy
Phase 2-3 — Supply Chain and CI/CD:
- Add Dependabot config for GitHub Actions and Maven
- SHA-pin all 36 action references across 6 workflow files
- Add OSPS Scorecard, CodeQL, dependency review
- Add Maven Enforcer, OWASP Dependency Check, CycloneDX SBOM
- Generate Maven wrapper (3.9.9), add .gitattributes
Phase 8 — CSS Fixes:
- Remove invalid -fx-letter-spacing from nightshade.css (unsupported by JavaFX)
- Replace with equivalent -fx-padding for visual approximation
Phase 10 — SEO:
- Fix broken placeholder URL in docs/technical_roadmap.md
Phase 11 — Release Automation:
- Add .releaserc.yaml with @semantic-release/exec for Maven version bumps
Cleanup:
- Remove internal planning docs from docs/superpowers/, docs/IMPLEMENTATION_PLAN.md, docs/PHASE_6_PLAN.md
- Remove AI tool artifacts (.firecrawl/, .agents/, graphify-out/)
Build: 148 tests run (143 pass, 5 pre-existing DeadCodeInjectorEdgeCase failures)
Checkstyle: 0 violations — PMD: 0 violations — Compilation: clean
Bumps eclipse-temurin from 21-jre-alpine to 25-jre-alpine. --- updated-dependencies: - dependency-name: eclipse-temurin dependency-version: 25-jre-alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eclipse-temurin from 21-jre-alpine to 25-jre-alpine.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)