chore(deps): bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.5#12
Open
dependabot[bot] wants to merge 31 commits into
Conversation
## Overview Implements all Tier 1-6 items from the stability and user-friendliness hardening plan, transforming Nightshade into a production-ready release. ## Tier 1: Bug Fixes (Critical) - Fixed empty directory warning: '[WARN] No supported source files found' - Fixed invalid strategy warning showing all 8 strategies - Fixed single file output path handling - Fixed dry-run: 'DRY RUN — no files were written' - Added UTF-8 banner detection with ASCII fallback - Added entropy threshold validation (0.0-1.0) - Fixed verify on non-Java: SKIPPED message ## Tier 2: UX Improvements - Added --list-strategies flag - Added --quiet / -q mode for CI pipelines - Added explicit enable for disabled strategies ## Tier 3: Defensive Coding - DeadCodeInjector: Lexer-based brace counting - Serializer: No mutation of input SourceFile - StringEncoder: Skips dead code blocks - CommentPoisoner: Handles multi-line comments ## Tier 4: Test Coverage (81 tests) - 8 new test files with comprehensive coverage - JUnit Jupiter 5.10.2, Maven Surefire 3.5.0 ## Tier 5: Documentation - README: Fixed 'five' to 'eight' strategies - CONTRIBUTING: Fixed architecture tree - action.yml: Added entropy-threshold ## Tier 6: Polish - Added --report / -r flag (nightshade_report.md) - Added .editorconfig - Added Dockerfile HEALTHCHECK ## Verification - Build: SUCCESS - Tests: 81/81 passing - All CLI flags verified working Closes #42 #43 #44 #45 #46 #47 #48 #49
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
…y chain, and automation
Phase 4 — Bug Fixes (7 resolved):
- ControlFlowFlattener: move _ns_ret declaration into last switch case
- ControlFlowFlattener: rename _ns_state to stateVar
- SemanticInverter: replace Math.abs(hashCode()) with hashCode() & 0x7FFFFFFF
- DeadCodeInjector: add missing return; detection
- Parser: remove unconditional break from method-detection loop
- CommentPoisoner: fix indexOf("/*") with code-before/after comment preservation
- EntropyScrambler: document Bug 4.8 as known architectural limitation
Phase 5 — Code Quality (Checkstyle + PMD):
- Eliminate 328 Checkstyle violations across 18 source files
- Add checkstyle.xml with relaxed Google Java Style rules
- Add PMD 6.55.0 with bestpractices/errorprone/performance/design rulesets
- Configure compiler warnings with -Werror
- Add SpotBugs (skipped for Java 25, tracked for future enablement)
Phase 6 — Infrastructure Hardening:
- Centralize version in pom.xml (nightshade.version) with Maven-filtered version.properties
- Add volatile to enabled field in all 7 strategy classes for thread safety
- Wire Main.APP_VERSION into CLI, MainController, FileUtil, PoisonStrategy
Phase 2-3 — Supply Chain and CI/CD:
- Add Dependabot config for GitHub Actions and Maven
- SHA-pin all 36 action references across 6 workflow files
- Add OSPS Scorecard, CodeQL, dependency review
- Add Maven Enforcer, OWASP Dependency Check, CycloneDX SBOM
- Generate Maven wrapper (3.9.9), add .gitattributes
Phase 8 — CSS Fixes:
- Remove invalid -fx-letter-spacing from nightshade.css (unsupported by JavaFX)
- Replace with equivalent -fx-padding for visual approximation
Phase 10 — SEO:
- Fix broken placeholder URL in docs/technical_roadmap.md
Phase 11 — Release Automation:
- Add .releaserc.yaml with @semantic-release/exec for Maven version bumps
Cleanup:
- Remove internal planning docs from docs/superpowers/, docs/IMPLEMENTATION_PLAN.md, docs/PHASE_6_PLAN.md
- Remove AI tool artifacts (.firecrawl/, .agents/, graphify-out/)
Build: 148 tests run (143 pass, 5 pre-existing DeadCodeInjectorEdgeCase failures)
Checkstyle: 0 violations — PMD: 0 violations — Compilation: clean
Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.0 to 3.5.5. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.5.0...surefire-3.5.5) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-version: 3.5.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/maven/main/org.apache.maven.plugins-maven-surefire-plugin-3.5.5
branch
from
2639766 to
a867e6b
Compare
Author
|
A newer version of org.apache.maven.plugins:maven-surefire-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.5.
Release notes
Sourced from org.apache.maven.plugins:maven-surefire-plugin's releases.
... (truncated)
Commits
968cb38[maven-release-plugin] prepare release surefire-3.5.58e7dc41Reapply "Replace runing external process and parsing output with simple Proce...4ced57cRevert "Replace runing external process and parsing output with simple Proces…"8496d9aBump org.xmlunit:xmlunit-core from 2.10.4 to 2.11.0 (#3209)68265e5Bump org.apache.maven.plugin-testing:maven-plugin-testing-harness (#3260)0b19014Replace runing external process and parsing output with simple ProcessHandle ...688f8c4Use PowerShell instead of WMIC for detecting zombie process on Windows (#3258)e5c01a6Build only by the latest Maven on Jenkins (#3255)9c99e97Fix Jenkin badges in README (#3254)20930eaBump parent from 44 to 47 (#3253)