Repository navigation
test: characterize plausible citation chip target mechanisms - #226
atlas-coding-agent wants to merge 2 commits into
Conversation
|
@kiro-agent is attempting to deploy a commit to the devhims' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Reviewed head daf7d92. Verdict: CHANGES NEEDED / validation blocked for overall readiness. The tests-only change is acceptable in its narrow scope; I found no blocking code defect. Overall approval is withheld because the Vercel authorization status is failed and I could not verify whether it is a required merge check. Confirm the required-check policy before treating this PR as merge-ready; this review does not authorize deployment. Re-review: the additional commit changes explanatory comments and a test name only. The description and platform/test/citation-target-consistency.test.ts:8–11 now correctly characterize plausible mechanisms instead of claiming a proven historical root cause. That wording concern is resolved. Coverage reviewed:
Verification:
Limits and user impact: these are synthetic characterization tests, not a citation fix. They do not prove the causal path of chess session 426fcd5f-11a8-4413-88bb-321f4112cd88 (runs 26f5171e-dff6-4311-bd83-fef6d3105498, 8a21338e-6f16-438e-9e44-935c4c3118c0, cb2e38b0-bc93-4e39-aa2c-423a006d5096) or watercolor session 6438cb12-c5c8-439e-b111-d604f02187a7 (run c52a03be-d51d-4899-832a-fcddb48e6dcb). Stored live citation IDs were not inspected here. JSON serialization is not a browser/database reload test. No fresh live dashboard tests were run. Existing window-start and nested-merge behavior remains unchanged, so do not close the live issue as fixed by this PR. Citation-policy implementation remains subject to the owner's approval. |
Problem / Motivation
Readers click a citation chip and land up to a minute before the moment the answer describes. The answer text sometimes names a third time. This draft adds tests that characterize plausible mechanisms for that. It does not establish the live root cause, and it does not fix it. It changes no product code.
Reported by the reporter on Oct 24 2026, 06:32 to 06:41 IST:
426fcd5f-11a8-4413-88bb-321f4112cd88, T126f5171e-dff6-4311-bd83-fef6d31054988a21338e-6f16-438e-9e44-935c4c3118c0t=58scb2e38b0-bc93-4e39-aa2c-423a006d50966438cb12-c5c8-439e-b111-d604f02187a7, T3c52a03be-d51d-4899-832a-fcddb48e6dcbPlausible mechanisms (not confirmed for these sessions)
The tests show two code paths that move a chip off the claimed moment. The chip label, href and stored citation still agree on every path tested.
The reported wrong times (0:58, 1:54, 5:38) are consistent with window starts. I did not inspect the stored citation IDs of these sessions, so this is timing arithmetic, not evidence of the cause. Nothing checks the times the model writes in prose. The model also never sees start times for analysis references. That makes the prose mismatch a possible model grounding issue, also unconfirmed.
What changed
Tests only, on synthetic captions at the reported times. They cover:
Tests
CI Verify passed on this PR. Local runs are blocked because the sandbox registry returns 403 for
zod@4.4.3andzod-to-json-schema@3.25.2. Base is upstream3d11c12.Decision pending
Preserving an exact caption when a broader cited window covers it needs owner approval. That approval has not been given. Model-input time metadata and range-format chips are not proposed here.