Repository navigation
fix: state page position and size on saved comment search hits - #225
Draft
atlas-coding-agent wants to merge 1 commit into
Draft
atlas-coding-agent wants to merge 1 commit into
atlas-coding-agent wants to merge 1 commit into
Conversation
|
@kiro-agent is attempting to deploy a commit to the devhims' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reported live on Oct 24 2026, 07:34 to 07:41 IST, in session https://www.video2ctx.dev/dashboard/sessions/51df11c5-33c4-4afd-af67-3896bda6340f for video
WUvTyaaNkzM. Two saved provider pages hold 20 + 20 distinct top-level comments.8b9c21b4-5887-4575-b8b7-829d01d2dd84COMMENT_PAGE_REMAININGe016d9e6-cc91-45fa-ba45-8c9111748a97c247c6b6-24d3-45aa-a1c1-adde360c5c68, after reloadThe saved pages were unchanged before and after reload. That proves the answer left rows out and put one in the wrong position. It does not prove which code path caused it.
I confirmed one deterministic defect. A saved comment returned by
search_contextcarried a false read receipt.readSavedCommentrecordedsavedPageCount: 1for a 20-row page, and search then dropped the artifact. So the model was told the page size "was not recorded" and that it was unknown whether more entries followed. The answer model seesref_Nlabels in place of positional IDs. With no receipt, row 15 and row 20 looked the same to it.What changed
pageVersion, and whether the provider reported a further page.Tests
I added two integration tests to
session-evidence.integration.test.ts:pageVersion, with no provider call.I could not run tests locally. This sandbox gets 403 from the npm registry, so
npm cifails. CI run 40066930218 passed all 8 jobs on this head, including Platform checks, wherenpm testruns these DO integration tests. The branch is based on3d11c12. I ran no live dashboard tests.Needs an owner decision, not fixed here
toolChoice: 'none', and only cited packets carry forward. A follow-up without a URL stays on finalize. The options are: (a) route saved-row follow-ups toinspect_video, (b) add a saved-page read to finalize, or (c) carry whole saved pages forward. Each one changes routing or cost. I recommend (a), because it reuses existingpageVersionreads, which are priced as session reuse.readCommentEvidenceis unused in production and omits the further-page flag. I left it alone.