fix(dvz-ui): fix reset filters to be enabled when filters change - #301
Merged
Merged
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The reset logic must handle cleared sentinel values when comparing against non-empty initial values.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes the filter reset button so it enables when filter values change.
Changes:
- Updates filter comparison logic.
- Adds a patch changeset.
| File | Summary |
|---|---|
packages/dvz-ui/src/embeddable/filter-reset-button/index.tsx |
Updates reset-button enablement; clearing a filter can still leave Reset disabled when initial values include a real default. |
.changeset/honest-ducks-spend.md |
Documents the patch release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
39
| return initialValues.length !== filteredApplied.length || | ||
| !initialValues.every(v => filteredApplied.includes(v)); |
ralvarez-dg
self-requested a review
September 25, 2026 15:49
ralvarez-dg
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses