Skip to content

fix(json-render-ui): clear action errors on retry - #416

Open
dvcolomban wants to merge 1 commit into
devframes:mainfrom
dvcolomban:dvcol/json-render-retry-error
Open

dvcolomban wants to merge 1 commit into
devframes:mainfrom
dvcolomban:dvcol/json-render-retry-error

Conversation

@dvcolomban

@dvcolomban dvcolomban commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Background

After a JSON action fails, its error alert remains visible after a successful retry. The action bridge stores the failure but never clears it.

Changes

Clear the stored error before retrying the same action. Other actions leave that error intact. A failed retry reports its new error, and a successful completion preserves any failure received while it was pending.

The change adds two runtime lines, updates the error property's JSDoc, and adds four regression tests.

@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
devframe Skipped Skipped Sep 30, 2026 9:22am UTC

@dvcolomban
dvcolomban marked this pull request as ready for review September 30, 2026 11:12
Copilot AI balanced review requested due to automatic review settings September 30, 2026 11:12
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 1 flow · 1 file · commit dc7b205


Architecture

Architecture diagram for devframes/devframe at dc7b205

1 component touched across 3 lanes.

Play the interactive walkthrough


Data flow

Data flow diagram for devframes/devframe at dc7b205

Retrying a failed action

Follow each request, response and payload


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Push a commit and the drawing stays, with a note that it is out of date. Tick Redraw in the note to draw the new head
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused implementation matches the described behavior and is thoroughly covered by regression tests.

Review effort: Balanced
Findings: None

What changed in this PR

Clears stale JSON action errors when the same action is retried while preserving unrelated or concurrent failures.

Changes:

  • Clear matching errors before retry execution.
  • Document the updated error lifecycle.
  • Add regression coverage for success, failure, and concurrent actions.
File Description
packages/​json-render-ui/​src/​action-bridge.ts Clears the retried action’s stored error.
packages/​json-render-ui/​test/​action-bridge.test.ts Covers retry and concurrent-error behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch was previously deployed

1 inactive deployment
Preview — dc7b205c Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants