fix(json-render-ui): clear action errors on retry - #416
dvcolomban wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
◈ PR Lens
Architecture 1 component touched across 3 lanes. Play the interactive walkthrough Data flow
Follow each request, response and payload View
Tip Add 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the described behavior and is thoroughly covered by regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Clears stale JSON action errors when the same action is retried while preserving unrelated or concurrent failures.
Changes:
- Clear matching errors before retry execution.
- Document the updated error lifecycle.
- Add regression coverage for success, failure, and concurrent actions.
| File | Description |
|---|---|
packages/json-render-ui/src/action-bridge.ts |
Clears the retried action’s stored error. |
packages/json-render-ui/test/action-bridge.test.ts |
Covers retry and concurrent-error behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Background
After a JSON action fails, its error alert remains visible after a successful retry. The action bridge stores the failure but never clears it.
Changes
Clear the stored error before retrying the same action. Other actions leave that error intact. A failed retry reports its new error, and a successful completion preserves any failure received while it was pending.
The change adds two runtime lines, updates the error property's JSDoc, and adds four regression tests.