fix(nuxt): generate nuxt module builder layout#13
Merged
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
userquin
commented
May 13, 2026
| "configKey": "devframe", | ||
| "version": "${version}", | ||
| "builder": { | ||
| "tsdown": "${devDependencies.tsdown}" |
Contributor
Author
There was a problem hiding this comment.
maybe we should remove the ^ if present
Contributor
Author
There was a problem hiding this comment.
I need to review the version, maybe we need to load pnpm workspace and find the tsdown version in the correspoding catalog
antfu
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following with #9, this PR includes:
@devframes/nuxtat nuxt module meta (renamed fromdevframe)defineNuxtModule:export type ModuleOptions = DevframeNuxtModuleOptionsexports: truefrom module build./dist/types.d.mtsfor types and global typesbaseURLuseRuntimeConfigmodule augmentationtests/__snapshots__/tsnapi/@devframes/nuxt/index.snapshot.d.tsNOTE: if we start adding some nuxt stuff in the module (module hooks...), maybe we'll need to switch to nuxt module builder.