feat(db): add db cluster logic and tests#338
Open
jimezesinachi wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Test Results337 tests 337 ✅ 20m 29s ⏱️ Results for commit 0f68992. ♻️ This comment has been updated with latest results. |
Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Benchmark Results |
deven96
reviewed
Jun 9, 2026
| client_handler: Arc<ClientHandler>, | ||
| task_manager: Arc<TaskManager>, | ||
| config: ServerConfig, | ||
| cluster: Option<ClusterRuntime>, |
Owner
There was a problem hiding this comment.
ClusterRuntime would ideally always contain store_handler.... and we typically only ever want to access store_handler directly independent of cluster if cluster doesn't exist? Seems like we should have a cleaner
enum StoreRuntime {
Standalone(StoreHandler), // perhaps a more befitting rename to handler/ runtime to be consistent
Cluster(ClusterRuntime),
}
Collaborator
Author
There was a problem hiding this comment.
Actually agree with this, I went in the direction of not changing the shape of Server, but this is the better direction long term
deven96
reviewed
Jun 9, 2026
| } | ||
|
|
||
| pub(crate) async fn list_stores_response( | ||
| cluster: Option<&ClusterRuntime>, |
Owner
There was a problem hiding this comment.
Not particularly sold on having optional cluster and a reference to store_handler when cluster always contains handler... see above comment
Collaborator
Author
There was a problem hiding this comment.
A'firm, I will change the shape now
deven96
reviewed
Jun 9, 2026
|
|
||
| fn task_manager(&self) -> Arc<TaskManager>; | ||
|
|
||
| fn should_spawn_persistence(&self) -> bool { |
Owner
There was a problem hiding this comment.
FIXME on this so we don't forget while implementing AI db cluster logic
deven96
reviewed
Jun 9, 2026
jimezesinachi
commented
Jun 9, 2026
…odes Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
deven96
reviewed
Jun 11, 2026
|
|
||
| fn apply(&mut self, data: &DbCommand) -> Result<DbResponse, StorageError<u64>> { | ||
| match data { | ||
| DbCommand::CreateStore(payload) => { |
Owner
There was a problem hiding this comment.
There's probably a nice way to turn decode_payload into a macro so we dont have to manually pass that string but can extract it from the ty via stringify!
Owner
There was a problem hiding this comment.
Something like
macro_rules! decode_payload {
($ty:ty, $payload:expr) => {{
<$ty>::decode($payload).map_err(|err| StorageError::IO {
source: StorageIOError::read_state_machine(&std::io::Error::other(format!(
"failed to decode {} raft payload: {}",
stringify!($ty),
err,
))),
})
}};
}
let params: query::CreateStore =
decode_payload!(query::CreateStore, payload)?;
deven96
reviewed
Jun 11, 2026
| use std::any::{Any, TypeId}; | ||
|
|
||
| pub(crate) fn map_client_write_error( | ||
| command_name: &str, |
Owner
There was a problem hiding this comment.
Another good use of macros to enforce not needing command name alongside the actual command
deven96
reviewed
Jun 11, 2026
| prost.workspace = true | ||
| openraft.workspace = true | ||
| ahnlich-replication = { path = "../replication", version = "*" } | ||
| bitcode = { version = "0.6", features = ["serde"] } |
Owner
There was a problem hiding this comment.
We should move to general Cargo.toml... my suspicion is we will reuse elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.