Repository navigation
fix(test): merge-two-features tests build their own merge - #1278
Merged
Merged
Conversation
Closes #1277. 'the other direction writes the same bytes' read bytes the previous test stored, so a randomized order left them empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1277.
the other direction writes the same bytescompared against bytes that the previous test stored in a shared variable. Whenflake-huntran the tests with--randomizeand this test ran first, it saw an empty array.Each test now builds its own merge through one helper,
merged(branch, ours, theirs). The file passes alone under seeds 3080077757, 2150480779, 1 and 2. That doesn't prove the fix, because the issue notes the cross-file order is lost. The fix is that no test reads another test's state.🤖 Generated with Claude Code