Repository navigation
fix(cli): cache.defaultTtlMs sets the lease on the rungs the boot builds - #1276
Merged
Merged
Conversation
Closes #1260. The key was validated and documented and read by nothing: buildTier now passes it to lruTier and redisTier. A rung supplied through runtime.ts's cacheTiers keeps its own default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code |
Contributor
There was a problem hiding this comment.
Review summary — 5 file(s), 0 finding(s).
Wires cache.defaultTtlMs into boot-built LRU and Redis tiers while preserving supplied tiers’ defaults, with regression tests and documentation. The Redis default lease changes from 300 seconds to the configured value; no concrete defects found in the provided diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1260.
cache.defaultTtlMswas validated at boot and documented, but nothing read it. This takes option 1 from the issue, because it breaks nothing.startCacheTierstakesdefaultTtlMs.runtime-services.tspassesconfig.cache.defaultTtlMs, andbuildTierhands it tolruTierandredisTier.runtime.ts'scacheTierskeeps its own default, because the replacement is the whole rung.ttlMsfor 300 s. It now uses the configured value, 60 s by default, which is what the docs say. CHANGELOG notes it.Tests: two cases in
runtime-cache-limits.test.ts. One checks that the configured lease is used; it fails without the fix, because it sees the tier's 60 s default. The other checks that a supplied rung keeps its own lease.bun run typecheckand biome are green. Local preflight was green exceptcoverage cli, which hit its 600 s local time limit with no verdict.🤖 Generated with Claude Code