Repository navigation
feat(cli): multi-agent developer experience - #1272
Merged
Merged
Conversation
Work from four DX workers on the 12 findings of the multi-agent audit: migration forks, merge drivers, runnable fix tails, worker-safe fixes, explained ledger waits, scaffold instructions, free port pairs, job registration paths, concurrent db gen wording, worker counts and test service stacks. Integration follow-ups land in later commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- x doctor reports another checkout's port in data.warnings; the sync role's port refusal walks to a free pair (freeDevPortPair). - preflight and the coverage gate kill the tree they started on a signal, so no orphan keeps its ledger reservation. - migrationFork moves to @ultimat3/db/schema-dump and is pinned as never-at-boot; the serving and web ceilings rise by the one module the sync refusal needs. - DoctorProbe's new members are optional, so the public API stays additive; the new codes and their fixes split out at the ceiling. - Ratchets back at their pins; the setup-commands rule scopes a mention inside a table row to that row. - Many-Agents states --merge-fork and the x db gen lock; CHANGELOG [Unreleased], an Upgrading row for 24 guard fixes, plan 101 status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- docs-many-agents and docs-worker-commands report a skip with the row to add when the table is reworded or missing, find it in AGENTS.md too, and skip with the byte count rather than push the brief over its agentsMdMaxBytes budget (agents-doc-row.ts). - x upgrade installs the merge drivers a hop's .gitattributes names, so the upgrade fixtures owe no X_MERGE_DRIVER_UNSET hand step. - dev-lock-free-port.ts becomes port-pair-free.ts: production reaches no dev-* module. - migrationFork has one home, @ultimat3/db/schema-dump. - Tests follow one registry entry per line and the setup driver step; file-scope reset hooks where a suite can skip; the repo-scan budget on fix-tails.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Fix failing CI on #1272
Working on it. |
- app-evals.test.ts writes its fixture apps under a fresh directory per pass: bun test --rerun-each keeps the module cache, so a second pass over the same paths registered no prompt. - The three test names the vanished-tests rule missed are kept on the cases that replaced them. - new-shapes.test.ts reads the dashboard's queries one entry per line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sebyx07
added a commit
that referenced
this pull request
Nov 19, 2026
…1273) Main went red on the merge of #1272 (ddcbe02) in two jobs that run only on a push to main: | Job | Cause | Fix | |---|---|---| | ci / deploy-proof | `docker/deploy-proof/held-job.sh` edited `defineApi` lists written on one line; `x new` now writes one entry per line | it inserts each module after the list's opening line; checked against a fresh `x new proofapp` | | tutorial-run | Tutorial 2 shows `✓ migration …_add_todos generated`; `x db gen` now adds ` — tables: todos` | the page shows the new line; `bun run scripts/tutorial-run.ts` ran green locally (20 steps) | 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
sebyx07
added a commit
that referenced
this pull request
Nov 19, 2026
Two problems seen on 2026-11-19. ## 1. `x upgrade` always ran the full gate On a loaded machine one app's hop took 55 minutes, with no way to hand `unit`, `live` and `e2e` to CI. | | | |---|---| | flag | `x upgrade --only <step>[,<step>…]`: the hop's last stage is `x verify --only <steps> --json` instead of `x verify --json` | | reader | `packages/cli/src/verify-only.ts`, the one `x verify --only` now uses too: same step list, same declared order, same refusals (`X_CLI_BAD_FLAG`, fix = the corrected `x upgrade --only …`) | | honest report | `proof: "verify-only"`, `verify.only[]`, `verify.notRun[]`, summary `… green on typecheck,lint only — NOT THE FULL GATE; not run: …`, a human line `not run by this hop … x verify --only <rest> --json`, and a `then` naming that command | | default | unchanged: no flag, or every step named, is the full gate and reports as one (`proof: "verify"`, no `only`/`notRun` keys) | | no app | refused: the hop runs scripts there, not `x verify`, so a list would narrow nothing | The earlier stages (codemods, manifest, doctor, guards, a Bun-floor hop's coverage rebaseline, exercise) run either way, because each one writes what the hop leaves behind. No template changes, so no codemod row. Docs: `wiki/CLI-Reference.md`, `wiki/Upgrading.md`, `CHANGELOG.md`. ## 2. Jobs that run only on `main` broke `main` after green PRs | Job | On a pull request now | |---|---| | `ci / deploy-proof` | runs when `scripts/deploy-proof-due.ts` finds a `VERDICT_PATHS` file in the PR diff (merge commit vs first parent, checkout depth 2), and skips its heavy steps otherwise. Inherits nothing; `main` still decides by the predecessor rule | | `tutorial-run.yml` | `pull_request.paths` = `push.paths`. The list gained `cmd-new*`, `cmd-db*`, `db-*`, `messages*` (#1272's break was `x db gen` output). Concurrency is grouped per ref, so main never cancels a PR's run | - `verify` is still the one verdict: neither job is in its `needs` and neither is required. A path-filtered workflow never leaves a check pending. - `scripts/ci-workflow-main-only.test.ts` enforces the rule. A workflow pushed on `main` with no `pull_request` trigger, or with different paths, fails the test unless it is a named publisher (`wiki.yml`, `scorecard.yml`). So does a `ci.yml` job whose `if` admits a push but not a PR. - `scripts/lib/health-tutorials.ts` reads `--branch main` only, so a PR's red tutorial run never counts against main's health. - `docs/history/ci-split.md` has a new dated section. ## Checks run locally - `bun test` on the upgrade, verify-only, deploy-proof-due, health, tutorial-run and ci-workflow* suites passed. - New tests fail against the old sources and workflows. - `bun run typecheck` passed. - `bun run verify --only typecheck,lint,boundaries,filesize,package-shape,errors,manifest` (through `x heavy run`) passed after the fixes. - actionlint and zizmor found nothing new. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An auditor used Ultimate the way parallel agents do: two clones of one app, merged branches, one shared machine. It found 12 problems. This PR fixes all 12, each with a test that failed first. Four workers wrote the fixes and one integrator merged them. Additive only: no breaking change ships on
main.The 12 findings
x db genwere merged, the gate suggestedx db gen 'record alphas'. That migration could never replay (42P07).X_MIGRATION_FORKED(@ultimat3/db,migration-fork*.ts).x db gen,x db migrateand thedriftstep check for it first.x db gen --merge-forkcorrects only the newest.snapshot.json. It changes no SQL and deletes nothing. When both branches create the same object, the fix says to runx db status --jsonon every database first.x g resourcebranches conflicted in 7 files. A union merge produced files that do not parse.x merge-driver(install / registry / catalog).bun run setupinstalls it (now 7 steps)..gitattributesmarks which driver each file uses. New apps write one registry entry per line. Existing apps get the change from themerge-driverscodemod.x doctorwarnsX_MERGE_DRIVER_UNSET. Many-Agents has a new "Merging two features" section.en.jsoncrashedx doctorwith a fix that pointed back at the doctor.x manifestblamed 23 modules instead of the catalog.X_MERGE_UNRESOLVED,X_CATALOG_UNPARSEABLE(names the file), andX_DOCTOR_PROBE_FAILED: a doctor check that throws becomes a finding instead of a crash.then: x verify. That command is not found, and if it ran it would start the whole gate.runnableFixnow rewritesthen: x/then x, and so do the stderr step pointer andx errors explain. 24 shipped guards now end with their own step (x verify --only boundaries). Newscripts/fix-tails.ts(X_FIX_TAIL_BARE,X_FIX_TAIL_WHOLE_RUN) holds the line.X_TEST_NO_FILESsuggestsx test --affected --dirty.X_TYPECHECK_FAILEDnames the file to edit andx verify --only typecheck. An unknown command whose nearest match istestorverifysuggests--helpinstead of the bare command.x heavy run --max-waitexits withX_HEAVY_WAIT_EXPIRED(75).x heavy statusshows the wrapper and command pids (wrapperAlive,childPids). "admission in progress" replaces-. A run also waits while the CPU is saturated and another run is admitted.CLAUDE.mdlists the worker commands./featureand/verifyskip the gate when the worker has a file set..claude/settings.jsonallowsbunx x heavyandbunx x stop. Existing apps get this from thedocs-worker-commandscodemod.x doctorred, and the suggested port could already be taken.freeDevPortPairreturns a pair that is free when asked. The holder's directory is in the cause. A port held by another checkout is a doctor warning, wired intodata.warnings. The sync role'sX_PORT_IN_USEuses the same free-pair search.X_JOB_UNREGISTEREDhid the job's file.at, and prints the complete import line.x db genruns at the same time in one checkout put one agent's table in the other's migration.db-genlock. The success line lists the tables. "No migration needed" names the migration that already records them.2 of 4 of 6 workerswas hard to read.ran 2 at once (peak), planned 3, or1 worker, one per file (plan: …).services: started/reused/shared <project>line.x clean --servicesstops the stack. A stack with the same name from a different app is refused withX_TEST_SERVICES_UNAVAILABLE.Fixed while integrating
bun run preflightorbun run coverageis stopped by a signal, it now kills every process it started (scripts/lib/stop-tree.ts, tagged throughULTIMATE_VERIFY_STEP). Before, the child coverage gate and itsbun testworkers kept running and kept the ledger reservation they inherited. A test reproduces the orphan and proves the fix.@ultimat3/db's barrel, so every role loaded three modules it never uses. It moved to@ultimat3/db/schema-dump, andserve-graph.test.tsnow lists the fork modules as never loaded at boot. The one remaining module,port-pair-free.ts(the sync role's free-pair fix), raisesSERVING_ROLE_CEILING1547 → 1548 andWEB_ROLE_CEILING1747 → 1748. That is the measured amount, and the reason is in each fixture.DoctorProbestays additive.portOwner,mergeStateandmergeDriverUnsetare optional, soscripts/lib/public-api.lock.jsonrecords no break.verify-services.ts), test typecheck (2 errors), test bare error, a fix line in a test that could not run, amkdtempin a test that runs git (nowtempTree), and a name that trippedX_TEST_PORT_PROBED(the CLI helper is nowfreeDevPortPair).docs-many-agentsreportedchanged: [], skipped: []when the conventions table had been reworded or lived inAGENTS.md. In one app it pushedCLAUDE.mdto 12,071 bytes, past the 12,000-byte cap (X_AGENTS_MD_TOO_LARGE). It anddocs-worker-commandsnow sharecodemods/agents-doc-row.ts. That helper looks inCLAUDE.md, thenAGENTS.md. When it cannot place the row, it reports the file as skipped with the exact row to add. Before writing, it checks the size against theagentsMdMaxBytesbudget and reports the byte count when the row would not fit. A test covers each case and failed on the old code.x upgradeinstalls the merge drivers a hop's.gitattributesnames, soupgrade-fixturesno longer countsX_MERGE_DRIVER_UNSETas a hand step.scripts/help.tsandPUBLISHING.md.Docs
Many-Agents (merging,
--merge-fork, thex db genlock), Migrations-And-Backfills, Testing, CI-Parallel-Gate, Tutorial-01, Upgrading (a row for the 24 guard fixes), the error-code pages, CHANGELOG[Unreleased], and plan 101status.yml.No release is cut here: the maintainer app releases this.
🤖 Generated with Claude Code