Skip to content

flake: scripts/framework-env.test.ts > the real tree > every literal env read in shipped source is listed, and nothing listed is stale #1267

Closed

Description

@github-actions

flake-hunt saw this fail in https://github.com/developerz-ai/ultimate/actions/runs/44443484119.

suite round seed
unit 1 4213420217
unit 2 2879767910
unit 3 3435136434

Replay each round in its order:

bun run x -- test unit --workers 4 --isolate -- --randomize --seed=4213420217
bun run x -- test unit --workers 4 --isolate -- --randomize --seed=2879767910
bun run x -- test unit --workers 4 --isolate -- --randomize --seed=3435136434

The file alone, same seed — order across files is lost, so green here is not a fix:

bun test ./scripts/framework-env.test.ts --randomize --seed=4213420217

What Bun printed:

+     "cause": "packages/cli/src/heavy-cores.ts:49 reads RAYON_NUM_THREADS from the environment and packages/core/src/framework-env.ts does not list it, so x doctor cannot tell an app that its own RAYON_NUM_THREADS collides with the framework's",
+     "code": "X_FRAMEWORK_ENV_UNREGISTERED",
+     "fix": "{ name: 'RAYON_NUM_THREADS', owner: '<package>', use: '<contract|switch|internal|host>' }   # an entry of FRAMEWORK_ENV in packages/core/src/framework-env.ts, beside its owning package's; then: bun run scripts/framework-env.ts --json",
+   },
+ ]

- Expected  - 1
+ Received  + 20

      at <anonymous> (/home/runner/work/ultimate/ultimate/scripts/framework-env.test.ts:105:29)

::error file=scripts/framework-env.test.ts,line=105,col=29,title=error: expect(received).toEqual(expected)::- []%0A+ [%0A+   {%0A+     "at": "packages/cli/src/cmd-heavy.ts:104",%0A+     "cause": "packages/cli/src/cmd-heavy.ts:104 reads PATH from the environment and packages/core/src/framework-env.ts does not list it, so x doctor cannot tell an app that its own PATH collides with the framework's",%0A+     "code": "X_FRAMEWORK_ENV_UNREGISTERED",%0A+     "fix": "{ name: 'PATH', owner: '<package>', use: '<contract|switch|internal|host>' }   # an entry of FRAMEWORK_ENV in packages/core/src/framework-env.ts, beside its owning package's; then: bun run scripts/framework-env.ts --json",%0A+   },%0A+   {%0A+     "at": "packages/cli/src/heavy-cores.ts:48",%0A+     "cause": "packages/cli/src/heavy-cores.ts:48 reads GOMAXPROCS from the environment and packages/core/src/framework-env.ts does not list it, so x doctor cannot tell an app that its own GOMAXPROCS collides with the framework's",%0A+     "code": "X_FRAMEWORK_ENV_UNREGISTERED",%0A+     "fix": "{ name: 'GOMAXPROCS', owner: '<package>', use: '<contract|switch|internal|host>' }   # an entry of FRAMEWORK_ENV in packages/core/src/framework-env.ts, beside its owning package's; then: bun run scripts/framework-env.ts --json",%0A+   },%0A+   {%0A+     "at": "packages/cli/src/heavy-cores.ts:49",%0A+     "cause": "packages/cli/src/heavy-cores.ts:49 reads RAYON_NUM_THREADS from the environment and packages/core/src/framework-env.ts does not list it, so x doctor cannot tell an app that its own RAYON_NUM_THREADS collides with the framework's",%0A+     "code": "X_FRAMEWORK_ENV_UNREGISTERED",%0A+     "fix": "{ name: 'RAYON_NUM_THREADS', owner: '<package>', use: '<contract|switch|internal|host>' }   # an entry of FRAMEWORK_ENV in packages/core/src/framework-env.ts, beside its owning package's; then: bun run scripts/framework-env.ts --json",%0A+   },%0A+ ]%0A%0A- Expected  - 1%0A+ Received  + 20%0A%0A      at <anonymous> (/home/runner/work/ultimate/ultimate/scripts/framework-env.test.ts:105:29)

Activity

  1. sebyx07 commented on Nov 19, 2026

    @sebyx07
    Contributor

    Fixed on main by a22539b (#1261), which carried later commits than the hunted a5733be.

    Cause: not order dependence: the heavy ledger read PATH, GOMAXPROCS and RAYON_NUM_THREADS, none listed in FRAMEWORK_ENV. The fix registers them as host variables owned by cli.

    Evidence

    • Restoring the a5733be version of packages/core/src/framework-env.ts on main makes this test fail again under --randomize --seed=4213420217. With main's version it passes.
    • The test passes on the current tip 0700715 under all three seeds from the failing hunt (4213420217, 2879767910, 3435136434), run file by file with CI=true.
    • Hunt 44447976868 on a22539b was green in all six rounds (unit and live, three fresh seeds each).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flake-hunta test flake-hunt.yml saw fail under a shuffled order

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions