You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CodeQL: pre-existing alerts surfaced on #1151 (ReDoS ×2, code construction ×11) #1152
CodeQL on #1151 (sweep 5) flagged 13 alerts in files that PR did not change. CodeQL says itself: "Alerts not introduced by this pull request might have been detected because the code changes were too large." They predate sweep 5; this issue tracks them for the audit round (plan 101b slice 20).
Severity
Rule
Site
high
js/polynomial-redos
packages/cli/src/error-contract.ts:58 — strings starting ${{ with many ${
high
js/polynomial-redos
packages/cli/src/templates/island.ts:201 — many /
medium
js/code-injection (code construction from an unsanitized value)
The "code construction" sites render a fix: or a hint as TypeScript text that is printed for a person or an agent to read, never evaluated. Each still needs an explicit verdict: escape it through tsLiteral/renderFixLiteral, or dismiss it with that reason. The two ReDoS sites take author-written source, but they should be linear regardless.
Also still open on main, older: js/resource-exhaustion (realtime/src/thundering-herd.ts), js/useless-regexp-character-escape (templates/scaffold-container*.ts), js/incomplete-url-substring-sanitization (storage/src/upload.ts), js/prototype-polluting-assignment (core/src/wire-dates.ts), js/incomplete-multi-character-sanitization (scripts/factory-names-declarations.ts, ui/src/catalog/parse-component.ts).
Qualified as a bug: pre-existing CodeQL alerts in shipped packages — 2 high js/polynomial-redos (CLI) and 11 medium js/code-injection at fix:/hint rendering sites (core, mcp, testing) — plus the older-on-main set. Each alert needs an explicit verdict, not silence.
Scope
g1 — CLI ReDoS.packages/cli/src/error-contract.ts:58 and packages/cli/src/templates/island.ts:201 become linear for adversarial many-${ and many-/ input; pathological-input tests pin it.
g2 — code construction. Every listed core/mcp/testing site renders through tsLiteral/renderFixLiteral (or an equivalent) or carries a recorded dismissal saying the text is printed, never evaluated.
g3 — older runtime alerts.realtime/src/thundering-herd.ts, templates/scaffold-container*.ts, storage/src/upload.ts, core/src/wire-dates.ts — fixed or explicitly dismissed with a concrete reason.
g4 — sanitization.scripts/factory-names-declarations.ts and ui/src/catalog/parse-component.ts handle nested/overlapping payloads, with tests.
Acceptance
All 13 sweep-5 alerts and every older-on-main alert carry a verdict: fixed, or dismissed with the reason recorded.
bun run verify passes; no stable X_* code or fix:-string semantics change.
The two ReDoS sites are covered by pathological-input tests.
Handing this to the fleet's triage next.
🤖 Posted by developerz.ai — an automated agent, not a human.
Handed over: this is filed for the fleet's triage, which will scope it and mint the coding tasks. Nothing has started yet — triage may still come back with a question here before work begins. The 13 sweep-5 alerts and the older-on-main set each still need their verdict (fix, or a recorded dismissal), so this stays open until that lands.
🤖 Posted by developerz.ai — an automated agent, not a human.
Activity
developerz-ai commentedon Nov 16, 2026
Qualified as a bug: pre-existing CodeQL alerts in shipped packages — 2 high
js/polynomial-redos(CLI) and 11 mediumjs/code-injectionatfix:/hint rendering sites (core, mcp, testing) — plus the older-on-main set. Each alert needs an explicit verdict, not silence.Scope
packages/cli/src/error-contract.ts:58andpackages/cli/src/templates/island.ts:201become linear for adversarial many-${and many-/input; pathological-input tests pin it.tsLiteral/renderFixLiteral(or an equivalent) or carries a recorded dismissal saying the text is printed, never evaluated.realtime/src/thundering-herd.ts,templates/scaffold-container*.ts,storage/src/upload.ts,core/src/wire-dates.ts— fixed or explicitly dismissed with a concrete reason.scripts/factory-names-declarations.tsandui/src/catalog/parse-component.tshandle nested/overlapping payloads, with tests.Acceptance
bun run verifypasses; no stableX_*code orfix:-string semantics change.Handing this to the fleet's triage next.
🤖 Posted by developerz.ai — an automated agent, not a human.
developerz-ai commentedon Nov 16, 2026
Handed over: this is filed for the fleet's triage, which will scope it and mint the coding tasks. Nothing has started yet — triage may still come back with a question here before work begins. The 13 sweep-5 alerts and the older-on-main set each still need their verdict (fix, or a recorded dismissal), so this stays open until that lands.
🤖 Posted by developerz.ai — an automated agent, not a human.
developerz-ai commentedon Nov 19, 2026
Tracking pull request #1261 for this issue.