Skip to content

fix: 4 MB package, faster renders in CI, honest critiques, model-first recipes - #60

Merged
sebyx07 merged 4 commits into
mainfrom
fix/final-sweep
Nov 19, 2026
Merged

sebyx07 merged 4 commits into
mainfrom
fix/final-sweep

Conversation

@sebyx07

@sebyx07 sebyx07 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Closes the items left open after 0.13.0.

npm package: 40.6 MB → 4.2 MB (D292)

  • Model recipes' generated outputs (recipes/*/neural/) stay in git. 0.13.0 shipped them without the concept images they need, so they never built from the package.
  • The pack step now enforces a budget: 5.3 MB packed, 16 MB unpacked, 1 MB per file, nothing under recipes/*/neural/.
  • From the package, ranger and human_head build their CPU tier with a notice. bear_hybrid, wolf_hybrid and dragon_hybrid are model-first and stop with one T3D_NEURAL_MISSING whose fix says to clone or copy (D294, D295). Before, they built a different creature that failed QA.

CI

  • A folder's shot, hero, blueprint and icon share one compile per asset and LOD (human_head 242 s → 88 s locally). 54 of 55 folders re-rendered byte-identical; wolf_hybrid was not re-rendered.
  • 18 cost-balanced shards. Predicted 4.3 minutes push → green; this PR's run is the measurement.

Critiques

  • All committed assets except wolf_hybrid re-judged from their current hero.png and sheet.png: no missing, stale, malformed or empty-fix critiques remain for them.
  • 412 criteria are honestly below the pass mark of 8 (mostly wear, far-LOD pops, flat materials). Malformed critiques had been hiding their scores. Each has a concrete fix note; the gate stays warn-only until 2027-01-15.

Other

  • A rigger's terminal stub bone no longer shifts leg joints one bone down (D293).
  • D253 (wolf_hybrid hip web) was retried with a regenerated mesh and three Blender variants; none passed, the folder is unchanged, and the catalogue row records what was learned. Still open.

🤖 Generated with Claude Code

sebyx07 and others added 2 commits November 19, 2026 03:58
…l-first recipes

- npm tarball 40.6 MB -> 4.2 MB: model outputs stay in git; size budget in pack
- bun run shots: one compile per asset and LOD shared by the four renders
  (byte-identical); CI rebalanced to 18 shards
- every committed critique re-judged from its current renders, with fix notes
- bear/wolf/dragon hybrids stop with one T3D_NEURAL_MISSING when the model
  output is absent; the message fits package users
- rigger stub bone no longer shifts leg joints (D293)
- D253 (wolf_hybrid hip web) retried and still open; findings recorded

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@developerz-ai

developerz-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

⏭️ Skipped: the pull request was merged or closed

developerz.ai skipped the review of this commit: the pull request was merged or closed.

This is not a verdict on the changes.

This review was skipped.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 47 file(s), 2 finding(s).

Critical 0 · Major 0 · Minor 2 · Nit 0

Adds bounded compile sharing for renders, package-size gates, required model chains and terminal-stub handling. The supplied code and tests support the behavior, but two new comments misstate model fallback contracts.

  • 76 noise file(s) auto-skipped (lockfiles/generated/vendored — re-include with path_filters)

Comment thread recipes/bear_hybrid/surface.ts Outdated
export const DROPPED: readonly string[] = ['trot', 'gallop'];

/** The imported game mesh with the rig it was built for, or null on any cache miss. */
/** The imported game mesh with the rig it was built for; null only with no cache provided. */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The “null only with no cache provided” contract is false during online cache filling, also at recipes/dragon_hybrid/surface.ts:45 and recipes/wolf_hybrid/surface.ts:45: required misses still return null there. Describe null for filling-cache misses as well as absent providers, reserving the throw guarantee for offline build caches.

Comment thread scripts/pack-budget.ts Outdated
Comment on lines +2 to +3
// no `recipes/*/neural/` model outputs (they stay in git; the shipped model recipes build their CPU
// tier without them). `tarEntries` reads paths and sizes straight from the .tgz bytes (ustar, GNU

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The header says shipped model recipes build their CPU tier without outputs, but bear_hybrid, wolf_hybrid and dragon_hybrid now throw T3D_NEURAL_MISSING through an offline cache. Qualify the fallback claim to ranger and human_head and state that required model recipes stop instead.

@developerz-ai

developerz-ai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Address review findings on #60

Working on it.


sebyx07 and others added 2 commits November 19, 2026 04:15
Costs are run 44492321426's GitHub seconds (recipe-costs.ts --from-run);
18 shards rebalanced to about 222 s each. Doc comments on the model-first
hybrids and the pack budget corrected.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@sebyx07
sebyx07 merged commit efe831d into main Nov 19, 2026
21 checks passed
@sebyx07
sebyx07 deleted the fix/final-sweep branch November 19, 2026 09:27
@sebyx07 sebyx07 mentioned this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant