Repository navigation
fix: 4 MB package, faster renders in CI, honest critiques, model-first recipes - #60
Conversation
…l-first recipes - npm tarball 40.6 MB -> 4.2 MB: model outputs stay in git; size budget in pack - bun run shots: one compile per asset and LOD shared by the four renders (byte-identical); CI rebalanced to 18 shards - every committed critique re-judged from its current renders, with fix notes - bear/wolf/dragon hybrids stop with one T3D_NEURAL_MISSING when the model output is absent; the message fits package users - rigger stub bone no longer shifts leg joints (D293) - D253 (wolf_hybrid hip web) retried and still open; findings recorded Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
⏭️ Skipped: the pull request was merged or closeddeveloperz.ai skipped the review of this commit: the pull request was merged or closed. This is not a verdict on the changes. This review was skipped. |
There was a problem hiding this comment.
Review summary — 47 file(s), 2 finding(s).
Critical 0 · Major 0 · Minor 2 · Nit 0
Adds bounded compile sharing for renders, package-size gates, required model chains and terminal-stub handling. The supplied code and tests support the behavior, but two new comments misstate model fallback contracts.
- 76 noise file(s) auto-skipped (lockfiles/generated/vendored — re-include with path_filters)
| export const DROPPED: readonly string[] = ['trot', 'gallop']; | ||
|
|
||
| /** The imported game mesh with the rig it was built for, or null on any cache miss. */ | ||
| /** The imported game mesh with the rig it was built for; null only with no cache provided. */ |
There was a problem hiding this comment.
minor · docs The “null only with no cache provided” contract is false during online cache filling, also at recipes/dragon_hybrid/surface.ts:45 and recipes/wolf_hybrid/surface.ts:45: required misses still return null there. Describe null for filling-cache misses as well as absent providers, reserving the throw guarantee for offline build caches.
| // no `recipes/*/neural/` model outputs (they stay in git; the shipped model recipes build their CPU | ||
| // tier without them). `tarEntries` reads paths and sizes straight from the .tgz bytes (ustar, GNU |
There was a problem hiding this comment.
minor · docs The header says shipped model recipes build their CPU tier without outputs, but bear_hybrid, wolf_hybrid and dragon_hybrid now throw T3D_NEURAL_MISSING through an offline cache. Qualify the fallback claim to ranger and human_head and state that required model recipes stop instead.
|
Address review findings on #60
Working on it. |
Costs are run 44492321426's GitHub seconds (recipe-costs.ts --from-run); 18 shards rebalanced to about 222 s each. Doc comments on the model-first hybrids and the pack budget corrected. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Closes the items left open after 0.13.0.
npm package: 40.6 MB → 4.2 MB (D292)
recipes/*/neural/) stay in git. 0.13.0 shipped them without the concept images they need, so they never built from the package.packstep now enforces a budget: 5.3 MB packed, 16 MB unpacked, 1 MB per file, nothing underrecipes/*/neural/.rangerandhuman_headbuild their CPU tier with a notice.bear_hybrid,wolf_hybridanddragon_hybridare model-first and stop with oneT3D_NEURAL_MISSINGwhose fix says to clone or copy (D294, D295). Before, they built a different creature that failed QA.CI
shot,hero,blueprintandiconshare one compile per asset and LOD (human_head242 s → 88 s locally). 54 of 55 folders re-rendered byte-identical;wolf_hybridwas not re-rendered.Critiques
wolf_hybridre-judged from their currenthero.pngandsheet.png: no missing, stale, malformed or empty-fix critiques remain for them.Other
wolf_hybridhip web) was retried with a regenerated mesh and three Blender variants; none passed, the folder is unchanged, and the catalogue row records what was learned. Still open.🤖 Generated with Claude Code