Skip to content

chore(dz): fill the reviewer prompt with this repo's rules - #40

Merged
sebyx07 merged 1 commit into
mainfrom
dz/fill-reviewer-prompt
Nov 19, 2026
Merged

sebyx07 merged 1 commit into
mainfrom
dz/fill-reviewer-prompt

Conversation

@sebyx07

@sebyx07 sebyx07 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

What

Replace the onboarding-floor .dz/maintainer/reviewer.md with this repository's real review rules: what to reject, the gates that prove a PR, and what never to flag.

Why

The reviewer prompt still carried TODO(setup) in every section, so every review of this repo ran on no repo-specific rules.

Changes

  • .dz/maintainer/reviewer.md: rules distilled from AGENTS.md, .github/workflows/ci.yml, bin/check, .github/pull_request_template.md, .coderabbit.yml, apps/fast-rspec/.rubocop.yml and the gemspec (drop-in compatibility, zero runtime dependencies, native/pure parity, fork safety and determinism, real-service tests, measured claims, the public-tree guard, release-by-version-bump). Every rule cites the repo path it comes from, and every cited path exists. 7,019 characters, under the 12,000 cap.

Verification

  • dz-contract grade: before 1 finding (reviewer prompt still carrying TODO(setup) slots), after 0 findings (exit 0).
  • bin/check-public-tree clean on the new tree.
  • Markdown-only change; no code path touched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@developerz-ai

developerz-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 0 finding(s).

Replaces reviewer setup placeholders with repository-specific compatibility, safety, testing, release, and CI rules. This documentation-only diff shows no concrete merge-blocking defect in the supplied context.

  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

@sebyx07
sebyx07 merged commit 6d897c0 into main Nov 19, 2026
9 checks passed
@sebyx07
sebyx07 deleted the dz/fill-reviewer-prompt branch November 19, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant