Skip to content
This repository was archived by the owner on Nov 10, 2026. It is now read-only.

refactor: delete dead _format_pr_comments formatter - #205

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/delete-the-dead-format-pr-comments-formatter--a2b402fa
Nov 10, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/delete-the-dead-format-pr-comments-formatter--a2b402fa

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What

The GraphQL review-thread formatter _format_pr_comments had no call site
anywhere in the codebase or tests. Remove its definition
(client_pr_helpers.py:408-434), its all entry
(client_pr_helpers.py:477), and the backward-compat re-export import and
all entry in client_pr.py (lines 17 and 317) as one atomic change —
ruff selects pyflakes (F822), so the definition and the exports must go
together. The five live siblings (_get_comment_resolved_map,
_build_pr_status_query, _parse_pr_status_response, _parse_check_contexts,
_format_pr_comments_from_rest) are unchanged. CHANGELOG Unreleased gains
a Removed note.

Acceptance

  • Repo-wide grep for _format_pr_comments matches only historical CHANGELOG prose and the cli.py comment naming _format_pr_comments_from_rest — no definition, all entry, or import of _format_pr_comments remains in src/
  • _format_pr_comments_from_rest, _get_comment_resolved_map, _build_pr_status_query, _parse_pr_status_response and _parse_check_contexts remain defined in client_pr_helpers.py and listed in both module all lists (client_pr_helpers.py:472-478 → 5 entries, client_pr.py:309-319 → 8 entries)
  • uv run ruff check src/claude_task_master/github/client_pr.py src/claude_task_master/github/client_pr_helpers.py is clean (F/F822 selected via pyproject.toml:115)
  • CHANGELOG.md Unreleased has a Removed note for _format_pr_comments and all historical entries are byte-identical
  • bin/check is green (harness full gate)

Changes

  • src/claude_task_master/github/client_pr_helpers.py (edit) — Delete the dead GraphQL formatter _format_pr_comments (lines 408-434, keeping exactly two blank lines before _format_pr_comments_from_rest at 437) and drop "_format_pr_comments", from all (line 477). The five sibling helpers (lines 13, 97, 226, 370, 437) are untouched.
  • src/claude_task_master/github/client_pr.py (edit) — Remove _format_pr_comments, from the client_pr_helpers import block (line 17) and "_format_pr_comments", from all (line 317). Keep the block's # noqa: F401 — re-exported for backward compat comment and all five sibling names; the live calls at lines 118, 149, 303, 306 are untouched.
  • CHANGELOG.md (edit) — Add one bullet under the existing Unreleased '### Removed' section (after the get_context_window entry, line 12): the dead _format_pr_comments GraphQL formatter (github/client_pr_helpers.py) was removed — no call site anywhere; removed together with both all entries and the client_pr backward-compat re-export. Historical release notes below are NOT edited.

Verification

./bin/check passed (exit 0) in 3m 19s.

What the editors ran to see the change working, and what they saw:

  • uv run ruff check src/claude_task_master/github/client_pr.py src/claude_task_master/github/client_pr_helpers.py (github): EXIT=0 — All checks passed! (F selected via pyproject.toml:115, so F822 would fail on any leftover all entry/import of the deleted name; proves the three removals landed atomically)
  • grep _format_pr_comments over src/claude_task_master/github/client_pr*.py (github): only _format_pr_comments_from_rest remains: client_pr.py:17 (import), :305 (live call), :316 (all); client_pr_helpers.py:408 (def), :448 (all) — no bare _format_pr_comments token left

Part 3/4 of goal rtk_9f27cc6e57494e1aa71249859e371c59


🤖 Opened by developerz.ai for task tsk_a2b402fa733df2802883bdbd46e33a72 on developerz-ai/claude-task-master.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model glm-5.3-flash on api.z.ai via native, funded by account_key
Ran on box hv-dedicated-reviewer-1
Cost ~$0.04 for 266.8k in / 21.5k out (estimate: list price x reported tokens, cached input at its cached rate)
Run timeline run_15db90b89057460cb959e5caa13dfb2c
Part 3/4 of plan rtk_9f27cc6e57494e1aa71249859e371c59

The GraphQL review-thread formatter _format_pr_comments had no call site
anywhere in the codebase or tests. Remove its definition
(client_pr_helpers.py:408-434), its __all__ entry
(client_pr_helpers.py:477), and the backward-compat re-export import and
__all__ entry in client_pr.py (lines 17 and 317) as one atomic change —
ruff selects pyflakes (F822), so the definition and the exports must go
together. The five live siblings (_get_comment_resolved_map,
_build_pr_status_query, _parse_pr_status_response, _parse_check_contexts,
_format_pr_comments_from_rest) are unchanged. CHANGELOG Unreleased gains
a Removed note.

Dz-Task-Id: tsk_a2b402fa733df2802883bdbd46e33a72
@developerz-ai

developerz-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Delete the dead _format_pr_comments formatter

Work landed on #205 — watching it toward merge.

38m · 36 tool calls · 5 messages

Sessions: coding run


🤖 developerz.ai, an automated agent, not a human — hv-dedicated-reviewer-1 (developerz-ai[bot]) · model glm-5.3-flash on api.z.ai

@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:glm-5.3-flash developerz.ai: model that wrote this bot PR. dz/provider:api.z.ai developerz.ai: provider that served this bot PR. labels Nov 10, 2026
@developerz-ai

developerz-ai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 40s wall clock · gpt-6.1-sol via custom · 1 model call(s) · 109 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 3 file(s), 0 finding(s).

Completed review removes the unused GraphQL formatter and its imports/exports atomically, preserving the live REST formatter and sibling helpers. No concrete defects found in the supplied diff.

  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by custom/gpt-6.1-sol on box hv-dedicated-ci-0 — 25.9k in / 109 out over 1 call, on your flat-rate plan: no per-token charge (~$0.05 at OpenRouter list rates).

@developerz-ai
developerz-ai Bot merged commit 791c316 into main Nov 10, 2026
4 checks passed
@developerz-ai
developerz-ai Bot deleted the dz/delete-the-dead-format-pr-comments-formatter--a2b402fa branch November 10, 2026 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:glm-5.3-flash developerz.ai: model that wrote this bot PR. dz/provider:api.z.ai developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants