Repository navigation
refactor: delete dead _format_pr_comments formatter - #205
developerz-ai[bot] merged 1 commit into
Conversation
The GraphQL review-thread formatter _format_pr_comments had no call site anywhere in the codebase or tests. Remove its definition (client_pr_helpers.py:408-434), its __all__ entry (client_pr_helpers.py:477), and the backward-compat re-export import and __all__ entry in client_pr.py (lines 17 and 317) as one atomic change — ruff selects pyflakes (F822), so the definition and the exports must go together. The five live siblings (_get_comment_resolved_map, _build_pr_status_query, _parse_pr_status_response, _parse_check_contexts, _format_pr_comments_from_rest) are unchanged. CHANGELOG Unreleased gains a Removed note. Dz-Task-Id: tsk_a2b402fa733df2802883bdbd46e33a72
|
Delete the dead _format_pr_comments formatter
Work landed on #205 — watching it toward merge. 38m · 36 tool calls · 5 messages Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-reviewer-1 (developerz-ai[bot]) · model |
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 40s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 3 file(s), 0 finding(s).
Completed review removes the unused GraphQL formatter and its imports/exports atomically, preserving the live REST formatter and sibling helpers. No concrete defects found in the supplied diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by custom/gpt-6.1-sol on box hv-dedicated-ci-0 — 25.9k in / 109 out over 1 call, on your flat-rate plan: no per-token charge (~$0.05 at OpenRouter list rates).
What
The GraphQL review-thread formatter _format_pr_comments had no call site
anywhere in the codebase or tests. Remove its definition
(client_pr_helpers.py:408-434), its all entry
(client_pr_helpers.py:477), and the backward-compat re-export import and
all entry in client_pr.py (lines 17 and 317) as one atomic change —
ruff selects pyflakes (F822), so the definition and the exports must go
together. The five live siblings (_get_comment_resolved_map,
_build_pr_status_query, _parse_pr_status_response, _parse_check_contexts,
_format_pr_comments_from_rest) are unchanged. CHANGELOG Unreleased gains
a Removed note.
Acceptance
Changes
src/claude_task_master/github/client_pr_helpers.py(edit) — Delete the dead GraphQL formatter _format_pr_comments (lines 408-434, keeping exactly two blank lines before _format_pr_comments_from_rest at 437) and drop "_format_pr_comments", from all (line 477). The five sibling helpers (lines 13, 97, 226, 370, 437) are untouched.src/claude_task_master/github/client_pr.py(edit) — Remove _format_pr_comments, from the client_pr_helpers import block (line 17) and "_format_pr_comments", from all (line 317). Keep the block's# noqa: F401 — re-exported for backward compatcomment and all five sibling names; the live calls at lines 118, 149, 303, 306 are untouched.CHANGELOG.md(edit) — Add one bullet under the existing Unreleased '### Removed' section (after the get_context_window entry, line 12): the dead _format_pr_comments GraphQL formatter (github/client_pr_helpers.py) was removed — no call site anywhere; removed together with both all entries and the client_pr backward-compat re-export. Historical release notes below are NOT edited.Verification
./bin/checkpassed (exit 0) in 3m 19s.What the editors ran to see the change working, and what they saw:
uv run ruff check src/claude_task_master/github/client_pr.py src/claude_task_master/github/client_pr_helpers.py(github): EXIT=0 — All checks passed! (F selected via pyproject.toml:115, so F822 would fail on any leftover all entry/import of the deleted name; proves the three removals landed atomically)grep _format_pr_comments over src/claude_task_master/github/client_pr*.py(github): only _format_pr_comments_from_rest remains: client_pr.py:17 (import), :305 (live call), :316 (all); client_pr_helpers.py:408 (def), :448 (all) — no bare _format_pr_comments token leftPart 3/4 of goal
rtk_9f27cc6e57494e1aa71249859e371c59🤖 Opened by developerz.ai for task
tsk_a2b402fa733df2802883bdbd46e33a72on developerz-ai/claude-task-master.Raised automatically by the
raw_task_triagelane.