Repository navigation
fix: list all supported model overrides in config env help - #203
developerz-ai[bot] merged 2 commits into
Conversation
Dz-Task-Id: tsk_0b39fea6c7f8a90c5e86acaaadcb2efa
|
List CLAUDETM_MODEL_FABLE and CLAUDETM_MODEL_SONNET_1M in
Work landed on #203 — watching it toward merge. 13m · 17 tool calls · 3 messages Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-dev-marshall (developerz-ai[bot]) · model |
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 32s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 2 file(s), 0 finding(s).
Completed review Adds Fable and Sonnet 1M to config environment help and checks rendered model mappings against the loader registry. No merge-blocking defects found in the supplied diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by custom/gpt-6.1-sol on box hv-dedicated-6 — 46.4k in / 252 out over 2 calls, on your flat-rate plan: no per-token charge (~$0.10 at OpenRouter list rates).
There was a problem hiding this comment.
Review summary — 2 file(s), 0 finding(s).
Completed review Adds Fable and Sonnet 1M overrides to config environment help and checks rendered model mappings against the loader mappings. No blocking defects found in the supplied diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by custom/gpt-6.1-sol on box hv-dedicated-reviewer-1 — 46.9k in / 237 out over 2 calls, on your flat-rate plan: no per-token charge (~$0.10 at OpenRouter list rates).
Acceptance
Changes
tests/cli/test_config_commands.py(edit) — Strengthen test_config_show_env_no_overrides: clear every ENV_VAR_MAPPINGS key, invoke config show --env with a wide test console, and assert the rendered model variable names and config paths match the loader mappings filtered by CLAUDETM_MODEL_. Replace the stale manual clearing list; the test must fail before the table fix.src/claude_task_master/cli_commands/config.py(edit) — Add available-variable table rows for CLAUDETM_MODEL_FABLE → models.fable and CLAUDETM_MODEL_SONNET_1M → models.sonnet_1m, with model-name descriptions. Preserve the current no-overrides/active-overrides branches and secret masking; no loader or API changes.Verification
./bin/checkpassed (exit 0) in 9m 09s.What the editors ran to see the change working, and what they saw:
uv run pytest tests/cli/test_config_commands.py -q(config-env): Before table fix: 5 failed, 27 passed. Strengthened regression reported missing CLAUDETM_MODEL_FABLE → models.fable and CLAUDETM_MODEL_SONNET_1M → models.sonnet_1m. Four unrelated TestConfigPath failures showed Rich wrapping .claude-task-master across lines.uv run pytest tests/cli/test_config_commands.py -q(config-env): After table fix: 4 failed, 28 passed. Model-mapping regression, active-override tests, and secret-masking tests passed. Remaining failures: test_config_path_shows_path, test_config_path_output_is_pipeable, test_config_path_check_file_exists, test_config_path_check_file_not_exists; output contained '.claude-task\n-master/config.json'. Exit 1; full gate not run.Notes
Premises of the request the team disproved:
Part 7/7 of goal
rtk_3f7461e0031b4617af6a313e24e563cc🤖 Opened by developerz.ai for task
tsk_0b39fea6c7f8a90c5e86acaaadcb2efaon developerz-ai/claude-task-master.Raised automatically by the
raw_task_triagelane.