Repository navigation
docs: describe plan_repo planning tools as config.tools.planning - #202
Conversation
The repo-plan endpoint docs named two conflicting hard-coded lists
(Read, Glob, Grep vs Read, Glob, Grep, Bash). The real list comes from
config.tools.planning via get_tools_for_phase('planning'). All five sites
now say so instead of hard-coding a list.
Dz-Task-Id: tsk_1a500a911a427cb0273167dfc07eb704
|
Describe the repo-plan endpoint's planning tools as the configured planning list
Work landed on #202 — watching it toward merge. 45m · 59 tool calls · 1 message Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-ci-0 (developerz-ai[bot]) · model |
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 24s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 6 file(s), 0 finding(s).
Completed review planning-tool documentation now consistently points to config.tools.planning and aligns the documented defaults. Documentation-only changes; no blocking defects found in the supplied diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by custom/gpt-6.1-sol on box hv-dedicated-6 — 33.2k in / 117 out over 1 call, on your flat-rate plan: no per-token charge (~$0.07 at OpenRouter list rates).
What
The repo-plan endpoint docs named two conflicting hard-coded lists
(Read, Glob, Grep vs Read, Glob, Grep, Bash). The real list comes from
config.tools.planning via get_tools_for_phase('planning'). All five sites
now say so instead of hard-coding a list.
Acceptance
Changes
src/claude_task_master/api/models_repo.py(edit) — PlanRepoRequest docstring (lines 122-124): replace hard-coded '(Read, Glob, Grep)' with wording that the read-only planning tools come from config.tools.planning (via get_tools_for_phase('planning')). Docstring only; keep lines <=100 cols.src/claude_task_master/api/routes_repo.py(edit) — post_plan_repo docstring (line 275): replace '(Read, Glob, Grep)' with 'the planning tools configured in config.tools.planning'. Also optionally align the summary description string at line 267 ('Uses read-only tools') to mention the configured planning tools. Text only.src/claude_task_master/mcp/server.py(edit) — plan_repo tool docstring (lines 263-264): replace '(Read, Glob, Grep)' with the planning tools configured in config.tools.planning (get_tools_for_phase('planning')). Docstring is the MCP tool description; keep it plain text.src/claude_task_master/mcp/tool_handlers_repo.py(edit) — plan_repo handler docstring (lines 313-314): replace '(Read, Glob, Grep, Bash)' with the planning tools configured in config.tools.planning (get_tools_for_phase('planning')). Use the same phrasing as mcp/server.py.docs/mcp-tools.md(edit) — Line 654: replace 'read-only tools (Read, Glob, Grep, Bash)' with 'the planning tools configured inconfig.tools.planning(default: Read, Glob, Grep, WebFetch, WebSearch)'. Default per core/config.py:168-171. Must match phrasing used in the MCP docstrings.docs/repo-setup.md(edit) — [docs] Lines 265 and 271-276 describe the same repo-plan endpoint with a hard-coded 'read-only tools (Read, Glob, Grep, Bash)' list and a 'Read-Only Tools Used' list that includes Bash. docs/mcp-tools.md:654 now says the tools come from config.tools.planning (default Read, Glob, Grep, WebFetch, WebSearch), so a reader sees two conflicting lists. Reword line 265 to say it uses the planning tools configured inconfig.tools.planning. Retitle the list at 271-276 as the default planning tools: Read, Glob, Grep, WebFetch, WebSearch. Drop the Bash bullet and add WebFetch and WebSearch bullets.Verification
./bin/checkpassed (exit 0) in 7m 18s.What the editors ran to see the change working, and what they saw:
python verify_docs_links.py(docs): All 299 links verified successfully!uv run ruff check on both files, then uv run pytest tests/mcp -q --no-cov(mcp): Ruff: All checks passed. Pytest: 1 failed, 247 passed. The failed test changed between runs (first test_setup_repo_nodejs_project, then test_setup_repo_with_multiple_project_types), both in test_tools_repo_setup.py. The trace ends in selectors.py:398: Failed, which looks like a timeout in the setup-repo tests. I did not diagnose it. A rerun of test_setup_repo_nodejs_project on its own printed no Failed, Timeout or Error lines.uv run ruff check on both files(api): All checks passed!uv run pytest tests/api -q -p no:cacheprovider --no-cov (the scoped command)(api): Not green as run. The 2s per-test timeout fired on cold imports: first run stopped after 1 failure, the second showed '207 passed, 40 errors'.uv run pytest tests/api -q -p no:cacheprovider --no-cov --timeout=60(api): 247 passed in 52.65s. The edits are docstring and description text only.Part 2/7 of goal
rtk_3f7461e0031b4617af6a313e24e563cc🤖 Opened by developerz.ai for task
tsk_1a500a911a427cb0273167dfc07eb704on developerz-ai/claude-task-master.Raised automatically by the
raw_task_triagelane.