Skip to content

chore(release): bump to 0.0.57 and refuse a release before it builds - #421

Merged
dinndev2 merged 1 commit into
mainfrom
chore/release-preflight
Nov 14, 2026
Merged

dinndev2 merged 1 commit into
mainfrom
chore/release-preflight

Conversation

@dinndev2

Copy link
Copy Markdown
Contributor

What

main could never ship. Both manifests carried 0.0.56, the version already on npm, and npm refuses a version that exists, at the very end of the release. Nothing caught it earlier: the release workflow had no check at all before npm publish, and its workflow_dispatch could publish from any branch.

  • Bump: both packages now read 0.0.57, with aitm's exact pin on ai-claude-compat and bun.lock (three lines) moving with them. main is publishable as soon as this merges.

  • bin/release-preflight, run by release.yml before it installs or builds anything. It refuses, and says which reason:

    • the packages out of lockstep, or aitm's pin not their version;
    • a release tag that is not v<version>;
    • a commit that is not on main (the checkout now uses fetch-depth: 0 so origin/main is there);
    • either package already on npm at that version.

    Anything but a clear E404 from the registry is a refusal too, so a registry outage can't wave a release through.

  • PUBLISHING.md says where the bump happens: it is the first step of every release, in a PR to main, and the release is a GitHub Release tagged v<version> on main. It also documents the preflight and how to run it locally.

  • CLAUDE.md: the Packages row no longer hard-codes a version that goes stale, and bin/release-preflight has a row in the commands table.

The acceptance item "the published package and the tree it was cut from declare the same dependency versions" is met by the next release cut from main. Cutting it is a maintainer step, outside this PR.

Verification

  • release-preflight.test.ts: 10/10 under Node and Bun. It runs the real script in a throwaway repo with a stub npm (published, missing and unreachable registry) and covers the pass, the tag pass, and all six refusals. It also pins the real tree (manifests in lockstep, pin matching) and the workflow (the preflight runs before the npm publish step, with full history).
  • Red first, against the real registry: the script on today's main refuses with @developerz.ai/ai-claude-compat@0.0.56 is already on npm, and npm versions are immutable: bump both package.json files first. On this branch's commit it refuses the commit being released is not on main, as it should until merge.
  • Mutations: making the registry check fail open fails refuses when the registry cannot be asked. Deleting the workflow step fails runs the preflight before it publishes anything.
  • bun install --frozen-lockfile clean. actionlint clean on release.yml. bun run lint and typecheck:tests clean. Integration suite: 84 pass, 0 fail, 5 skipped (the e2e smoke tests need secrets).

Closes #401

🤖 Generated with Claude Code

Both manifests carried 0.0.56, the version already on npm, so every publish
from main was refused at the registry. They now read 0.0.57 (aitm's pin and
bun.lock with them). release.yml runs bin/release-preflight before it builds:
it refuses packages out of lockstep, a pin that is not the version, a tag that
is not v<version>, a commit not on main, or a version already on npm, and fails
closed when the registry cannot be asked. PUBLISHING.md says the bump is the
first step of every release, and release-preflight.test.ts runs the script
against a stub registry.

Closes #401

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@developerz-ai

developerz-ai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

✅ Reviewed — nothing survived verification

0 actionable comment(s) · 2 refuted by verification · grounded on your code

⚠️ 1 config note(s): 1 noise file(s) auto-skipped (lockfiles/generated/vendored — re-include with path_filters)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 7 file(s), 0 finding(s).

  • 1 noise file(s) auto-skipped (lockfiles/generated/vendored — re-include with path_filters)

🤖 developerz.ai review — automated, running on your model and your box. What is this?

@dinndev2
dinndev2 merged commit 19f0390 into main Nov 14, 2026
5 checks passed
@dinndev2
dinndev2 deleted the chore/release-preflight branch November 14, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(release): the manifests carry the published version, so main can never be published

1 participant