Repository navigation
chore(release): bump to 0.0.57 and refuse a release before it builds - #421
Merged
Merged
Conversation
Both manifests carried 0.0.56, the version already on npm, so every publish from main was refused at the registry. They now read 0.0.57 (aitm's pin and bun.lock with them). release.yml runs bin/release-preflight before it builds: it refuses packages out of lockstep, a pin that is not the version, a tag that is not v<version>, a commit not on main, or a version already on npm, and fails closed when the registry cannot be asked. PUBLISHING.md says the bump is the first step of every release, and release-preflight.test.ts runs the script against a stub registry. Closes #401 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
3 tasks
Contributor
✅ Reviewed — nothing survived verification0 actionable comment(s) · 2 refuted by verification · grounded on your code 🤖 developerz.ai — automated review, running on your model and your box. |
3 tasks
Contributor
There was a problem hiding this comment.
Review summary — 7 file(s), 0 finding(s).
- 1 noise file(s) auto-skipped (lockfiles/generated/vendored — re-include with path_filters)
🤖 developerz.ai review — automated, running on your model and your box. What is this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
maincould never ship. Both manifests carried0.0.56, the version already on npm, and npm refuses a version that exists, at the very end of the release. Nothing caught it earlier: the release workflow had no check at all beforenpm publish, and itsworkflow_dispatchcould publish from any branch.Bump: both packages now read
0.0.57, withaitm's exact pin onai-claude-compatandbun.lock(three lines) moving with them.mainis publishable as soon as this merges.bin/release-preflight, run byrelease.ymlbefore it installs or builds anything. It refuses, and says which reason:aitm's pin not their version;v<version>;main(the checkout now usesfetch-depth: 0soorigin/mainis there);Anything but a clear
E404from the registry is a refusal too, so a registry outage can't wave a release through.PUBLISHING.md says where the bump happens: it is the first step of every release, in a PR to
main, and the release is a GitHub Release taggedv<version>onmain. It also documents the preflight and how to run it locally.CLAUDE.md: the Packages row no longer hard-codes a version that goes stale, and
bin/release-preflighthas a row in the commands table.The acceptance item "the published package and the tree it was cut from declare the same dependency versions" is met by the next release cut from
main. Cutting it is a maintainer step, outside this PR.Verification
release-preflight.test.ts: 10/10 under Node and Bun. It runs the real script in a throwaway repo with a stubnpm(published, missing and unreachable registry) and covers the pass, the tag pass, and all six refusals. It also pins the real tree (manifests in lockstep, pin matching) and the workflow (the preflight runs before thenpm publishstep, with full history).mainrefuses with@developerz.ai/ai-claude-compat@0.0.56 is already on npm, and npm versions are immutable: bump both package.json files first. On this branch's commit it refusesthe commit being released is not on main, as it should until merge.refuses when the registry cannot be asked. Deleting the workflow step failsruns the preflight before it publishes anything.bun install --frozen-lockfileclean.actionlintclean onrelease.yml.bun run lintandtypecheck:testsclean. Integration suite: 84 pass, 0 fail, 5 skipped (the e2e smoke tests need secrets).Closes #401
🤖 Generated with Claude Code