[python] - Rework - Security updates for GHSA-58pv-8j8x-9vj2: jaraco.context and GHSA-8rrh-rw8j-w5fx: wheel#1910
Open
Kaniska244 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks the Python image vulnerability checks to address GHSA findings caused by packages vendored under setuptools (rather than only the top-level installed distributions), and updates pinned Python packaging dependencies.
Changes:
- Add a filesystem-level scan to detect vulnerable vendored
*.dist-infocopies (e.g., undersetuptools/_vendor). - Update the Python devcontainer image to newer
setuptools/wheelpins. - Bump the Python image patch version in
manifest.json.
Show a summary per file
| File | Description |
|---|---|
| src/python/test-project/test.sh | Switches from direct jaraco.context version check to a filesystem scan for vulnerable vendored copies. |
| src/python/test-project/test-utils.sh | Adds checkNoVulnerablePackage helper to locate vulnerable *.dist-info directories. |
| src/python/manifest.json | Bumps image version from 3.1.3 to 3.1.4. |
| src/python/.devcontainer/Dockerfile | Updates pinned Python packaging dependencies (setuptools, wheel) used in the image build. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Low
| # Ensure no vulnerable copies are bundled anywhere on the filesystem. These can be | ||
| # vendored inside setuptools/_vendor or other virtual envs (e.g. pipenv), which the | ||
| # importlib.metadata top-level lookup above does not catch. | ||
| checkNoVulnerablePackage "no-vulnerable-jaraco-context" "jaraco_context" "6.1.0" |
| echoStderr "Found vulnerable ${PACKAGE_PREFIX} ${version} at: ${dist_info}" | ||
| found_vulnerable=1 | ||
| fi | ||
| done < <(find / -type d -name "${PACKAGE_PREFIX}-*.dist-info" 2>/dev/null) |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "3.1.3", | |||
| "version": "3.1.4", | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of PR the #1873 as the earlier didn't solve the exact problem reported in specific path as part of the vulnerability issues. The actual problem was linked to
setuptoolsand not exactly withjaraco.contextandwheelindividually.